Changeset 205392 in webkit

Timestamp:

Sep 2, 2016 5:53:39 PM (8 years ago)

Author:

Alan Bujtas

Message:

Should never be reached failure in WebCore::floatValueForLength
​https://bugs.webkit.org/show_bug.cgi?id=139397
<rdar://problem/27704376>

Reviewed by Simon Fraser.

Source/WebCore:

floatValueForLength can't resolve unspecified Length types. Filter them out and return 0 as if they were auto.

Test: svg/css/assert-on-non-resolvable-dimension.html

• svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::valueForLength):

LayoutTests:

• svg/css/assert-on-non-resolvable-dimension-expected.txt: Added.
• svg/css/assert-on-non-resolvable-dimension.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/css/assert-on-non-resolvable-dimension-expected.txt (added)
• LayoutTests/svg/css/assert-on-non-resolvable-dimension.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGLengthContext.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-09-02  Zalan Bujtas  <zalan@apple.com>
+
+        Should never be reached failure in WebCore::floatValueForLength
+        https://bugs.webkit.org/show_bug.cgi?id=139397
+        <rdar://problem/27704376>
+
+        Reviewed by Simon Fraser.
+
+        * svg/css/assert-on-non-resolvable-dimension-expected.txt: Added.
+        * svg/css/assert-on-non-resolvable-dimension.html: Added.
+
 2016-09-02  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-02  Zalan Bujtas  <zalan@apple.com>
+
+        Should never be reached failure in WebCore::floatValueForLength
+        https://bugs.webkit.org/show_bug.cgi?id=139397
+        <rdar://problem/27704376>
+
+        Reviewed by Simon Fraser.
+
+        floatValueForLength can't resolve unspecified Length types. Filter them out and return 0 as if they were auto.
+
+        Test: svg/css/assert-on-non-resolvable-dimension.html
+
+        * svg/SVGLengthContext.cpp:
+        (WebCore::SVGLengthContext::valueForLength):
+
 2016-09-02  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/svg/SVGLengthContext.cpp

@@ -92 +92 @@
     if (length.isPercent())
         return convertValueFromPercentageToUserUnits(length.value() / 100, mode, IGNORE_EXCEPTION);
-    if (length.isAuto())
+    if (length.isAuto() || !length.isSpecified())
         return 0;