Changeset 205408 in webkit

Timestamp:

Sep 3, 2016 2:32:45 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Constructors of MathML renderers should only accept MathMLPresentationElement-derived classes
​https://bugs.webkit.org/show_bug.cgi?id=161378

Patch by Frédéric Wang <​fwang@igalia.com> on 2016-09-03
Reviewed by Darin Adler.

We update constructors of RenderMathMLBlock, to only accept MathMLPresentationElement
instances as a parameter. Similarly, we make the constructor of RenderMathMLToken only
accept MathMLTokenElement instances.

No new tests, behavior is unchanged.

• rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):

• rendering/mathml/RenderMathMLBlock.h:
• rendering/mathml/RenderMathMLToken.cpp:

(WebCore::RenderMathMLToken::RenderMathMLToken):

• rendering/mathml/RenderMathMLToken.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/mathml/RenderMathMLBlock.cpp (modified) (2 diffs)
• rendering/mathml/RenderMathMLBlock.h (modified) (2 diffs)
• rendering/mathml/RenderMathMLToken.cpp (modified) (1 diff)
• rendering/mathml/RenderMathMLToken.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-03  Frédéric Wang  <fwang@igalia.com>
+
+        Constructors of MathML renderers should only accept MathMLPresentationElement-derived classes
+        https://bugs.webkit.org/show_bug.cgi?id=161378
+
+        Reviewed by Darin Adler.
+
+        We update constructors of RenderMathMLBlock, to only accept MathMLPresentationElement
+        instances as a parameter. Similarly, we make the constructor of RenderMathMLToken only
+        accept MathMLTokenElement instances.
+
+        No new tests, behavior is unchanged.
+
+        * rendering/mathml/RenderMathMLBlock.cpp:
+        (WebCore::RenderMathMLBlock::RenderMathMLBlock):
+        * rendering/mathml/RenderMathMLBlock.h:
+        * rendering/mathml/RenderMathMLToken.cpp:
+        (WebCore::RenderMathMLToken::RenderMathMLToken):
+        * rendering/mathml/RenderMathMLToken.h:
+
 2016-09-03  Brian Weinstein  <bweinstein@apple.com>
 

trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp

@@ -35 +35 @@
 #include "MathMLElement.h"
 #include "MathMLNames.h"
+#include "MathMLPresentationElement.h"
 #include "RenderView.h"
 
@@ -45 +46 @@
 using namespace MathMLNames;
 
-RenderMathMLBlock::RenderMathMLBlock(Element& container, RenderStyle&& style)
+RenderMathMLBlock::RenderMathMLBlock(MathMLPresentationElement& container, RenderStyle&& style)
     : RenderBlock(container, WTFMove(style), 0)
     , m_mathMLStyle(MathMLStyle::create())

trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h

@@ -40 +40 @@
 
 class RenderMathMLOperator;
+class MathMLPresentationElement;
 
 class RenderMathMLBlock : public RenderBlock {
 public:
-    RenderMathMLBlock(Element&, RenderStyle&&);
+    RenderMathMLBlock(MathMLPresentationElement&, RenderStyle&&);
     RenderMathMLBlock(Document&, RenderStyle&&);
     virtual ~RenderMathMLBlock();
@@ -98 +99 @@
 class RenderMathMLTable final : public RenderTable {
 public:
-    explicit RenderMathMLTable(Element& element, RenderStyle&& style)
+    explicit RenderMathMLTable(MathMLElement& element, RenderStyle&& style)
         : RenderTable(element, WTFMove(style))
         , m_mathMLStyle(MathMLStyle::create())

trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.cpp

@@ -42 +42 @@
 using namespace MathMLNames;
 
-RenderMathMLToken::RenderMathMLToken(Element& element, RenderStyle&& style)
+RenderMathMLToken::RenderMathMLToken(MathMLTokenElement& element, RenderStyle&& style)
     : RenderMathMLBlock(element, WTFMove(style))
 {

trunk/Source/WebCore/rendering/mathml/RenderMathMLToken.h

@@ -38 +38 @@
 class RenderMathMLToken : public RenderMathMLBlock {
 public:
-    RenderMathMLToken(Element&, RenderStyle&&);
+    RenderMathMLToken(MathMLTokenElement&, RenderStyle&&);
     RenderMathMLToken(Document&, RenderStyle&&);