Changeset 205456 in webkit


Ignore:
Timestamp:
Sep 5, 2016 10:19:44 AM (8 years ago)
Author:
commit-queue@webkit.org
Message:

[Mac] Static Analyzer warnings about unused values in CDMSessionAVStreamSession.mm
https://bugs.webkit.org/show_bug.cgi?id=161598

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-09-05
Reviewed by Darin Adler.

  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
Make this parameter a reference again, accidentally lost in r195410.
Now assignments to the parameter make sense.

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r205455 r205456  
     12016-09-05  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        [Mac] Static Analyzer warnings about unused values in CDMSessionAVStreamSession.mm
     4        https://bugs.webkit.org/show_bug.cgi?id=161598
     5
     6        Reviewed by Darin Adler.
     7
     8        * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
     9        * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
     10        (WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
     11        Make this parameter a reference again, accidentally lost in r195410.
     12        Now assignments to the parameter make sense.
     13
    1142016-09-05  Youenn Fablet  <youenn@apple.com>
    215
  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h

    r197563 r205456  
    5959
    6060protected:
    61     PassRefPtr<Uint8Array> generateKeyReleaseMessage(unsigned short& errorCode, uint32_t systemCode);
     61    PassRefPtr<Uint8Array> generateKeyReleaseMessage(unsigned short& errorCode, uint32_t& systemCode);
    6262
    6363    WeakPtrFactory<CDMSessionAVStreamSession> m_weakPtrFactory;
  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm

    r204466 r205456  
    304304}
    305305
    306 PassRefPtr<Uint8Array> CDMSessionAVStreamSession::generateKeyReleaseMessage(unsigned short& errorCode, uint32_t systemCode)
     306PassRefPtr<Uint8Array> CDMSessionAVStreamSession::generateKeyReleaseMessage(unsigned short& errorCode, uint32_t& systemCode)
    307307{
    308308    ASSERT(m_mode == KeyRelease);
Note: See TracChangeset for help on using the changeset viewer.