Changeset 205484 in webkit

Timestamp:

Sep 6, 2016 9:26:05 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

[Threaded Compositor] Update timer should have lower priority than tasks scheduled in compositing thread
​https://bugs.webkit.org/show_bug.cgi?id=161625

Reviewed by Sergio Villar Senin.

This way, if a resize is scheduled, for example, and there are pending updates, the resize will happen first,
and then the updates will happen at the right size.

• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::CompositingRunLoop): Use G_PRIORITY_HIGH_IDLE as update timer priority. The actual
priority doesn't really matter as long as it's lower than G_PRIORITY_DEFAULT, because there are only two
possible sources in the compositing run loop, one for the tasks scheduled, and another one for the update timer.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-09-06  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [Threaded Compositor] Update timer should have lower priority than tasks scheduled in compositing thread
+        https://bugs.webkit.org/show_bug.cgi?id=161625
+
+        Reviewed by Sergio Villar Senin.
+
+        This way, if a resize is scheduled, for example, and there are pending updates, the resize will happen first,
+        and then the updates will happen at the right size.
+
+        * Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
+        (WebKit::CompositingRunLoop::CompositingRunLoop): Use G_PRIORITY_HIGH_IDLE as update timer priority. The actual
+        priority doesn't really matter as long as it's lower than G_PRIORITY_DEFAULT, because there are only two
+        possible sources in the compositing run loop, one for the tasks scheduled, and another one for the update timer.
+
 2016-09-06  Emanuele Aina  <emanuele.aina@collabora.com>
 

trunk/Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp

@@ -33 +33 @@
 #include <wtf/NeverDestroyed.h>
 #include <wtf/WorkQueue.h>
+
+#if USE(GLIB_EVENT_LOOP)
+#include <glib.h>
+#endif
 
 namespace WebKit {
@@ -109 +113 @@
     , m_updateFunction(WTFMove(updateFunction))
 {
+#if USE(GLIB_EVENT_LOOP)
+    m_updateTimer.setPriority(G_PRIORITY_HIGH_IDLE);
+#endif
 }