Changeset 205547 in webkit

Timestamp:

Sep 7, 2016 8:54:38 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Clarify frame callbacks behaviour in Wayland compositor
​https://bugs.webkit.org/show_bug.cgi?id=161683

Patch by Emanuele Aina <Emanuele Aina> on 2016-09-07
Reviewed by Carlos Garcia Campos.

The way we fire frame callbacks in the nested Wayland compositor can
be puzzling to developers expecting Wayland semantics, but since we
have our own mechanism to handle synchronization we don't care much
about them. Add a comment to avoid surprised Wayland developers.

• UIProcess/gtk/WaylandCompositor.cpp:

(WebKit::WaylandCompositor::Surface::commit):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/gtk/WaylandCompositor.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-09-07  Emanuele Aina  <emanuele.aina@collabora.com>
+
+        [GTK] Clarify frame callbacks behaviour in Wayland compositor
+        https://bugs.webkit.org/show_bug.cgi?id=161683
+
+        Reviewed by Carlos Garcia Campos.
+
+        The way we fire frame callbacks in the nested Wayland compositor can
+        be puzzling to developers expecting Wayland semantics, but since we
+        have our own mechanism to handle synchronization we don't care much
+        about them. Add a comment to avoid surprised Wayland developers.
+
+        * UIProcess/gtk/WaylandCompositor.cpp:
+        (WebKit::WaylandCompositor::Surface::commit):
+
 2016-09-07  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp

@@ -232 +232 @@
         m_webPage->setViewNeedsDisplay(IntRect(IntPoint::zero(), m_webPage->viewSize()));
 
+    // From a Wayland point-of-view frame callbacks should be fired where the
+    // compositor knows it has *used* the committed contents, so firing them here
+    // can be surprising but we don't need them as a throttling mechanism because
+    // rendering synchronization is handled elsewhere by WebKit.
     auto list = WTFMove(m_frameCallbackList);
     for (auto* resource : list) {