Changeset 205555 in webkit

Timestamp:

Sep 7, 2016 10:24:14 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: clicking Computed Styles sidebar "Show All" checkbox doesn't trigger relayout of Properties section
​https://bugs.webkit.org/show_bug.cgi?id=161652

Patch by Devin Rousso <Devin Rousso> on 2016-09-07
Reviewed by Brian Burg.

• UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._iterateOverProperties):
Fixed style issues from r205518 <webkit.org/b/161405>.

• UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel.prototype.get regionFlow):
(WebInspector.ComputedStyleDetailsPanel.prototype.get contentFlow):
(WebInspector.ComputedStyleDetailsPanel.prototype.get containerRegions):
Added missing space between semicolon and curly-brace.

(WebInspector.ComputedStyleDetailsPanel.prototype._computedStyleShowAllCheckboxValueChanged):
Added updateLayout call to resize and repopulate the CodeMirror instance.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CSSStyleDeclarationTextEditor.js (modified) (2 diffs)
• UserInterface/Views/ComputedStyleDetailsPanel.js (modified) (4 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-09-07  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: clicking Computed Styles sidebar "Show All" checkbox doesn't trigger relayout of Properties section
+        https://bugs.webkit.org/show_bug.cgi?id=161652
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+        (WebInspector.CSSStyleDeclarationTextEditor.prototype._iterateOverProperties):
+        Fixed style issues from r205518 <webkit.org/b/161405>.
+
+        * UserInterface/Views/ComputedStyleDetailsPanel.js:
+        (WebInspector.ComputedStyleDetailsPanel.prototype.get regionFlow):
+        (WebInspector.ComputedStyleDetailsPanel.prototype.get contentFlow):
+        (WebInspector.ComputedStyleDetailsPanel.prototype.get containerRegions):
+        Added missing space between semicolon and curly-brace.
+
+        (WebInspector.ComputedStyleDetailsPanel.prototype._computedStyleShowAllCheckboxValueChanged):
+        Added updateLayout call to resize and repopulate the CodeMirror instance.
+
 2016-09-07  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js

@@ -1220 +1220 @@
 
                     break;
+
+                case WebInspector.CSSStyleDeclarationTextEditor.PropertyVisibilityMode.ShowAll:
+                    break;
+
+                default:
+                    console.error("Invalid property visibility mode");
+                    break;
                 }
 
@@ -1228 +1235 @@
         properties = properties.filter(filterFunction);
         if (this._sortProperties)
-                properties.sort((a, b) => a.name.localeCompare(b.name));
+            properties.sort((a, b) => a.name.localeCompare(b.name));
 
         this._shownProperties = properties;

trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js

@@ -37 +37 @@
     // Public
 
-    get regionFlow() { return this._regionFlow;}
+    get regionFlow() { return this._regionFlow; }
     set regionFlow(regionFlow)
     {
@@ -46 +46 @@
     }
 
-    get contentFlow() { return this._contentFlow;}
+    get contentFlow() { return this._contentFlow; }
     set contentFlow(contentFlow)
     {
@@ -55 +55 @@
     }
 
-    get containerRegions() { return this._containerRegions;}
+    get containerRegions() { return this._containerRegions; }
     set containerRegions(regions)
     {
@@ -225 +225 @@
     _computedStyleShowAllCheckboxValueChanged(event)
     {
-        var checked = this._computedStyleShowAllCheckbox.checked;
+        let checked = this._computedStyleShowAllCheckbox.checked;
         this._computedStyleShowAllSetting.value = checked;
         this._propertiesTextEditor.showsImplicitProperties = checked;
+        this._propertiesTextEditor.updateLayout();
     }