Changeset 205665 in webkit


Ignore:
Timestamp:
Sep 8, 2016 3:02:39 PM (8 years ago)
Author:
Chris Dumez
Message:

HTMLImageElement.hspace / vspace attributes should be unsigned
https://bugs.webkit.org/show_bug.cgi?id=161754

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/html/dom/reflection-embedded-expected.txt:

Source/WebCore:

HTMLImageElement.hspace / vspace attributes should be unsigned:

Firefox agrees with the specification, however, those were signed in
webKit.

No new tests, rebaselined existing test.

  • html/HTMLImageElement.idl:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/imported/w3c/ChangeLog

    r205655 r205665  
     12016-09-08  Chris Dumez  <cdumez@apple.com>
     2
     3        HTMLImageElement.hspace / vspace attributes should be unsigned
     4        https://bugs.webkit.org/show_bug.cgi?id=161754
     5
     6        Reviewed by Alex Christensen.
     7
     8        Rebaseline W3C test now that more checks are passing.
     9
     10        * web-platform-tests/html/dom/reflection-embedded-expected.txt:
     11
    1122016-09-08  Chris Dumez  <cdumez@apple.com>
    213
  • trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt

    r205655 r205665  
    14271427PASS img.hspace: setAttribute() to -2147483649 followed by IDL get
    14281428PASS img.hspace: setAttribute() to -2147483648 followed by getAttribute()
    1429 FAIL img.hspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     1429PASS img.hspace: setAttribute() to -2147483648 followed by IDL get
    14301430PASS img.hspace: setAttribute() to -36 followed by getAttribute()
    1431 FAIL img.hspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
     1431PASS img.hspace: setAttribute() to -36 followed by IDL get
    14321432PASS img.hspace: setAttribute() to -1 followed by getAttribute()
    1433 FAIL img.hspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
     1433PASS img.hspace: setAttribute() to -1 followed by IDL get
    14341434PASS img.hspace: setAttribute() to 0 followed by getAttribute()
    14351435PASS img.hspace: setAttribute() to 0 followed by IDL get
     
    14491449PASS img.hspace: setAttribute() to "" followed by IDL get
    14501450PASS img.hspace: setAttribute() to "-1" followed by getAttribute()
    1451 FAIL img.hspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
     1451PASS img.hspace: setAttribute() to "-1" followed by IDL get
    14521452PASS img.hspace: setAttribute() to "-0" followed by getAttribute()
    14531453PASS img.hspace: setAttribute() to "-0" followed by IDL get
     
    15501550PASS img.hspace: IDL set to "-0" followed by IDL get
    15511551PASS img.hspace: IDL set to 2147483648 should not throw
    1552 FAIL img.hspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
    1553 FAIL img.hspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     1552PASS img.hspace: IDL set to 2147483648 followed by getAttribute()
     1553PASS img.hspace: IDL set to 2147483648 followed by IDL get
    15541554PASS img.hspace: IDL set to 4294967295 should not throw
    1555 FAIL img.hspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
    1556 FAIL img.hspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
     1555PASS img.hspace: IDL set to 4294967295 followed by getAttribute()
     1556PASS img.hspace: IDL set to 4294967295 followed by IDL get
    15571557PASS img.vspace: typeof IDL attribute
    15581558PASS img.vspace: IDL get with DOM attribute unset
     
    15601560PASS img.vspace: setAttribute() to -2147483649 followed by IDL get
    15611561PASS img.vspace: setAttribute() to -2147483648 followed by getAttribute()
    1562 FAIL img.vspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     1562PASS img.vspace: setAttribute() to -2147483648 followed by IDL get
    15631563PASS img.vspace: setAttribute() to -36 followed by getAttribute()
    1564 FAIL img.vspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
     1564PASS img.vspace: setAttribute() to -36 followed by IDL get
    15651565PASS img.vspace: setAttribute() to -1 followed by getAttribute()
    1566 FAIL img.vspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
     1566PASS img.vspace: setAttribute() to -1 followed by IDL get
    15671567PASS img.vspace: setAttribute() to 0 followed by getAttribute()
    15681568PASS img.vspace: setAttribute() to 0 followed by IDL get
     
    15821582PASS img.vspace: setAttribute() to "" followed by IDL get
    15831583PASS img.vspace: setAttribute() to "-1" followed by getAttribute()
    1584 FAIL img.vspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
     1584PASS img.vspace: setAttribute() to "-1" followed by IDL get
    15851585PASS img.vspace: setAttribute() to "-0" followed by getAttribute()
    15861586PASS img.vspace: setAttribute() to "-0" followed by IDL get
     
    16831683PASS img.vspace: IDL set to "-0" followed by IDL get
    16841684PASS img.vspace: IDL set to 2147483648 should not throw
    1685 FAIL img.vspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
    1686 FAIL img.vspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     1685PASS img.vspace: IDL set to 2147483648 followed by getAttribute()
     1686PASS img.vspace: IDL set to 2147483648 followed by IDL get
    16871687PASS img.vspace: IDL set to 4294967295 should not throw
    1688 FAIL img.vspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
    1689 FAIL img.vspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
     1688PASS img.vspace: IDL set to 4294967295 followed by getAttribute()
     1689PASS img.vspace: IDL set to 4294967295 followed by IDL get
    16901690PASS img.longDesc: typeof IDL attribute
    16911691PASS img.longDesc: IDL get with DOM attribute unset
  • trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt

    r205655 r205665  
    14271427PASS img.hspace: setAttribute() to -2147483649 followed by IDL get
    14281428PASS img.hspace: setAttribute() to -2147483648 followed by getAttribute()
    1429 FAIL img.hspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     1429PASS img.hspace: setAttribute() to -2147483648 followed by IDL get
    14301430PASS img.hspace: setAttribute() to -36 followed by getAttribute()
    1431 FAIL img.hspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
     1431PASS img.hspace: setAttribute() to -36 followed by IDL get
    14321432PASS img.hspace: setAttribute() to -1 followed by getAttribute()
    1433 FAIL img.hspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
     1433PASS img.hspace: setAttribute() to -1 followed by IDL get
    14341434PASS img.hspace: setAttribute() to 0 followed by getAttribute()
    14351435PASS img.hspace: setAttribute() to 0 followed by IDL get
     
    14491449PASS img.hspace: setAttribute() to "" followed by IDL get
    14501450PASS img.hspace: setAttribute() to "-1" followed by getAttribute()
    1451 FAIL img.hspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
     1451PASS img.hspace: setAttribute() to "-1" followed by IDL get
    14521452PASS img.hspace: setAttribute() to "-0" followed by getAttribute()
    14531453PASS img.hspace: setAttribute() to "-0" followed by IDL get
     
    15501550PASS img.hspace: IDL set to "-0" followed by IDL get
    15511551PASS img.hspace: IDL set to 2147483648 should not throw
    1552 FAIL img.hspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
    1553 FAIL img.hspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     1552PASS img.hspace: IDL set to 2147483648 followed by getAttribute()
     1553PASS img.hspace: IDL set to 2147483648 followed by IDL get
    15541554PASS img.hspace: IDL set to 4294967295 should not throw
    1555 FAIL img.hspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
    1556 FAIL img.hspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
     1555PASS img.hspace: IDL set to 4294967295 followed by getAttribute()
     1556PASS img.hspace: IDL set to 4294967295 followed by IDL get
    15571557PASS img.vspace: typeof IDL attribute
    15581558PASS img.vspace: IDL get with DOM attribute unset
     
    15601560PASS img.vspace: setAttribute() to -2147483649 followed by IDL get
    15611561PASS img.vspace: setAttribute() to -2147483648 followed by getAttribute()
    1562 FAIL img.vspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     1562PASS img.vspace: setAttribute() to -2147483648 followed by IDL get
    15631563PASS img.vspace: setAttribute() to -36 followed by getAttribute()
    1564 FAIL img.vspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
     1564PASS img.vspace: setAttribute() to -36 followed by IDL get
    15651565PASS img.vspace: setAttribute() to -1 followed by getAttribute()
    1566 FAIL img.vspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
     1566PASS img.vspace: setAttribute() to -1 followed by IDL get
    15671567PASS img.vspace: setAttribute() to 0 followed by getAttribute()
    15681568PASS img.vspace: setAttribute() to 0 followed by IDL get
     
    15821582PASS img.vspace: setAttribute() to "" followed by IDL get
    15831583PASS img.vspace: setAttribute() to "-1" followed by getAttribute()
    1584 FAIL img.vspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
     1584PASS img.vspace: setAttribute() to "-1" followed by IDL get
    15851585PASS img.vspace: setAttribute() to "-0" followed by getAttribute()
    15861586PASS img.vspace: setAttribute() to "-0" followed by IDL get
     
    16831683PASS img.vspace: IDL set to "-0" followed by IDL get
    16841684PASS img.vspace: IDL set to 2147483648 should not throw
    1685 FAIL img.vspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
    1686 FAIL img.vspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     1685PASS img.vspace: IDL set to 2147483648 followed by getAttribute()
     1686PASS img.vspace: IDL set to 2147483648 followed by IDL get
    16871687PASS img.vspace: IDL set to 4294967295 should not throw
    1688 FAIL img.vspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
    1689 FAIL img.vspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
     1688PASS img.vspace: IDL set to 4294967295 followed by getAttribute()
     1689PASS img.vspace: IDL set to 4294967295 followed by IDL get
    16901690PASS img.longDesc: typeof IDL attribute
    16911691PASS img.longDesc: IDL get with DOM attribute unset
  • trunk/Source/WebCore/ChangeLog

    r205663 r205665  
     12016-09-08  Chris Dumez  <cdumez@apple.com>
     2
     3        HTMLImageElement.hspace / vspace attributes should be unsigned
     4        https://bugs.webkit.org/show_bug.cgi?id=161754
     5
     6        Reviewed by Alex Christensen.
     7
     8        HTMLImageElement.hspace / vspace attributes should be unsigned:
     9        - https://html.spec.whatwg.org/#HTMLImageElement-partial
     10
     11        Firefox agrees with the specification, however, those were signed in
     12        webKit.
     13
     14        No new tests, rebaselined existing test.
     15
     16        * html/HTMLImageElement.idl:
     17
    1182016-09-08  Chris Dumez  <cdumez@apple.com>
    219
  • trunk/Source/WebCore/html/HTMLImageElement.idl

    r205655 r205665  
    2929    attribute DOMString? crossOrigin;
    3030    attribute unsigned long height;
    31     [Reflect] attribute long hspace;
     31    [Reflect] attribute unsigned long hspace;
    3232    [Reflect] attribute boolean isMap;
    3333    [Reflect, URL] attribute USVString longDesc;
     
    3737    readonly attribute USVString currentSrc;
    3838    [Reflect] attribute DOMString useMap;
    39     [Reflect] attribute long vspace;
     39    [Reflect] attribute unsigned long vspace;
    4040    attribute unsigned long width;
    4141
Note: See TracChangeset for help on using the changeset viewer.