Changeset 205691 in webkit


Ignore:
Timestamp:
Sep 8, 2016 8:49:13 PM (8 years ago)
Author:
Chris Dumez
Message:

HTMLObjectElement.hspace / vspace attributes should be unsigned
​https://bugs.webkit.org/show_bug.cgi?id=161766

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/html/dom/reflection-embedded-expected.txt:

Source/WebCore:

HTMLObjectElement.hspace / vspace attributes should be unsigned:

Firefox agrees with the specification but those were signed in WebKit.

No new tests, rebaselined existing test.

  • html/HTMLObjectElement.idl:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r205690 r205691  
     12016-09-08  Chris Dumez  <cdumez@apple.com>
     2
     3        HTMLObjectElement.hspace / vspace attributes should be unsigned
     4        https://bugs.webkit.org/show_bug.cgi?id=161766
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Rebaseline W3C test now that more checks are passing.
     9
     10        * web-platform-tests/html/dom/reflection-embedded-expected.txt:
     11
    1122016-09-08  Chris Dumez  <cdumez@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt

    r205690 r205691  
    60136013PASS object.hspace: setAttribute() to -2147483649 followed by IDL get
    60146014PASS object.hspace: setAttribute() to -2147483648 followed by getAttribute()
    6015 FAIL object.hspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     6015PASS object.hspace: setAttribute() to -2147483648 followed by IDL get
    60166016PASS object.hspace: setAttribute() to -36 followed by getAttribute()
    6017 FAIL object.hspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
     6017PASS object.hspace: setAttribute() to -36 followed by IDL get
    60186018PASS object.hspace: setAttribute() to -1 followed by getAttribute()
    6019 FAIL object.hspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
     6019PASS object.hspace: setAttribute() to -1 followed by IDL get
    60206020PASS object.hspace: setAttribute() to 0 followed by getAttribute()
    60216021PASS object.hspace: setAttribute() to 0 followed by IDL get
    … …  
    60356035PASS object.hspace: setAttribute() to "" followed by IDL get
    60366036PASS object.hspace: setAttribute() to "-1" followed by getAttribute()
    6037 FAIL object.hspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
     6037PASS object.hspace: setAttribute() to "-1" followed by IDL get
    60386038PASS object.hspace: setAttribute() to "-0" followed by getAttribute()
    60396039PASS object.hspace: setAttribute() to "-0" followed by IDL get
    … …  
    61366136PASS object.hspace: IDL set to "-0" followed by IDL get
    61376137PASS object.hspace: IDL set to 2147483648 should not throw
    6138 FAIL object.hspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
    6139 FAIL object.hspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     6138PASS object.hspace: IDL set to 2147483648 followed by getAttribute()
     6139PASS object.hspace: IDL set to 2147483648 followed by IDL get
    61406140PASS object.hspace: IDL set to 4294967295 should not throw
    6141 FAIL object.hspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
    6142 FAIL object.hspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
     6141PASS object.hspace: IDL set to 4294967295 followed by getAttribute()
     6142PASS object.hspace: IDL set to 4294967295 followed by IDL get
    61436143PASS object.standby: typeof IDL attribute
    61446144PASS object.standby: IDL get with DOM attribute unset
    … …  
    62236223PASS object.vspace: setAttribute() to -2147483649 followed by IDL get
    62246224PASS object.vspace: setAttribute() to -2147483648 followed by getAttribute()
    6225 FAIL object.vspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     6225PASS object.vspace: setAttribute() to -2147483648 followed by IDL get
    62266226PASS object.vspace: setAttribute() to -36 followed by getAttribute()
    6227 FAIL object.vspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
     6227PASS object.vspace: setAttribute() to -36 followed by IDL get
    62286228PASS object.vspace: setAttribute() to -1 followed by getAttribute()
    6229 FAIL object.vspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
     6229PASS object.vspace: setAttribute() to -1 followed by IDL get
    62306230PASS object.vspace: setAttribute() to 0 followed by getAttribute()
    62316231PASS object.vspace: setAttribute() to 0 followed by IDL get
    … …  
    62456245PASS object.vspace: setAttribute() to "" followed by IDL get
    62466246PASS object.vspace: setAttribute() to "-1" followed by getAttribute()
    6247 FAIL object.vspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
     6247PASS object.vspace: setAttribute() to "-1" followed by IDL get
    62486248PASS object.vspace: setAttribute() to "-0" followed by getAttribute()
    62496249PASS object.vspace: setAttribute() to "-0" followed by IDL get
    … …  
    63466346PASS object.vspace: IDL set to "-0" followed by IDL get
    63476347PASS object.vspace: IDL set to 2147483648 should not throw
    6348 FAIL object.vspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
    6349 FAIL object.vspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     6348PASS object.vspace: IDL set to 2147483648 followed by getAttribute()
     6349PASS object.vspace: IDL set to 2147483648 followed by IDL get
    63506350PASS object.vspace: IDL set to 4294967295 should not throw
    6351 FAIL object.vspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
    6352 FAIL object.vspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
     6351PASS object.vspace: IDL set to 4294967295 followed by getAttribute()
     6352PASS object.vspace: IDL set to 4294967295 followed by IDL get
    63536353PASS object.codeBase: typeof IDL attribute
    63546354PASS object.codeBase: IDL get with DOM attribute unset

  • trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt

    r205690 r205691  
    60136013PASS object.hspace: setAttribute() to -2147483649 followed by IDL get
    60146014PASS object.hspace: setAttribute() to -2147483648 followed by getAttribute()
    6015 FAIL object.hspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     6015PASS object.hspace: setAttribute() to -2147483648 followed by IDL get
    60166016PASS object.hspace: setAttribute() to -36 followed by getAttribute()
    6017 FAIL object.hspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
     6017PASS object.hspace: setAttribute() to -36 followed by IDL get
    60186018PASS object.hspace: setAttribute() to -1 followed by getAttribute()
    6019 FAIL object.hspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
     6019PASS object.hspace: setAttribute() to -1 followed by IDL get
    60206020PASS object.hspace: setAttribute() to 0 followed by getAttribute()
    60216021PASS object.hspace: setAttribute() to 0 followed by IDL get
    … …  
    60356035PASS object.hspace: setAttribute() to "" followed by IDL get
    60366036PASS object.hspace: setAttribute() to "-1" followed by getAttribute()
    6037 FAIL object.hspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
     6037PASS object.hspace: setAttribute() to "-1" followed by IDL get
    60386038PASS object.hspace: setAttribute() to "-0" followed by getAttribute()
    60396039PASS object.hspace: setAttribute() to "-0" followed by IDL get
    … …  
    61366136PASS object.hspace: IDL set to "-0" followed by IDL get
    61376137PASS object.hspace: IDL set to 2147483648 should not throw
    6138 FAIL object.hspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
    6139 FAIL object.hspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     6138PASS object.hspace: IDL set to 2147483648 followed by getAttribute()
     6139PASS object.hspace: IDL set to 2147483648 followed by IDL get
    61406140PASS object.hspace: IDL set to 4294967295 should not throw
    6141 FAIL object.hspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
    6142 FAIL object.hspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
     6141PASS object.hspace: IDL set to 4294967295 followed by getAttribute()
     6142PASS object.hspace: IDL set to 4294967295 followed by IDL get
    61436143PASS object.standby: typeof IDL attribute
    61446144PASS object.standby: IDL get with DOM attribute unset
    … …  
    62236223PASS object.vspace: setAttribute() to -2147483649 followed by IDL get
    62246224PASS object.vspace: setAttribute() to -2147483648 followed by getAttribute()
    6225 FAIL object.vspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     6225PASS object.vspace: setAttribute() to -2147483648 followed by IDL get
    62266226PASS object.vspace: setAttribute() to -36 followed by getAttribute()
    6227 FAIL object.vspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
     6227PASS object.vspace: setAttribute() to -36 followed by IDL get
    62286228PASS object.vspace: setAttribute() to -1 followed by getAttribute()
    6229 FAIL object.vspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
     6229PASS object.vspace: setAttribute() to -1 followed by IDL get
    62306230PASS object.vspace: setAttribute() to 0 followed by getAttribute()
    62316231PASS object.vspace: setAttribute() to 0 followed by IDL get
    … …  
    62456245PASS object.vspace: setAttribute() to "" followed by IDL get
    62466246PASS object.vspace: setAttribute() to "-1" followed by getAttribute()
    6247 FAIL object.vspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
     6247PASS object.vspace: setAttribute() to "-1" followed by IDL get
    62486248PASS object.vspace: setAttribute() to "-0" followed by getAttribute()
    62496249PASS object.vspace: setAttribute() to "-0" followed by IDL get
    … …  
    63466346PASS object.vspace: IDL set to "-0" followed by IDL get
    63476347PASS object.vspace: IDL set to 2147483648 should not throw
    6348 FAIL object.vspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
    6349 FAIL object.vspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
     6348PASS object.vspace: IDL set to 2147483648 followed by getAttribute()
     6349PASS object.vspace: IDL set to 2147483648 followed by IDL get
    63506350PASS object.vspace: IDL set to 4294967295 should not throw
    6351 FAIL object.vspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
    6352 FAIL object.vspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
     6351PASS object.vspace: IDL set to 4294967295 followed by getAttribute()
     6352PASS object.vspace: IDL set to 4294967295 followed by IDL get
    63536353PASS object.codeBase: typeof IDL attribute
    63546354PASS object.codeBase: IDL get with DOM attribute unset

  • trunk/Source/WebCore/ChangeLog

    r205690 r205691  
     12016-09-08  Chris Dumez  <cdumez@apple.com>
     2
     3        HTMLObjectElement.hspace / vspace attributes should be unsigned
     4        https://bugs.webkit.org/show_bug.cgi?id=161766
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        HTMLObjectElement.hspace / vspace attributes should be unsigned:
     9        - https://html.spec.whatwg.org/#HTMLObjectElement-partial
     10
     11        Firefox agrees with the specification but those were signed in WebKit.
     12
     13        No new tests, rebaselined existing test.
     14
     15        * html/HTMLObjectElement.idl:
     16
    1172016-09-08  Chris Dumez  <cdumez@apple.com>
    218

  • trunk/Source/WebCore/html/HTMLObjectElement.idl

    r205690 r205691  
    3434    [Reflect] attribute boolean declare;
    3535    [Reflect] attribute DOMString height;
    36     [Reflect] attribute long hspace;
     36    [Reflect] attribute unsigned long hspace;
    3737    [Reflect] attribute DOMString name;
    3838    [Reflect] attribute DOMString standby;
    3939    [Reflect] attribute DOMString type;
    4040    [Reflect] attribute DOMString useMap;
    41     [Reflect] attribute long vspace;
     41    [Reflect] attribute unsigned long vspace;
    4242    [Reflect] attribute DOMString width;
    4343    readonly attribute boolean willValidate;
Note: See TracChangeset for help on using the changeset viewer.