Changeset 20570 in webkit

Timestamp:

Mar 29, 2007 1:41:22 AM (17 years ago)

Author:

hyatt

Message:

Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
reporting display:none properly when it is set. This is bugzilla bug 13103.

Reviewed by mitz

• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSComputedStyleDeclaration.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-03-29  David Hyatt  <hyatt@apple.com>
+
+        Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
+        reporting display:none properly when it is set.  This is bugzilla bug 13103.
+
+        Reviewed by mitz
+
+        * css/CSSComputedStyleDeclaration.cpp:
+        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
+
 2007-03-28  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/css/CSSComputedStyleDeclaration.cpp

@@ -482 +482 @@
         node->document()->updateLayout();
 
-    // FIXME: This should work even if we do not have a renderer.
+    // FIXME: This should work even if we do not have a renderer for all properties.
     RenderObject* renderer = node->renderer();
-    if (!renderer)
+    if (!renderer) {
+        // Handle display:none at the very least.  By definition if we don't have a renderer
+        // we are considered to have no display.
+        if (propertyID == CSS_PROP_DISPLAY)
+            return new CSSPrimitiveValue(CSS_VAL_NONE);
         return 0;
+    }
 
     RenderStyle* style = renderer->style();