Changeset 205792 in webkit

Timestamp:

Sep 11, 2016 5:03:02 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION (r205754): Web Inspector: Cannot click on links to stylesheets in Rules sidebar
​https://bugs.webkit.org/show_bug.cgi?id=161838

Patch by Devin Rousso <Devin Rousso> on 2016-09-11
Reviewed by Brian Burg.

• UserInterface/Views/CSSStyleDeclarationSection.css:

(.style-declaration-section > .header > textarea):
(.style-declaration-section > .header > .origin):
Added z-index to the non-selector elements of the header. Also limited the size of the
selector textarea to just the size of the displayed selector text.

• UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor):
Fixed invalid enum value for propertyVisibilityMode.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CSSStyleDeclarationSection.css (modified) (2 diffs)
• UserInterface/Views/CSSStyleDeclarationTextEditor.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-09-11  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        REGRESSION (r205754): Web Inspector: Cannot click on links to stylesheets in Rules sidebar
+        https://bugs.webkit.org/show_bug.cgi?id=161838
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/CSSStyleDeclarationSection.css:
+        (.style-declaration-section > .header > textarea):
+        (.style-declaration-section > .header > .origin):
+        Added z-index to the non-selector elements of the header.  Also limited the size of the
+        selector textarea to just the size of the displayed selector text.
+
+        * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+        (WebInspector.CSSStyleDeclarationTextEditor):
+        Fixed invalid enum value for propertyVisibilityMode.
+
 2016-09-09  Devin Rousso  <dcrousso+webkit@gmail.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css

@@ -102 +102 @@
     bottom: 0;
     left: 0;
-    width: 100%;
-    height: 100%;
-    margin: 0;
-    padding: var(--style-declaration-section-header-padding);
+    margin: var(--style-declaration-section-header-padding);
+    padding: 0;
     font-family: Menlo, monospace;
     color: black;
@@ -135 +133 @@
 
 .style-declaration-section > .header > .origin {
+    position: relative;
+    z-index: 1;
+
     line-height: 10px;
 

trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js

@@ -38 +38 @@
         this._mouseDownCursorPosition = null;
 
-        this._propertyVisibilityMode = WebInspector.CSSStyleDeclarationTextEditor.PropertyVisibilityMode.Shown;
+        this._propertyVisibilityMode = WebInspector.CSSStyleDeclarationTextEditor.PropertyVisibilityMode.ShowAll;
         this._showsImplicitProperties = true;
         this._alwaysShowPropertyNames = {};