Changeset 206046 in webkit

Timestamp:

Sep 16, 2016 1:49:16 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: make Object.awaitEvent synchronously add an event listener
​https://bugs.webkit.org/show_bug.cgi?id=162066

Reviewed by Brian Burg.

Patch by Devin Rousso <Devin Rousso> on 2016-09-16

• UserInterface/Base/Object.js:

(WebInspector.Object.awaitEvent):
Utilize a WebInspector.WrappedPromise to not worry about adding the singleFireEventListener
on the next tick due to the promise construction.

• UserInterface/TestStub.html:

Add WebInspector.WrappedPromise.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Object.js (modified) (1 diff)
• UserInterface/TestStub.html (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-09-16  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: make Object.awaitEvent synchronously add an event listener
+        https://bugs.webkit.org/show_bug.cgi?id=162066
+
+         Reviewed by Brian Burg.
+
+        * UserInterface/Base/Object.js:
+        (WebInspector.Object.awaitEvent):
+        Utilize a WebInspector.WrappedPromise to not worry about adding the singleFireEventListener
+        on the next tick due to the promise construction.
+
+        * UserInterface/TestStub.html:
+        Add WebInspector.WrappedPromise.
+
 2016-09-16  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Object.js

@@ -101 +101 @@
     static awaitEvent(eventType)
     {
-        return new Promise((resolve, reject) => {
-            this.singleFireEventListener(eventType, (event) => resolve(event), null);
-        });
+        let wrapper = new WebInspector.WrappedPromise;
+        this.singleFireEventListener(eventType, (event) => wrapper.resolve(event));
+        return wrapper.promise;
     }
 

trunk/Source/WebInspectorUI/UserInterface/TestStub.html

@@ -38 +38 @@
     <script src="Models/CallingContextTree.js"></script>
     <script src="Models/CallingContextTreeNode.js"></script>
+    <script src="Models/WrappedPromise.js"></script>
 
     <script src="Test/TestSuite.js"></script>