Changeset 20607 in webkit

Timestamp:

Mar 29, 2007 7:36:16 PM (17 years ago)

Author:

weinig

Message:

LayoutTests:

Reviewed by Darin.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=13166 REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table

• fast/tokenizer/write-partial-entity-expected.txt: Added.
• fast/tokenizer/write-partial-entity.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=13166 REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table

Test: fast/tokenizer/write-partial-entity.html

• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Reordered to avoid resetting the buffer position after script execution which can write to the buffer.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/tokenizer/write-partial-entity-expected.txt (added)
• LayoutTests/fast/tokenizer/write-partial-entity.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLTokenizer.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-03-29  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=13166
+          REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table
+
+        * fast/tokenizer/write-partial-entity-expected.txt: Added.
+        * fast/tokenizer/write-partial-entity.html: Added.
+
 2007-03-29  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-03-29  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=13166
+          REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table
+
+        Test: fast/tokenizer/write-partial-entity.html
+
+        * html/HTMLTokenizer.cpp:
+        (WebCore::HTMLTokenizer::parseTag): Reordered to avoid resetting the buffer position
+        after script execution which can write to the buffer.
+
 2007-03-29  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebCore/html/HTMLTokenizer.cpp

@@ -1162 +1162 @@
 
             RefPtr<Node> n = processToken();
+            m_cBufferPos = cBufferPos;
             if (n) {
                 if ((tagName == preTag || tagName == listingTag) && !inViewSourceMode()) {
@@ -1226 +1227 @@
             if (tagName == plaintextTag)
                 state.setInPlainText(beginTag);
-            m_cBufferPos = cBufferPos;
             return state; // Finished parsing tag!
         }