Changeset 206294 in webkit

Timestamp:

Sep 23, 2016 1:02:59 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Improve performance when resizing a window with multiple web views in X11
​https://bugs.webkit.org/show_bug.cgi?id=162413

Reviewed by Michael Catanzaro.

Resizing a window with a single way view performs good enough, but when adding more tabs, the performance
decreases a lot. This is because resize is a sync operation, and the UI process waits for the web process to
have a new update for the new size, while still draws the previous frame. This is needed for the visible web
view, to avoid flickering and artifacts while resizing, but for all other hidden web views, we don't really need
to block the UI process. This doesn't happen in Wayland, because in Wayland we never block the UI process while
waiting for web process update after a resize.

• UIProcess/AcceleratedDrawingAreaProxy.cpp:

(WebKit::AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState): Return early if the web
view is not visible.

• UIProcess/gtk/AcceleratedBackingStoreX11.cpp:

(WebKit::AcceleratedBackingStoreX11::update): Only schedule a redraw on a damage event when the view is visible.

• WebProcess/WebPage/gtk/AcceleratedSurfaceX11.cpp:

(WebKit::AcceleratedSurfaceX11::AcceleratedSurfaceX11): Do a XSync right after creating the new pixmap.
(WebKit::AcceleratedSurfaceX11::resize): Ditto.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/AcceleratedDrawingAreaProxy.cpp (modified) (1 diff)
• UIProcess/gtk/AcceleratedBackingStoreX11.cpp (modified) (1 diff)
• WebProcess/WebPage/gtk/AcceleratedSurfaceX11.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Improve performance when resizing a window with multiple web views in X11
+        https://bugs.webkit.org/show_bug.cgi?id=162413
+
+        Reviewed by Michael Catanzaro.
+
+        Resizing a window with a single way view performs good enough, but when adding more tabs, the performance
+        decreases a lot. This is because resize is a sync operation, and the UI process waits for the web process to
+        have a new update for the new size, while still draws the previous frame. This is needed for the visible web
+        view, to avoid flickering and artifacts while resizing, but for all other hidden web views, we don't really need
+        to block the UI process. This doesn't happen in Wayland, because in Wayland we never block the UI process while
+        waiting for web process update after a resize.
+
+        * UIProcess/AcceleratedDrawingAreaProxy.cpp:
+        (WebKit::AcceleratedDrawingAreaProxy::waitForAndDispatchDidUpdateBackingStoreState): Return early if the web
+        view is not visible.
+        * UIProcess/gtk/AcceleratedBackingStoreX11.cpp:
+        (WebKit::AcceleratedBackingStoreX11::update): Only schedule a redraw on a damage event when the view is visible.
+        * WebProcess/WebPage/gtk/AcceleratedSurfaceX11.cpp:
+        (WebKit::AcceleratedSurfaceX11::AcceleratedSurfaceX11): Do a XSync right after creating the new pixmap.
+        (WebKit::AcceleratedSurfaceX11::resize): Ditto.
+
 2016-09-22  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebKit2/UIProcess/AcceleratedDrawingAreaProxy.cpp

@@ -221 +221 @@
     if (m_webPageProxy.process().state() == WebProcessProxy::State::Launching)
         return;
+    if (!m_webPageProxy.isViewVisible())
+        return;
 
 #if PLATFORM(WAYLAND)

trunk/Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreX11.cpp

@@ -156 +156 @@
     m_damage = XDamageCreate(display, pixmap, XDamageReportNonEmpty);
     XDamageNotifier::singleton().add(m_damage.get(), [this] {
-        gtk_widget_queue_draw(m_webPage.viewWidget());
+        if (m_webPage.isViewVisible())
+            gtk_widget_queue_draw(m_webPage.viewWidget());
     });
 }

trunk/Source/WebKit2/WebProcess/WebPage/gtk/AcceleratedSurfaceX11.cpp

@@ -105 +105 @@
     XCompositeRedirectWindow(m_display, m_window.get(), CompositeRedirectManual);
     m_pixmap = XCompositeNameWindowPixmap(m_display, m_window.get());
+    XSync(m_display, False);
 }
 
@@ -130 +131 @@
     RunLoop::main().dispatchAfter(std::chrono::seconds(5), [pixmap = WTFMove(m_pixmap)] { });
     m_pixmap = XCompositeNameWindowPixmap(m_display, m_window.get());
+    XSync(m_display, False);
     return true;
 }