Changeset 206363 in webkit


Ignore:
Timestamp:
Sep 25, 2016 10:28:07 AM (8 years ago)
Author:
Matt Baker
Message:

Web Inspector: REGRESSION (r203437): DOM not updated when editing Box Model values (border, margin, etc)
https://bugs.webkit.org/show_bug.cgi?id=162522
<rdar://problem/28458203>

Reviewed by Brian Burg.

  • UserInterface/Views/BoxModelDetailsSectionRow.js:

(WebInspector.BoxModelDetailsSectionRow.prototype._refresh):
(WebInspector.BoxModelDetailsSectionRow.prototype._highlightDOMNode):
(WebInspector.BoxModelDetailsSectionRow.prototype._editingEnded):
Drive-by style fix for delete. Also removed unused properties.
(WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode.toggleInlineStyleProperty):
Use priority "important" instead of "!important".

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r206339 r206363  
     12016-09-25  Matt Baker  <mattbaker@apple.com>
     2
     3        Web Inspector: REGRESSION (r203437): DOM not updated when editing Box Model values (border, margin, etc)
     4        https://bugs.webkit.org/show_bug.cgi?id=162522
     5        <rdar://problem/28458203>
     6
     7        Reviewed by Brian Burg.
     8
     9        * UserInterface/Views/BoxModelDetailsSectionRow.js:
     10        (WebInspector.BoxModelDetailsSectionRow.prototype._refresh):
     11        (WebInspector.BoxModelDetailsSectionRow.prototype._highlightDOMNode):
     12        (WebInspector.BoxModelDetailsSectionRow.prototype._editingEnded):
     13        Drive-by style fix for `delete`. Also removed unused properties.
     14        (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput.resolvedNode.toggleInlineStyleProperty):
     15        Use priority "important" instead of "!important".
     16
    1172016-09-23  Joseph Pecoraro  <pecoraro@apple.com>
    218
  • trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js

    r205425 r206363  
    5454    {
    5555        if (this._ignoreNextRefresh) {
    56             delete this._ignoreNextRefresh;
     56            this._ignoreNextRefresh = false;
    5757            return;
    5858        }
     
    8787            WebInspector.domTreeManager.highlightDOMNode(nodeId, mode);
    8888        } else {
    89             delete this._highlightMode;
     89            this._highlightMode = null;
    9090            WebInspector.domTreeManager.hideDOMNodeHighlight();
    9191        }
     
    362362    _editingEnded(element, context)
    363363    {
    364         delete this.originalPropertyData;
    365         delete this.previousPropertyDataCandidate;
    366364        element.removeEventListener("keydown", context.keyDownHandler, false);
    367         delete this._isEditingMetrics;
     365        this._isEditingMetrics = false;
    368366    }
    369367
     
    421419            function toggleInlineStyleProperty(property, value)
    422420            {
    423                 this.style.setProperty(property, value, "!important");
     421                this.style.setProperty(property, value, "important");
    424422            }
    425423
Note: See TracChangeset for help on using the changeset viewer.