Changeset 206465 in webkit

Timestamp:

Sep 27, 2016 2:54:38 PM (8 years ago)

Author:

Dewei Zhu

Message:

Extend perf dashboard to support multiple summary pages.
​https://bugs.webkit.org/show_bug.cgi?id=162594

Reviewed by Ryosuke Niwa.

Start support multiple summary pages instead of one.
Specify 'summaryPages' as key that map to a list of summaries which follows
current 'summary' format in 'config.json' but with 2 more properties:

'name': specifying the name shows on perf dashboard,
'route': specifying the path to this page.

• public/include/manifest.php:
• public/v3/main.js:

(main):
(main.): Deleted.

• public/v3/models/manifest.js:

(Manifest._didFetchManifest):
(Manifest):

• public/v3/pages/summary-page.js:

(SummaryPage):
(SummaryPage.prototype.routeName):

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/include/manifest.php (modified) (1 diff)
• public/v3/main.js (modified) (4 diffs)
• public/v3/models/manifest.js (modified) (1 diff)
• public/v3/pages/summary-page.js (modified) (3 diffs)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2016-09-27  Dewei Zhu  <dewei_zhu@apple.com>
+
+        Extend perf dashboard to support multiple summary pages.
+        https://bugs.webkit.org/show_bug.cgi?id=162594
+
+        Reviewed by Ryosuke Niwa.
+
+        Start support multiple summary pages instead of one.
+        Specify 'summaryPages' as key that map to a list of summaries which follows
+        current 'summary' format in 'config.json' but with 2 more properties:
+           'name': specifying the name shows on perf dashboard,
+           'route': specifying the path to this page.
+
+        * public/include/manifest.php:
+        * public/v3/main.js:
+        (main):
+        (main.): Deleted.
+        * public/v3/models/manifest.js:
+        (Manifest._didFetchManifest):
+        (Manifest):
+        * public/v3/pages/summary-page.js:
+        (SummaryPage):
+        (SummaryPage.prototype.routeName):
+
 2016-08-09  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/perf.webkit.org/public/include/manifest.php

@@ -42 +42 @@
             'bugTrackers' => (object)$this->bug_trackers($repositories_table),
             'dashboards' => (object)config('dashboards'),
-            'summary' => (object)config('summary'),
+            'summaryPages' => (object)config('summaryPages'),
         );
 

trunk/Websites/perf.webkit.org/public/v3/main.js

@@ -21 +21 @@
         var chartsToolbar = new ChartsToolbar;
 
-        var summaryPage = manifest.summary ? new SummaryPage(manifest.summary) : null;
+        var summaryPages = [];
+        if (manifest.summaryPages) {
+            for (var summaryPage of manifest.summaryPages)
+                summaryPages.push(new SummaryPage(summaryPage));
+        }
+
         var chartsPage = new ChartsPage(chartsToolbar);
         var analysisCategoryPage = new AnalysisCategoryPage();
@@ -35 +40 @@
 
         var heading = new Heading(manifest.siteTitle);
-        heading.addPageGroup([summaryPage, chartsPage, analysisCategoryPage].filter(function (page) { return page; }));
+        heading.addPageGroup(summaryPages.concat([chartsPage, analysisCategoryPage]));
 
         heading.setTitle(manifest.siteTitle);
@@ -41 +46 @@
 
         var router = new PageRouter();
-        if(summaryPage)
+        for (var summaryPage of summaryPages)
             router.addPage(summaryPage);
         router.addPage(chartsPage);
@@ -51 +56 @@
             router.addPage(page);
 
-        if (summaryPage)
-            router.setDefaultPage(summaryPage);
-        else if (dashboardPages)
+        if (summaryPages.length)
+            router.setDefaultPage(summaryPages[0]);
+        else if (dashboardPages.length)
             router.setDefaultPage(dashboardPages[0]);
         else

trunk/Websites/perf.webkit.org/public/v3/models/manifest.js

@@ -49 +49 @@
             siteTitle: rawResponse.siteTitle,
             dashboards: rawResponse.dashboards, // FIXME: Add an abstraction around dashboards.
-            summary: rawResponse.summary,
+            summaryPages: rawResponse.summaryPages,
         }
     }

trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js

@@ -4 +4 @@
     constructor(summarySettings)
     {
-        super('Summary', null);
-
+        super(summarySettings.name, null);
+
+        this._route = summarySettings.route;
         this._table = {
             heading: summarySettings.platformGroups,
@@ -27 +28 @@
     }
 
-    routeName() { return 'summary'; }
+    routeName() { return `summary/${this._route}`; }
 
     open(state)
@@ -38 +39 @@
             group.fetchAndComputeSummary(timeRange).then(this.render.bind(this));
     }
-    
+
     render()
     {