Changeset 206519 in webkit

Timestamp:

Sep 28, 2016 8:34:11 AM (8 years ago)

Author:

Michael Catanzaro

Message:

[GTK] Add Chrome UA quirk
​https://bugs.webkit.org/show_bug.cgi?id=162617

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Add Chrome UA quirk and use it on typekit.net, typekit.com, youtube.com, slack.com, and
any domain that begins with "google".

• platform/gtk/UserAgentGtk.cpp:

(WebCore::buildUserAgentString):
(WebCore::urlRequiresChromeBrowser):
(WebCore::standardUserAgentForURL):

Tools:

Update test. This portion of the commit was actually unreviewed.

• TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/gtk/UserAgentGtk.cpp (modified) (4 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [GTK] Add Chrome UA quirk
+        https://bugs.webkit.org/show_bug.cgi?id=162617
+
+        Reviewed by Carlos Garcia Campos.
+
+        Add Chrome UA quirk and use it on typekit.net, typekit.com, youtube.com, slack.com, and
+        any domain that begins with "google".
+
+        * platform/gtk/UserAgentGtk.cpp:
+        (WebCore::buildUserAgentString):
+        (WebCore::urlRequiresChromeBrowser):
+        (WebCore::standardUserAgentForURL):
+
 2016-09-28  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp

@@ -47 +47 @@
 public:
     enum UserAgentQuirk {
+        NeedsChromeBrowser,
         NeedsMacintoshPlatform,
 
@@ -126 +127 @@
     uaString.appendLiteral(") AppleWebKit/");
     uaString.append(versionForUAString());
+    uaString.appendLiteral(" (KHTML, like Gecko) ");
+
+    // Note that Chrome UAs advertise *both* Chrome and Safari.
+    if (quirks.contains(UserAgentQuirks::NeedsChromeBrowser))
+        uaString.append("Chrome/51.0.2704.106 ");
+
     // Version/X is mandatory *before* Safari/X to be a valid Safari UA. See
     // https://bugs.webkit.org/show_bug.cgi?id=133403 for details.
-    uaString.appendLiteral(" (KHTML, like Gecko) Version/10.0 Safari/");
+    uaString.appendLiteral(" Version/10.0 Safari/");
     uaString.append(versionForUAString());
 
@@ -160 +167 @@
 }
 
+// Be careful with this quirk: it's an invitation for sites to use JavaScript we can't handle.
+static bool urlRequiresChromeBrowser(const URL& url)
+{
+    String baseDomain = topPrivatelyControlledDomain(url.host());
+
+    // Needed for fonts on many sites, https://bugs.webkit.org/show_bug.cgi?id=147296
+    if (baseDomain == "typekit.net" || baseDomain == "typekit.com")
+        return true;
+
+    // Shut off Chrome ads. Avoid missing features on maps.google.com.
+    if (baseDomain.startsWith("google"))
+        return true;
+
+    // Needed for YouTube 360 (requires ENABLE_MEDIA_SOURCE).
+    if (baseDomain == "youtube.com")
+        return true;
+
+    // Slack completely blocks users with our standard user agent.
+    if (baseDomain == "slack.com")
+        return true;
+
+    return false;
+}
+
 static bool urlRequiresMacintoshPlatform(const URL& url)
 {
@@ -179 +210 @@
     ASSERT(!url.isNull());
     UserAgentQuirks quirks;
-    if (urlRequiresMacintoshPlatform(url)) {
+    if (urlRequiresChromeBrowser(url))
+        quirks.add(UserAgentQuirks::NeedsChromeBrowser);
+    if (urlRequiresMacintoshPlatform(url))
         quirks.add(UserAgentQuirks::NeedsMacintoshPlatform);
-    }
 
     // The null string means we don't need a specific UA for the given URL.

trunk/Tools/ChangeLog

@@ +1 @@
+2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [GTK] Add Chrome UA quirk
+        https://bugs.webkit.org/show_bug.cgi?id=162617
+
+        Reviewed by Carlos Garcia Campos.
+
+        Update test. This portion of the commit was actually unreviewed.
+
+        * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
+        (TestWebKitAPI::TEST):
+
 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp

@@ -44 +44 @@
     EXPECT_TRUE(uaString.contains("Mac OS X"));
     EXPECT_FALSE(uaString.contains("Linux"));
+    EXPECT_FALSE(uaString.contains("Chrome"));
+
+    // google domains require Chrome in the UA
+    uaString = standardUserAgentForURL(URL(ParsedURLString, "http://www.google.es/"));
+    EXPECT_FALSE(uaString.contains("Macintosh"));
+    EXPECT_FALSE(uaString.contains("Mac OS X"));
+    EXPECT_TRUE(uaString.contains("Linux"));
+    EXPECT_TRUE(uaString.contains("Chrome"));
+
+    uaString = standardUserAgentForURL(URL(ParsedURLString, "http://maps.google.com/"));
+    EXPECT_FALSE(uaString.contains("Macintosh"));
+    EXPECT_FALSE(uaString.contains("Mac OS X"));
+    EXPECT_TRUE(uaString.contains("Linux"));
+    EXPECT_TRUE(uaString.contains("Chrome"));
+
+    // Slack requires Chrome in the UA
+    uaString = standardUserAgentForURL(URL(ParsedURLString, "http://www.slack.com/"));
+    EXPECT_FALSE(uaString.contains("Macintosh"));
+    EXPECT_FALSE(uaString.contains("Mac OS X"));
+    EXPECT_TRUE(uaString.contains("Linux"));
+    EXPECT_TRUE(uaString.contains("Chrome"));
 }