Changeset 206591 in webkit

Timestamp:

Sep 29, 2016 11:09:59 AM (8 years ago)

Author:

Simon Fraser

Message:

Fix hit testing on display:block <svg> elements
​https://bugs.webkit.org/show_bug.cgi?id=162717
rdar://problem/23261130

Reviewed by Zalan Bujtas.
Source/WebCore:

RenderSVGRoot::nodeAtPoint() needs to test for both the HitTestBlockBackground and
HitTestChildBlockBackground phases, since we only get the HitTestChildBlockBackground
phase when the <svg> is a block. This is similar to code in RenderTable::nodeAtPoint(),
and matches Blink code.

This fixes the point dragging on ​http://anthonydugois.com/svg-path-builder/.

Test: svg/hittest/block-svg.html

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

LayoutTests:

Test hit testing on inline and block <svg> elements.

• svg/hittest/block-svg-expected.txt: Added.
• svg/hittest/block-svg.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/hittest/block-svg-expected.txt (added)
• LayoutTests/svg/hittest/block-svg.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/svg/RenderSVGRoot.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-09-29  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix hit testing on display:block <svg> elements
+        https://bugs.webkit.org/show_bug.cgi?id=162717
+        rdar://problem/23261130
+
+        Reviewed by Zalan Bujtas.
+        
+        Test hit testing on inline and block <svg> elements.
+
+        * svg/hittest/block-svg-expected.txt: Added.
+        * svg/hittest/block-svg.html: Added.
+
 2016-09-29  Saam Barati  <sbarati@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-29  Simon Fraser  <simon.fraser@apple.com>
+
+        Fix hit testing on display:block <svg> elements
+        https://bugs.webkit.org/show_bug.cgi?id=162717
+        rdar://problem/23261130
+
+        Reviewed by Zalan Bujtas.
+
+        RenderSVGRoot::nodeAtPoint() needs to test for both the HitTestBlockBackground and
+        HitTestChildBlockBackground phases, since we only get the HitTestChildBlockBackground
+        phase when the <svg> is a block. This is similar to code in RenderTable::nodeAtPoint(),
+        and matches Blink code.
+        
+        This fixes the point dragging on http://anthonydugois.com/svg-path-builder/.
+
+        Test: svg/hittest/block-svg.html
+
+        * rendering/svg/RenderSVGRoot.cpp:
+        (WebCore::RenderSVGRoot::nodeAtPoint):
+
 2016-09-29  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp

@@ -445 +445 @@
 
     // If we didn't early exit above, we've just hit the container <svg> element. Unlike SVG 1.1, 2nd Edition allows container elements to be hit.
-    if (hitTestAction == HitTestBlockBackground && visibleToHitTesting()) {
+    if ((hitTestAction == HitTestBlockBackground || hitTestAction == HitTestChildBlockBackground) && visibleToHitTesting()) {
         // Only return true here, if the last hit testing phase 'BlockBackground' is executed. If we'd return true in the 'Foreground' phase,
         // hit testing would stop immediately. For SVG only trees this doesn't matter. Though when we have a <foreignObject> subtree we need