Changeset 206630 in webkit
- Timestamp:
- Sep 29, 2016 10:05:35 PM (7 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 11 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r206627 r206630 1 2016-09-29 Chris Dumez <cdumez@apple.com> 2 3 Add support for download attribute on area elements 4 https://bugs.webkit.org/show_bug.cgi?id=162765 5 6 Reviewed by Brent Fulgham. 7 8 Add layout test coverage. 9 10 * http/tests/download/area-download-expected.txt: Added. 11 * http/tests/download/area-download.html: Added. 12 * http/tests/download/resources/FAIL-notify-done.html: Added. 13 1 14 2016-09-29 Jiewen Tan <jiewen_tan@apple.com> 2 15 -
trunk/LayoutTests/imported/w3c/ChangeLog
r206588 r206630 1 2016-09-29 Chris Dumez <cdumez@apple.com> 2 3 Add support for download attribute on area elements 4 https://bugs.webkit.org/show_bug.cgi?id=162765 5 6 Reviewed by Brent Fulgham. 7 8 Rebaseline W3C test now that more checks are passing. 9 10 * web-platform-tests/html/dom/reflection-embedded-expected.txt: 11 1 12 2016-09-29 Chris Dumez <cdumez@apple.com> 2 13 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt
r206260 r206630 2271 2271 PASS HTMLAreaElement interface: attribute shape 2272 2272 PASS HTMLAreaElement interface: attribute target 2273 FAIL HTMLAreaElement interface: attribute download assert_true: The prototype object must have a property "download" expected true got false 2273 PASS HTMLAreaElement interface: attribute download 2274 2274 PASS HTMLAreaElement interface: attribute ping 2275 2275 PASS HTMLAreaElement interface: attribute rel … … 2294 2294 PASS HTMLAreaElement interface: document.createElement("area") must inherit property "shape" with the proper type (2) 2295 2295 PASS HTMLAreaElement interface: document.createElement("area") must inherit property "target" with the proper type (3) 2296 FAIL HTMLAreaElement interface: document.createElement("area") must inherit property "download" with the proper type (4) assert_inherits: property "download" not found in prototype chain 2296 PASS HTMLAreaElement interface: document.createElement("area") must inherit property "download" with the proper type (4) 2297 2297 PASS HTMLAreaElement interface: document.createElement("area") must inherit property "ping" with the proper type (5) 2298 2298 PASS HTMLAreaElement interface: document.createElement("area") must inherit property "rel" with the proper type (6) -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt
r206260 r206630 14705 14705 PASS area.target: IDL set to object "test-valueOf" followed by getAttribute() 14706 14706 PASS area.target: IDL set to object "test-valueOf" followed by IDL get 14707 FAIL area.download: typeof IDL attribute assert_equals: expected "string" but got "undefined" 14708 FAIL area.download: IDL get with DOM attribute unset assert_equals: expected (string) "" but got (undefined) undefined 14707 PASS area.download: typeof IDL attribute 14708 PASS area.download: IDL get with DOM attribute unset 14709 14709 PASS area.download: setAttribute() to "" followed by getAttribute() 14710 FAIL area.download: setAttribute() to "" followed by IDL get assert_equals: expected (string) "" but got (undefined) undefined 14710 PASS area.download: setAttribute() to "" followed by IDL get 14711 14711 PASS area.download: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute() 14712 FAIL area.download: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get assert_equals: expected (string) " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " but got (undefined) undefined 14712 PASS area.download: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get 14713 14713 PASS area.download: setAttribute() to undefined followed by getAttribute() 14714 FAIL area.download: setAttribute() to undefined followed by IDL get assert_equals: expected (string) "undefined" but got (undefined) undefined 14714 PASS area.download: setAttribute() to undefined followed by IDL get 14715 14715 PASS area.download: setAttribute() to 7 followed by getAttribute() 14716 FAIL area.download: setAttribute() to 7 followed by IDL get assert_equals: expected (string) "7" but got (undefined) undefined 14716 PASS area.download: setAttribute() to 7 followed by IDL get 14717 14717 PASS area.download: setAttribute() to 1.5 followed by getAttribute() 14718 FAIL area.download: setAttribute() to 1.5 followed by IDL get assert_equals: expected (string) "1.5" but got (undefined) undefined 14718 PASS area.download: setAttribute() to 1.5 followed by IDL get 14719 14719 PASS area.download: setAttribute() to true followed by getAttribute() 14720 FAIL area.download: setAttribute() to true followed by IDL get assert_equals: expected (string) "true" but got (undefined) undefined 14720 PASS area.download: setAttribute() to true followed by IDL get 14721 14721 PASS area.download: setAttribute() to false followed by getAttribute() 14722 FAIL area.download: setAttribute() to false followed by IDL get assert_equals: expected (string) "false" but got (undefined) undefined 14722 PASS area.download: setAttribute() to false followed by IDL get 14723 14723 PASS area.download: setAttribute() to object "[object Object]" followed by getAttribute() 14724 FAIL area.download: setAttribute() to object "[object Object]" followed by IDL get assert_equals: expected (string) "[object Object]" but got (undefined) undefined 14724 PASS area.download: setAttribute() to object "[object Object]" followed by IDL get 14725 14725 PASS area.download: setAttribute() to NaN followed by getAttribute() 14726 FAIL area.download: setAttribute() to NaN followed by IDL get assert_equals: expected (string) "NaN" but got (undefined) undefined 14726 PASS area.download: setAttribute() to NaN followed by IDL get 14727 14727 PASS area.download: setAttribute() to Infinity followed by getAttribute() 14728 FAIL area.download: setAttribute() to Infinity followed by IDL get assert_equals: expected (string) "Infinity" but got (undefined) undefined 14728 PASS area.download: setAttribute() to Infinity followed by IDL get 14729 14729 PASS area.download: setAttribute() to -Infinity followed by getAttribute() 14730 FAIL area.download: setAttribute() to -Infinity followed by IDL get assert_equals: expected (string) "-Infinity" but got (undefined) undefined 14730 PASS area.download: setAttribute() to -Infinity followed by IDL get 14731 14731 PASS area.download: setAttribute() to "\0" followed by getAttribute() 14732 FAIL area.download: setAttribute() to "\0" followed by IDL get assert_equals: expected (string) "\0" but got (undefined) undefined 14732 PASS area.download: setAttribute() to "\0" followed by IDL get 14733 14733 PASS area.download: setAttribute() to null followed by getAttribute() 14734 FAIL area.download: setAttribute() to null followed by IDL get assert_equals: expected (string) "null" but got (undefined) undefined 14734 PASS area.download: setAttribute() to null followed by IDL get 14735 14735 PASS area.download: setAttribute() to object "test-toString" followed by getAttribute() 14736 FAIL area.download: setAttribute() to object "test-toString" followed by IDL get assert_equals: expected (string) "test-toString" but got (undefined) undefined 14736 PASS area.download: setAttribute() to object "test-toString" followed by IDL get 14737 14737 PASS area.download: setAttribute() to object "test-valueOf" followed by getAttribute() 14738 FAIL area.download: setAttribute() to object "test-valueOf" followed by IDL get assert_equals: expected (string) "test-valueOf" but got (undefined) undefined 14738 PASS area.download: setAttribute() to object "test-valueOf" followed by IDL get 14739 14739 PASS area.download: IDL set to "" should not throw 14740 FAIL area.download: IDL set to "" followed by getAttribute() assert_equals: expected "" but got "test-valueOf" 14740 PASS area.download: IDL set to "" followed by getAttribute() 14741 14741 PASS area.download: IDL set to "" followed by IDL get 14742 14742 PASS area.download: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " should not throw 14743 FAIL area.download: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute() assert_equals: expected " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " but got "test-valueOf" 14743 PASS area.download: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute() 14744 14744 PASS area.download: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get 14745 14745 PASS area.download: IDL set to undefined should not throw 14746 FAIL area.download: IDL set to undefined followed by getAttribute() assert_equals: expected "undefined" but got "test-valueOf" 14747 FAIL area.download: IDL set to undefined followed by IDL get assert_equals: expected (string) "undefined" but got (undefined) undefined 14746 PASS area.download: IDL set to undefined followed by getAttribute() 14747 PASS area.download: IDL set to undefined followed by IDL get 14748 14748 PASS area.download: IDL set to 7 should not throw 14749 FAIL area.download: IDL set to 7 followed by getAttribute() assert_equals: expected "7" but got "test-valueOf" 14750 FAIL area.download: IDL set to 7 followed by IDL get assert_equals: expected (string) "7" but got (number) 7 14749 PASS area.download: IDL set to 7 followed by getAttribute() 14750 PASS area.download: IDL set to 7 followed by IDL get 14751 14751 PASS area.download: IDL set to 1.5 should not throw 14752 FAIL area.download: IDL set to 1.5 followed by getAttribute() assert_equals: expected "1.5" but got "test-valueOf" 14753 FAIL area.download: IDL set to 1.5 followed by IDL get assert_equals: expected (string) "1.5" but got (number) 1.5 14752 PASS area.download: IDL set to 1.5 followed by getAttribute() 14753 PASS area.download: IDL set to 1.5 followed by IDL get 14754 14754 PASS area.download: IDL set to true should not throw 14755 FAIL area.download: IDL set to true followed by getAttribute() assert_equals: expected "true" but got "test-valueOf" 14756 FAIL area.download: IDL set to true followed by IDL get assert_equals: expected (string) "true" but got (boolean) true 14755 PASS area.download: IDL set to true followed by getAttribute() 14756 PASS area.download: IDL set to true followed by IDL get 14757 14757 PASS area.download: IDL set to false should not throw 14758 FAIL area.download: IDL set to false followed by getAttribute() assert_equals: expected "false" but got "test-valueOf" 14759 FAIL area.download: IDL set to false followed by IDL get assert_equals: expected (string) "false" but got (boolean) false 14758 PASS area.download: IDL set to false followed by getAttribute() 14759 PASS area.download: IDL set to false followed by IDL get 14760 14760 PASS area.download: IDL set to object "[object Object]" should not throw 14761 FAIL area.download: IDL set to object "[object Object]" followed by getAttribute() assert_equals: expected "[object Object]" but got "test-valueOf" 14762 FAIL area.download: IDL set to object "[object Object]" followed by IDL get assert_equals: expected (string) "[object Object]" but got (object) object "[object Object]" 14761 PASS area.download: IDL set to object "[object Object]" followed by getAttribute() 14762 PASS area.download: IDL set to object "[object Object]" followed by IDL get 14763 14763 PASS area.download: IDL set to NaN should not throw 14764 FAIL area.download: IDL set to NaN followed by getAttribute() assert_equals: expected "NaN" but got "test-valueOf" 14765 FAIL area.download: IDL set to NaN followed by IDL get assert_equals: expected (string) "NaN" but got (number) NaN 14764 PASS area.download: IDL set to NaN followed by getAttribute() 14765 PASS area.download: IDL set to NaN followed by IDL get 14766 14766 PASS area.download: IDL set to Infinity should not throw 14767 FAIL area.download: IDL set to Infinity followed by getAttribute() assert_equals: expected "Infinity" but got "test-valueOf" 14768 FAIL area.download: IDL set to Infinity followed by IDL get assert_equals: expected (string) "Infinity" but got (number) Infinity 14767 PASS area.download: IDL set to Infinity followed by getAttribute() 14768 PASS area.download: IDL set to Infinity followed by IDL get 14769 14769 PASS area.download: IDL set to -Infinity should not throw 14770 FAIL area.download: IDL set to -Infinity followed by getAttribute() assert_equals: expected "-Infinity" but got "test-valueOf" 14771 FAIL area.download: IDL set to -Infinity followed by IDL get assert_equals: expected (string) "-Infinity" but got (number) -Infinity 14770 PASS area.download: IDL set to -Infinity followed by getAttribute() 14771 PASS area.download: IDL set to -Infinity followed by IDL get 14772 14772 PASS area.download: IDL set to "\0" should not throw 14773 FAIL area.download: IDL set to "\0" followed by getAttribute() assert_equals: expected "\0" but got "test-valueOf" 14773 PASS area.download: IDL set to "\0" followed by getAttribute() 14774 14774 PASS area.download: IDL set to "\0" followed by IDL get 14775 14775 PASS area.download: IDL set to null should not throw 14776 FAIL area.download: IDL set to null followed by getAttribute() assert_equals: expected "null" but got "test-valueOf" 14777 FAIL area.download: IDL set to null followed by IDL get assert_equals: expected (string) "null" but got (object) null 14776 PASS area.download: IDL set to null followed by getAttribute() 14777 PASS area.download: IDL set to null followed by IDL get 14778 14778 PASS area.download: IDL set to object "test-toString" should not throw 14779 FAIL area.download: IDL set to object "test-toString" followed by getAttribute() assert_equals: expected "test-toString" but got "test-valueOf" 14780 FAIL area.download: IDL set to object "test-toString" followed by IDL get assert_equals: expected (string) "test-toString" but got (object) object "test-toString" 14779 PASS area.download: IDL set to object "test-toString" followed by getAttribute() 14780 PASS area.download: IDL set to object "test-toString" followed by IDL get 14781 14781 PASS area.download: IDL set to object "test-valueOf" should not throw 14782 14782 PASS area.download: IDL set to object "test-valueOf" followed by getAttribute() 14783 FAIL area.download: IDL set to object "test-valueOf" followed by IDL get assert_equals: expected (string) "test-valueOf" but got (object) object "test-valueOf" 14783 PASS area.download: IDL set to object "test-valueOf" followed by IDL get 14784 14784 PASS area.ping: typeof IDL attribute 14785 14785 PASS area.ping: IDL get with DOM attribute unset -
trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations
r206356 r206630 1315 1315 # <a download> is not supported in WK1 yet. 1316 1316 webkit.org/b/156069 fast/dom/HTMLAnchorElement/anchor-download-synthetic-click.html [ Skip ] 1317 webkit.org/b/156069 http/tests/download/area-download.html [ Skip ] 1317 1318 webkit.org/b/156069 http/tests/security/anchor-download-allow-blob.html [ Skip ] 1318 1319 webkit.org/b/156069 http/tests/security/anchor-download-allow-data.html [ Skip ] -
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
r206605 r206630 742 742 fast/dom/Geolocation/permission-denied-stops-watches.html 743 743 fast/dom/Geolocation/requestQueuingForHiddenPage.html 744 fast/dom/HTMLAnchorElement/anchor-download-unset.html745 fast/dom/HTMLAnchorElement/anchor-download.html746 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html747 fast/dom/HTMLAnchorElement/anchor-nodownload.html748 744 fast/dom/HTMLLinkElement/prefetch.html 749 745 fast/dom/MutationObserver/end-of-task-delivery.html … … 1807 1803 webkit.org/b/155948 transitions/cancel-transition.html [ Pass Failure ] 1808 1804 1809 # <a download> is not supported with NETWORK_SESSION yet. 1805 # <a download> does not work on iOS. 1806 webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-download-unset.html [ Skip ] 1807 webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-download.html [ Skip ] 1808 webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Skip ] 1809 webkit.org/b/156067 fast/dom/HTMLAnchorElement/anchor-nodownload.html [ Skip ] 1810 webkit.org/b/156067 http/tests/download/area-download.html [ Skip ] 1810 1811 webkit.org/b/156067 http/tests/security/anchor-download-allow-blob.html [ Skip ] 1811 1812 webkit.org/b/156067 http/tests/security/anchor-download-allow-data.html [ Skip ] -
trunk/LayoutTests/platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt
r206260 r206630 14705 14705 PASS area.target: IDL set to object "test-valueOf" followed by getAttribute() 14706 14706 PASS area.target: IDL set to object "test-valueOf" followed by IDL get 14707 FAIL area.download: typeof IDL attribute assert_equals: expected "string" but got "undefined" 14708 FAIL area.download: IDL get with DOM attribute unset assert_equals: expected (string) "" but got (undefined) undefined 14707 PASS area.download: typeof IDL attribute 14708 PASS area.download: IDL get with DOM attribute unset 14709 14709 PASS area.download: setAttribute() to "" followed by getAttribute() 14710 FAIL area.download: setAttribute() to "" followed by IDL get assert_equals: expected (string) "" but got (undefined) undefined 14710 PASS area.download: setAttribute() to "" followed by IDL get 14711 14711 PASS area.download: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute() 14712 FAIL area.download: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get assert_equals: expected (string) " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " but got (undefined) undefined 14712 PASS area.download: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get 14713 14713 PASS area.download: setAttribute() to undefined followed by getAttribute() 14714 FAIL area.download: setAttribute() to undefined followed by IDL get assert_equals: expected (string) "undefined" but got (undefined) undefined 14714 PASS area.download: setAttribute() to undefined followed by IDL get 14715 14715 PASS area.download: setAttribute() to 7 followed by getAttribute() 14716 FAIL area.download: setAttribute() to 7 followed by IDL get assert_equals: expected (string) "7" but got (undefined) undefined 14716 PASS area.download: setAttribute() to 7 followed by IDL get 14717 14717 PASS area.download: setAttribute() to 1.5 followed by getAttribute() 14718 FAIL area.download: setAttribute() to 1.5 followed by IDL get assert_equals: expected (string) "1.5" but got (undefined) undefined 14718 PASS area.download: setAttribute() to 1.5 followed by IDL get 14719 14719 PASS area.download: setAttribute() to true followed by getAttribute() 14720 FAIL area.download: setAttribute() to true followed by IDL get assert_equals: expected (string) "true" but got (undefined) undefined 14720 PASS area.download: setAttribute() to true followed by IDL get 14721 14721 PASS area.download: setAttribute() to false followed by getAttribute() 14722 FAIL area.download: setAttribute() to false followed by IDL get assert_equals: expected (string) "false" but got (undefined) undefined 14722 PASS area.download: setAttribute() to false followed by IDL get 14723 14723 PASS area.download: setAttribute() to object "[object Object]" followed by getAttribute() 14724 FAIL area.download: setAttribute() to object "[object Object]" followed by IDL get assert_equals: expected (string) "[object Object]" but got (undefined) undefined 14724 PASS area.download: setAttribute() to object "[object Object]" followed by IDL get 14725 14725 PASS area.download: setAttribute() to NaN followed by getAttribute() 14726 FAIL area.download: setAttribute() to NaN followed by IDL get assert_equals: expected (string) "NaN" but got (undefined) undefined 14726 PASS area.download: setAttribute() to NaN followed by IDL get 14727 14727 PASS area.download: setAttribute() to Infinity followed by getAttribute() 14728 FAIL area.download: setAttribute() to Infinity followed by IDL get assert_equals: expected (string) "Infinity" but got (undefined) undefined 14728 PASS area.download: setAttribute() to Infinity followed by IDL get 14729 14729 PASS area.download: setAttribute() to -Infinity followed by getAttribute() 14730 FAIL area.download: setAttribute() to -Infinity followed by IDL get assert_equals: expected (string) "-Infinity" but got (undefined) undefined 14730 PASS area.download: setAttribute() to -Infinity followed by IDL get 14731 14731 PASS area.download: setAttribute() to "\0" followed by getAttribute() 14732 FAIL area.download: setAttribute() to "\0" followed by IDL get assert_equals: expected (string) "\0" but got (undefined) undefined 14732 PASS area.download: setAttribute() to "\0" followed by IDL get 14733 14733 PASS area.download: setAttribute() to null followed by getAttribute() 14734 FAIL area.download: setAttribute() to null followed by IDL get assert_equals: expected (string) "null" but got (undefined) undefined 14734 PASS area.download: setAttribute() to null followed by IDL get 14735 14735 PASS area.download: setAttribute() to object "test-toString" followed by getAttribute() 14736 FAIL area.download: setAttribute() to object "test-toString" followed by IDL get assert_equals: expected (string) "test-toString" but got (undefined) undefined 14736 PASS area.download: setAttribute() to object "test-toString" followed by IDL get 14737 14737 PASS area.download: setAttribute() to object "test-valueOf" followed by getAttribute() 14738 FAIL area.download: setAttribute() to object "test-valueOf" followed by IDL get assert_equals: expected (string) "test-valueOf" but got (undefined) undefined 14738 PASS area.download: setAttribute() to object "test-valueOf" followed by IDL get 14739 14739 PASS area.download: IDL set to "" should not throw 14740 FAIL area.download: IDL set to "" followed by getAttribute() assert_equals: expected "" but got "test-valueOf" 14740 PASS area.download: IDL set to "" followed by getAttribute() 14741 14741 PASS area.download: IDL set to "" followed by IDL get 14742 14742 PASS area.download: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " should not throw 14743 FAIL area.download: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute() assert_equals: expected " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " but got "test-valueOf" 14743 PASS area.download: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by getAttribute() 14744 14744 PASS area.download: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f foo " followed by IDL get 14745 14745 PASS area.download: IDL set to undefined should not throw 14746 FAIL area.download: IDL set to undefined followed by getAttribute() assert_equals: expected "undefined" but got "test-valueOf" 14747 FAIL area.download: IDL set to undefined followed by IDL get assert_equals: expected (string) "undefined" but got (undefined) undefined 14746 PASS area.download: IDL set to undefined followed by getAttribute() 14747 PASS area.download: IDL set to undefined followed by IDL get 14748 14748 PASS area.download: IDL set to 7 should not throw 14749 FAIL area.download: IDL set to 7 followed by getAttribute() assert_equals: expected "7" but got "test-valueOf" 14750 FAIL area.download: IDL set to 7 followed by IDL get assert_equals: expected (string) "7" but got (number) 7 14749 PASS area.download: IDL set to 7 followed by getAttribute() 14750 PASS area.download: IDL set to 7 followed by IDL get 14751 14751 PASS area.download: IDL set to 1.5 should not throw 14752 FAIL area.download: IDL set to 1.5 followed by getAttribute() assert_equals: expected "1.5" but got "test-valueOf" 14753 FAIL area.download: IDL set to 1.5 followed by IDL get assert_equals: expected (string) "1.5" but got (number) 1.5 14752 PASS area.download: IDL set to 1.5 followed by getAttribute() 14753 PASS area.download: IDL set to 1.5 followed by IDL get 14754 14754 PASS area.download: IDL set to true should not throw 14755 FAIL area.download: IDL set to true followed by getAttribute() assert_equals: expected "true" but got "test-valueOf" 14756 FAIL area.download: IDL set to true followed by IDL get assert_equals: expected (string) "true" but got (boolean) true 14755 PASS area.download: IDL set to true followed by getAttribute() 14756 PASS area.download: IDL set to true followed by IDL get 14757 14757 PASS area.download: IDL set to false should not throw 14758 FAIL area.download: IDL set to false followed by getAttribute() assert_equals: expected "false" but got "test-valueOf" 14759 FAIL area.download: IDL set to false followed by IDL get assert_equals: expected (string) "false" but got (boolean) false 14758 PASS area.download: IDL set to false followed by getAttribute() 14759 PASS area.download: IDL set to false followed by IDL get 14760 14760 PASS area.download: IDL set to object "[object Object]" should not throw 14761 FAIL area.download: IDL set to object "[object Object]" followed by getAttribute() assert_equals: expected "[object Object]" but got "test-valueOf" 14762 FAIL area.download: IDL set to object "[object Object]" followed by IDL get assert_equals: expected (string) "[object Object]" but got (object) object "[object Object]" 14761 PASS area.download: IDL set to object "[object Object]" followed by getAttribute() 14762 PASS area.download: IDL set to object "[object Object]" followed by IDL get 14763 14763 PASS area.download: IDL set to NaN should not throw 14764 FAIL area.download: IDL set to NaN followed by getAttribute() assert_equals: expected "NaN" but got "test-valueOf" 14765 FAIL area.download: IDL set to NaN followed by IDL get assert_equals: expected (string) "NaN" but got (number) NaN 14764 PASS area.download: IDL set to NaN followed by getAttribute() 14765 PASS area.download: IDL set to NaN followed by IDL get 14766 14766 PASS area.download: IDL set to Infinity should not throw 14767 FAIL area.download: IDL set to Infinity followed by getAttribute() assert_equals: expected "Infinity" but got "test-valueOf" 14768 FAIL area.download: IDL set to Infinity followed by IDL get assert_equals: expected (string) "Infinity" but got (number) Infinity 14767 PASS area.download: IDL set to Infinity followed by getAttribute() 14768 PASS area.download: IDL set to Infinity followed by IDL get 14769 14769 PASS area.download: IDL set to -Infinity should not throw 14770 FAIL area.download: IDL set to -Infinity followed by getAttribute() assert_equals: expected "-Infinity" but got "test-valueOf" 14771 FAIL area.download: IDL set to -Infinity followed by IDL get assert_equals: expected (string) "-Infinity" but got (number) -Infinity 14770 PASS area.download: IDL set to -Infinity followed by getAttribute() 14771 PASS area.download: IDL set to -Infinity followed by IDL get 14772 14772 PASS area.download: IDL set to "\0" should not throw 14773 FAIL area.download: IDL set to "\0" followed by getAttribute() assert_equals: expected "\0" but got "test-valueOf" 14773 PASS area.download: IDL set to "\0" followed by getAttribute() 14774 14774 PASS area.download: IDL set to "\0" followed by IDL get 14775 14775 PASS area.download: IDL set to null should not throw 14776 FAIL area.download: IDL set to null followed by getAttribute() assert_equals: expected "null" but got "test-valueOf" 14777 FAIL area.download: IDL set to null followed by IDL get assert_equals: expected (string) "null" but got (object) null 14776 PASS area.download: IDL set to null followed by getAttribute() 14777 PASS area.download: IDL set to null followed by IDL get 14778 14778 PASS area.download: IDL set to object "test-toString" should not throw 14779 FAIL area.download: IDL set to object "test-toString" followed by getAttribute() assert_equals: expected "test-toString" but got "test-valueOf" 14780 FAIL area.download: IDL set to object "test-toString" followed by IDL get assert_equals: expected (string) "test-toString" but got (object) object "test-toString" 14779 PASS area.download: IDL set to object "test-toString" followed by getAttribute() 14780 PASS area.download: IDL set to object "test-toString" followed by IDL get 14781 14781 PASS area.download: IDL set to object "test-valueOf" should not throw 14782 14782 PASS area.download: IDL set to object "test-valueOf" followed by getAttribute() 14783 FAIL area.download: IDL set to object "test-valueOf" followed by IDL get assert_equals: expected (string) "test-valueOf" but got (object) object "test-valueOf" 14783 PASS area.download: IDL set to object "test-valueOf" followed by IDL get 14784 14784 PASS area.ping: typeof IDL attribute 14785 14785 PASS area.ping: IDL get with DOM attribute unset -
trunk/LayoutTests/platform/mac-wk1/TestExpectations
r206412 r206630 192 192 webkit.org/b/156069 fast/dom/HTMLAnchorElement/anchor-download.html [ Failure ] 193 193 webkit.org/b/156069 fast/dom/HTMLAnchorElement/anchor-download-synthetic-click.html [ Skip ] 194 webkit.org/b/156069 http/tests/download/area-download.html [ Skip ] 194 195 webkit.org/b/156069 http/tests/security/anchor-download-allow-blob.html [ Skip ] 195 196 webkit.org/b/156069 http/tests/security/anchor-download-allow-data.html [ Skip ] -
trunk/LayoutTests/platform/win/TestExpectations
r206576 r206630 443 443 fast/dom/HTMLAnchorElement/anchor-nodownload-set.html [ Skip ] 444 444 fast/dom/HTMLAnchorElement/anchor-download-unset.html [ Skip ] 445 http/tests/download/area-download.html [ Skip ] 446 http/tests/security/anchor-download-allow-data.html [ Skip ] 447 http/tests/security/anchor-download-allow-sameorigin.html [ Skip ] 445 448 446 449 # TODO Expose title direction in WebKit API (Chromium Only) … … 3445 3448 http/tests/misc/favicon-loads-with-icon-loading-override.html [ Failure ] 3446 3449 http/tests/navigation/post-308-response.html [ Failure ] 3447 http/tests/security/anchor-download-allow-data.html [ Failure ]3448 http/tests/security/anchor-download-allow-sameorigin.html [ Failure ]3449 3450 http/tests/security/canvas-remote-read-remote-video-redirect.html [ Failure ] 3450 3451 http/tests/security/contentSecurityPolicy/1.1/plugintypes-affects-child.html [ Failure ] -
trunk/Source/WebCore/ChangeLog
r206629 r206630 1 2016-09-29 Chris Dumez <cdumez@apple.com> 2 3 Add support for download attribute on area elements 4 https://bugs.webkit.org/show_bug.cgi?id=162765 5 6 Reviewed by Brent Fulgham. 7 8 Add support for download attribute on area elements: 9 - https://html.spec.whatwg.org/#htmlanchorelement 10 11 Because HTMLAreaElement inherits from HTMLAnchorElement on native side, 12 and because HTMLAnchorElement already supports the download attribute, 13 all that was needed was to add the download attribute to 14 HTMLAreaElement.idl file. 15 16 Test: http/tests/download/area-download.html 17 18 * html/HTMLAreaElement.idl: 19 1 20 2016-09-29 Ryosuke Niwa <rniwa@webkit.org> 2 21 -
trunk/Source/WebCore/html/HTMLAreaElement.idl
r206561 r206630 28 28 [Reflect] attribute DOMString target; 29 29 30 [Conditional=DOWNLOAD_ATTRIBUTE, EnabledAtRuntime=DownloadAttribute, Reflect] attribute DOMString download; 31 30 32 [PutForwards=value] readonly attribute DOMTokenList relList; 31 33 };
Note: See TracChangeset
for help on using the changeset viewer.