Changeset 206658 in webkit

Timestamp:

Sep 30, 2016 12:47:54 PM (8 years ago)

Author:

mark.lam@apple.com

Message:

Remove the dumping of the stack back trace in VM::verifyExceptionCheckNeedIsSatisfied().
​https://bugs.webkit.org/show_bug.cgi?id=162797

Reviewed by Geoffrey Garen.

This is because the RELEASE_ASSERT() that follows immediately after will also
dump the stack back trace. Hence, the first dump will be redundant.

Also removed an extra space in the dataLog output.

• runtime/VM.cpp:

(JSC::VM::verifyExceptionCheckNeedIsSatisfied):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/VM.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-09-30  Mark Lam  <mark.lam@apple.com>
+
+        Remove the dumping of the stack back trace in VM::verifyExceptionCheckNeedIsSatisfied().
+        https://bugs.webkit.org/show_bug.cgi?id=162797
+
+        Reviewed by Geoffrey Garen.
+
+        This is because the RELEASE_ASSERT() that follows immediately after will also
+        dump the stack back trace.  Hence, the first dump will be redundant.
+
+        Also removed an extra space in the dataLog output.
+
+        * runtime/VM.cpp:
+        (JSC::VM::verifyExceptionCheckNeedIsSatisfied):
+
 2016-09-30  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/runtime/VM.cpp

@@ -907 +907 @@
             "ERROR: Unchecked JS exception:\n"
             "    This scope can throw a JS exception: ", throwLocation, "\n"
-            "        (ExceptionScope::m_recursionDepth was  ", throwDepth, ")\n"
+            "        (ExceptionScope::m_recursionDepth was ", throwDepth, ")\n"
             "    But the exception was unchecked as of this scope: ", location, "\n"
-            "        (ExceptionScope::m_recursionDepth was  ", recursionDepth, ")\n"
+            "        (ExceptionScope::m_recursionDepth was ", recursionDepth, ")\n"
             "\n");
-        WTFReportBacktrace();
 
         RELEASE_ASSERT(!m_needExceptionCheck);