Changeset 206701 in webkit

Timestamp:

Sep 30, 2016 6:26:10 PM (8 years ago)

Author:

mmaxfield@apple.com

Message:

Turn variation fonts on by default
​https://bugs.webkit.org/show_bug.cgi?id=162818

Reviewed by Simon Fraser.

Source/WebCore:

No new tests because there is no behavior change.

• page/Settings.in:
• testing/InternalSettings.cpp:

(WebCore::InternalSettings::variationFontsEnabled):

Source/WebKit2:

• Shared/WebPreferencesDefinitions.h:

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/Settings.in (modified) (1 diff)
• WebCore/testing/InternalSettings.cpp (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/Shared/WebPreferencesDefinitions.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-30  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Turn variation fonts on by default
+        https://bugs.webkit.org/show_bug.cgi?id=162818
+
+        Reviewed by Simon Fraser.
+
+        No new tests because there is no behavior change.
+
+        * page/Settings.in:
+        * testing/InternalSettings.cpp:
+        (WebCore::InternalSettings::variationFontsEnabled):
+
 2016-09-30  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/page/Settings.in

@@ -274 +274 @@
 treatIPAddressAsDomain initial=false
 
-variationFontsEnabled initial=false, setNeedsStyleRecalcInAllFrames=1
+variationFontsEnabled initial=true, setNeedsStyleRecalcInAllFrames=1
 
 # Runtime-enabled features

trunk/Source/WebCore/testing/InternalSettings.cpp

@@ -654 +654 @@
 bool InternalSettings::variationFontsEnabled(ExceptionCode& ec)
 {
-    InternalSettingsGuardForSettingsReturn(false);
+    InternalSettingsGuardForSettingsReturn(true);
     return settings()->variationFontsEnabled();
 }

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-09-30  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Turn variation fonts on by default
+        https://bugs.webkit.org/show_bug.cgi?id=162818
+
+        Reviewed by Simon Fraser.
+
+        * Shared/WebPreferencesDefinitions.h:
+
 2016-09-30  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h

@@ -292 +292 @@
     macro(GamepadsEnabled, gamepadsEnabled, Bool, bool, false, "Gamepads", "Web Gamepad API support") \
     macro(ModernMediaControlsEnabled, modernMediaControlsEnabled, Bool, bool, false, "Modern Media Controls", "Use modern media controls look") \
-    macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, false, "Variation Fonts", "Enable variation fonts") \
+    macro(VariationFontsEnabled, variationFontsEnabled, Bool, bool, true, "Variation Fonts", "Enable variation fonts") \
     macro(VisualViewportEnabled, visualViewportEnabled, Bool, bool, false, "Visual Viewport", "Use Visual Viewport for fixed elements when zooming") \
     macro(WebGL2Enabled, webGL2Enabled, Bool, bool, true, "WebGL 2.0", "WebGL 2 prototype") \