Changeset 206825 in webkit

Timestamp:

Oct 5, 2016 1:20:02 PM (8 years ago)

Author:

Michael Catanzaro

Message:

[GTK] Improve comment in platformVersionForUAString
​https://bugs.webkit.org/show_bug.cgi?id=162612

Reviewed by Carlos Garcia Campos.

• platform/gtk/UserAgentGtk.cpp:

(WebCore::platformVersionForUAString):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/UserAgentGtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-05  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [GTK] Improve comment in platformVersionForUAString
+        https://bugs.webkit.org/show_bug.cgi?id=162612
+
+        Reviewed by Carlos Garcia Campos.
+
+        * platform/gtk/UserAgentGtk.cpp:
+        (WebCore::platformVersionForUAString):
+
 2016-10-05  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp

@@ -95 +95 @@
     return uaOSVersion;
 #else
-    // We will always claim to be Safari in Mac OS X, since Safari in Linux triggers the iOS path on some websites.
-    // And we always claim to be Intel since ARM triggers mobile versions of some websites.
+    // We will always claim to be Safari in Intel Mac OS X, since Safari without
+    // OS X or anything on ARM triggers mobile versions of some websites.
+    //
+    // FIXME: The final result should include OS version, e.g. "Intel Mac OS X 10_8_4".
     static NeverDestroyed<const String> uaOSVersion(ASCIILiteral("Intel Mac OS X"));
     return uaOSVersion;