Changeset 206851 in webkit
- Timestamp:
- Oct 5, 2016 11:45:34 PM (7 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r206850 r206851 1 2016-10-05 Youenn Fablet <youenn@apple.com> 2 3 Reuse CodeGenerator::UpdateFile in Tools CodeGenerator 4 https://bugs.webkit.org/show_bug.cgi?id=162960 5 6 Reviewed by Alex Christensen. 7 8 No change of behavior. 9 10 * bindings/scripts/CodeGenerator.pm: 11 (UpdateFile): Adding FIXME to enable lazy writing when feasible. 12 1 13 2016-10-05 Michael Catanzaro <mcatanzaro@igalia.com> 2 14 -
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
r206776 r206851 220 220 my $contents = shift; 221 221 222 # FIXME: We should only write content if it is different from what is in the file. 223 # But that would mean running more often the binding generator, see https://bugs.webkit.org/show_bug.cgi?id=131756 222 224 open FH, ">", $fileName or die "Couldn't open $fileName: $!\n"; 223 225 print FH $contents; -
trunk/Tools/ChangeLog
r206842 r206851 1 2016-10-05 Youenn Fablet <youenn@apple.com> 2 3 Reuse CodeGenerator::UpdateFile in Tools CodeGenerator 4 https://bugs.webkit.org/show_bug.cgi?id=162960 5 6 Reviewed by Alex Christensen. 7 8 * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: 9 (WriteData): Using CodeGenerator::UpdateFile to do lazy generated file update when it is made feasible. 10 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: 11 (WriteData): Ditto. 12 1 13 2016-10-05 Alex Christensen <achristensen@webkit.org> 2 14 -
trunk/Tools/DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm
r204877 r206851 50 50 51 51 foreach my $file ($self->_generateHeaderFile($interface), $self->_generateImplementationFile($interface)) { 52 open(FILE, ">", File::Spec->catfile($outputDir, $$file{name})) or die "Failed to open $$file{name} for writing: $!"; 53 print FILE @{$$file{contents}}; 54 close(FILE) or die "Failed to close $$file{name} after writing: $!"; 52 $$self{codeGenerator}->UpdateFile(File::Spec->catfile($outputDir, $$file{name}), join("", @{$$file{contents}})); 55 53 } 56 54 } -
trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm
r181693 r206851 51 51 52 52 foreach my $file ($self->_generateHeaderFile($interface), $self->_generateImplementationFile($interface)) { 53 open(FILE, ">", File::Spec->catfile($outputDir, $$file{name})) or die "Failed to open $$file{name} for writing: $!"; 54 print FILE @{$$file{contents}}; 55 close(FILE) or die "Failed to close $$file{name} after writing: $!"; 53 $$self{codeGenerator}->UpdateFile(File::Spec->catfile($outputDir, $$file{name}), join("", @{$$file{contents}})); 56 54 } 57 55 }
Note: See TracChangeset
for help on using the changeset viewer.