Changeset 206888 in webkit

Timestamp:

Oct 6, 2016 4:11:01 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Inspector exception in parseTextForRule() when pasting into CSS rule selector
​https://bugs.webkit.org/show_bug.cgi?id=162792

Patch by Devin Rousso <Devin Rousso> on 2016-10-06
Reviewed by Matt Baker.

• UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste.parseTextForRule):
Changed regular expression for matching CSS rules to allow newlines in pasted text.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CSSStyleDeclarationSection.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-10-06  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Inspector exception in `parseTextForRule()` when pasting into CSS rule selector
+        https://bugs.webkit.org/show_bug.cgi?id=162792
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/CSSStyleDeclarationSection.js:
+        (WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste.parseTextForRule):
+        Changed regular expression for matching CSS rules to allow newlines in pasted text.
+
 2016-10-02  Devin Rousso  <dcrousso+webkit@gmail.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js

@@ -424 +424 @@
             let containsBraces = /[\{\}]/;
             if (!containsBraces.test(text))
-                return null;
-
-            let match = text.match(/([^{]+){(.*)}/);
+                return [];
+
+            let match = text.match(/([^{]+){([\s\S]*)}/);
             if (!match)
-                return null;
+                return [];
 
             // If the match "body" contains braces, parse that body as if it were a rule.