Changeset 206901 in webkit

Timestamp:

Oct 6, 2016 11:01:24 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Add a place for common HTTP Header values
​https://bugs.webkit.org/show_bug.cgi?id=163002

Patch by Youenn Fablet <​youenn@apple.com> on 2016-10-06
Reviewed by Alex Christensen.

No change of behavior.

Introducing HTTPHeaderValues with two Content-Type values.

• CMakeLists.txt:
• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract):

• WebCore.xcodeproj/project.pbxproj:
• platform/network/HTTPHeaderValues.cpp: Added.

(WebCore::HTTPHeaderValues::TextPlainContentType):
(WebCore::HTTPHeaderValues::FormURLEncodedContentType):

• platform/network/HTTPHeaderValues.h: Added.
• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

Location:

trunk/Source/WebCore

Files:

• CMakeLists.txt (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• Modules/fetch/FetchBody.cpp (modified) (2 diffs)
• WebCore.xcodeproj/project.pbxproj (modified) (5 diffs)
• platform/network/HTTPHeaderValues.cpp (added)
• platform/network/HTTPHeaderValues.h (added)
• xml/XMLHttpRequest.cpp (modified) (2 diffs)

trunk/Source/WebCore/CMakeLists.txt

@@ -2344 +2344 @@
     platform/network/FormDataBuilder.cpp
     platform/network/HTTPHeaderMap.cpp
+    platform/network/HTTPHeaderValues.cpp
     platform/network/HTTPParsers.cpp
     platform/network/MIMEHeader.cpp

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-06  Youenn Fablet  <youenn@apple.com>
+
+        Add a place for common HTTP Header values
+        https://bugs.webkit.org/show_bug.cgi?id=163002
+
+        Reviewed by Alex Christensen.
+
+        No change of behavior.
+
+        Introducing HTTPHeaderValues with two Content-Type values.
+
+        * CMakeLists.txt:
+        * Modules/fetch/FetchBody.cpp:
+        (WebCore::FetchBody::extract):
+        * WebCore.xcodeproj/project.pbxproj:
+        * platform/network/HTTPHeaderValues.cpp: Added.
+        (WebCore::HTTPHeaderValues::TextPlainContentType):
+        (WebCore::HTTPHeaderValues::FormURLEncodedContentType):
+        * platform/network/HTTPHeaderValues.h: Added.
+        * xml/XMLHttpRequest.cpp:
+        (WebCore::XMLHttpRequest::send):
+
 2016-10-06  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/Modules/fetch/FetchBody.cpp

@@ -38 +38 @@
 #include "FetchResponseSource.h"
 #include "FormData.h"
+#include "HTTPHeaderValues.h"
 #include "HTTPParsers.h"
 #include "JSBlob.h"
@@ -63 +64 @@
     }
     if (value.isString()) {
-        contentType = ASCIILiteral("text/plain;charset=UTF-8");
+        contentType = HTTPHeaderValues::TextPlainContentType();
         return FetchBody(value.toWTFString(&state));
     }
     if (value.inherits(JSURLSearchParams::info())) {
-        contentType = ASCIILiteral("application/x-www-form-urlencoded;charset=UTF-8");
+        contentType = HTTPHeaderValues::FormURLEncodedContentType();
         return FetchBody(*JSURLSearchParams::toWrapped(value));
     }

trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

@@ -1521 +1521 @@
                 4157AF8012F1FB0400A8C6F5 /* MediaControlsApple.h in Headers */ = {isa = PBXBuildFile; fileRef = 4157AF7E12F1FB0400A8C6F5 /* MediaControlsApple.h */; };
                 4157AF8112F1FB0400A8C6F5 /* MediaControlsApple.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4157AF7F12F1FB0400A8C6F5 /* MediaControlsApple.cpp */; };
+                41614A781DA6423B004AD06F /* HTTPHeaderValues.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 41614A761DA64236004AD06F /* HTTPHeaderValues.cpp */; };
+                41614A791DA64241004AD06F /* HTTPHeaderValues.h in Headers */ = {isa = PBXBuildFile; fileRef = 41614A771DA64236004AD06F /* HTTPHeaderValues.h */; };
                 4162A450101145AE00DFF3ED /* DedicatedWorkerGlobalScope.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4162A44D101145AE00DFF3ED /* DedicatedWorkerGlobalScope.cpp */; };
                 4162A451101145AE00DFF3ED /* DedicatedWorkerGlobalScope.h in Headers */ = {isa = PBXBuildFile; fileRef = 4162A44E101145AE00DFF3ED /* DedicatedWorkerGlobalScope.h */; };
@@ -8468 +8470 @@
                 4157AF7E12F1FB0400A8C6F5 /* MediaControlsApple.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MediaControlsApple.h; sourceTree = "<group>"; };
                 4157AF7F12F1FB0400A8C6F5 /* MediaControlsApple.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MediaControlsApple.cpp; sourceTree = "<group>"; };
+                41614A761DA64236004AD06F /* HTTPHeaderValues.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = HTTPHeaderValues.cpp; sourceTree = "<group>"; };
+                41614A771DA64236004AD06F /* HTTPHeaderValues.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTTPHeaderValues.h; sourceTree = "<group>"; };
                 4162A44D101145AE00DFF3ED /* DedicatedWorkerGlobalScope.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = DedicatedWorkerGlobalScope.cpp; sourceTree = "<group>"; };
                 4162A44E101145AE00DFF3ED /* DedicatedWorkerGlobalScope.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DedicatedWorkerGlobalScope.h; sourceTree = "<group>"; };
@@ -17043 +17047 @@
                                 514C765C0CE923A1007EF3CD /* HTTPHeaderMap.h */,
                                 1AC900BF1943AF3D008625B5 /* HTTPHeaderNames.in */,
+                                41614A761DA64236004AD06F /* HTTPHeaderValues.cpp */,
+                                41614A771DA64236004AD06F /* HTTPHeaderValues.h */,
                                 514C765D0CE923A1007EF3CD /* HTTPParsers.cpp */,
                                 514C765E0CE923A1007EF3CD /* HTTPParsers.h */,
@@ -27133 +27139 @@
                                 3106037014327D2E00ABF4BA /* WebKitCSSFilterValue.h in Headers */,
                                 498391590F1E776900C23782 /* WebKitCSSMatrix.h in Headers */,
+                                41614A791DA64241004AD06F /* HTTPHeaderValues.h in Headers */,
                                 8AA61D00144D595B00F37350 /* WebKitCSSRegionRule.h in Headers */,
                                 BC9ADD230CC4032600098C4C /* WebKitCSSTransformValue.h in Headers */,
@@ -30610 +30617 @@
                                 9380F47809A11ACC001FDB34 /* WidgetMac.mm in Sources */,
                                 939B02EE0EA2DBC400C54570 /* WidthIterator.cpp in Sources */,
+                                41614A781DA6423B004AD06F /* HTTPHeaderValues.cpp in Sources */,
                                 0F15ED5B1B7EC7C500EDDFEB /* WillChangeData.cpp in Sources */,
                                 BC8243E80D0CFD7500460C8F /* WindowFeatures.cpp in Sources */,

trunk/Source/WebCore/xml/XMLHttpRequest.cpp

@@ -35 +35 @@
 #include "HTMLDocument.h"
 #include "HTTPHeaderNames.h"
+#include "HTTPHeaderValues.h"
 #include "HTTPParsers.h"
 #include "InspectorInstrumentation.h"
@@ -567 +568 @@
             else
 #endif
-                m_requestHeaders.set(HTTPHeaderName::ContentType, ASCIILiteral("text/plain;charset=UTF-8"));
+                m_requestHeaders.set(HTTPHeaderName::ContentType, HTTPHeaderValues::TextPlainContentType());
         } else {
             replaceCharsetInMediaType(contentType, "UTF-8");