Changeset 206908 in webkit


Ignore:
Timestamp:
Oct 7, 2016 4:57:30 AM (7 years ago)
Author:
adam.bergkvist@ericsson.com
Message:

WebRTC: Misc gardening: Use typedefs consistently and remove unused code
https://bugs.webkit.org/show_bug.cgi?id=163104

Reviewed by Philippe Normand.

Miscellaneous WebRTC gardening. See file list below for details.

Testing: No change in behavior.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:
  • Modules/mediastream/MediaEndpointPeerConnection.h:

Move NotImplemented include to cpp-file.

  • platform/mediastream/MediaEndpoint.h:

Use MediaPayloadVector typedef (instead of Vector<RefPtr<MediaPayload>>).

  • platform/mediastream/PeerMediaDescription.h:

(WebCore::PeerMediaDescription::source): Deleted.
(WebCore::PeerMediaDescription::setSource): Deleted.
Sources are passed to updateSendConfiguration() via a source map and not added to each
PeerMediaDescription anymore. Remove unused code.

  • platform/mock/MockMediaEndpoint.cpp:

(WebCore::MockMediaEndpoint::getDefaultAudioPayloads):
(WebCore::MockMediaEndpoint::getDefaultVideoPayloads):
Use MediaPayloadVector typedef.

  • platform/mock/MockMediaEndpoint.h:

Use MediaPayloadVector typedef.

Location:
trunk/Source/WebCore
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r206907 r206908  
     12016-10-07  Adam Bergkvist  <adam.bergkvist@ericsson.com>
     2
     3        WebRTC: Misc gardening: Use typedefs consistently and remove unused code
     4        https://bugs.webkit.org/show_bug.cgi?id=163104
     5
     6        Reviewed by Philippe Normand.
     7
     8        Miscellaneous WebRTC gardening. See file list below for details.
     9
     10        Testing: No change in behavior.
     11
     12        * Modules/mediastream/MediaEndpointPeerConnection.cpp:
     13        * Modules/mediastream/MediaEndpointPeerConnection.h:
     14        Move NotImplemented include to cpp-file.
     15        * platform/mediastream/MediaEndpoint.h:
     16        Use MediaPayloadVector typedef (instead of Vector<RefPtr<MediaPayload>>).
     17        * platform/mediastream/PeerMediaDescription.h:
     18        (WebCore::PeerMediaDescription::source): Deleted.
     19        (WebCore::PeerMediaDescription::setSource): Deleted.
     20        Sources are passed to updateSendConfiguration() via a source map and not added to each
     21        PeerMediaDescription anymore. Remove unused code.
     22        * platform/mock/MockMediaEndpoint.cpp:
     23        (WebCore::MockMediaEndpoint::getDefaultAudioPayloads):
     24        (WebCore::MockMediaEndpoint::getDefaultVideoPayloads):
     25        Use MediaPayloadVector typedef.
     26        * platform/mock/MockMediaEndpoint.h:
     27        Use MediaPayloadVector typedef.
     28
    1292016-10-07  Gwang Yoon Hwang  <yoon@igalia.com>
    230
  • trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp

    r206868 r206908  
    4040#include "MediaStreamEvent.h"
    4141#include "MediaStreamTrack.h"
     42#include "NotImplemented.h"
    4243#include "PeerMediaDescription.h"
    4344#include "RTCConfiguration.h"
  • trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h

    r206868 r206908  
    3636#include "MediaEndpoint.h"
    3737#include "MediaEndpointSessionDescription.h"
    38 #include "NotImplemented.h"
    3938#include "PeerConnectionBackend.h"
    4039#include <wtf/Function.h>
  • trunk/Source/WebCore/platform/mediastream/MediaEndpoint.h

    r206868 r206908  
    6767
    6868    virtual void generateDtlsInfo() = 0;
    69     virtual Vector<RefPtr<MediaPayload>> getDefaultAudioPayloads() = 0;
    70     virtual Vector<RefPtr<MediaPayload>> getDefaultVideoPayloads() = 0;
     69    virtual MediaPayloadVector getDefaultAudioPayloads() = 0;
     70    virtual MediaPayloadVector getDefaultVideoPayloads() = 0;
    7171    virtual MediaPayloadVector filterPayloads(const MediaPayloadVector& remotePayloads, const MediaPayloadVector& defaultPayloads) = 0;
    7272
  • trunk/Source/WebCore/platform/mediastream/PeerMediaDescription.h

    r201728 r206908  
    110110    void addIceCandidate(RefPtr<IceCandidate>&& candidate) { m_iceCandidates.append(WTFMove(candidate)); }
    111111
    112     RealtimeMediaSource* source() const { return m_source.get(); }
    113     void setSource(RefPtr<RealtimeMediaSource>&& source) { m_source = source; }
    114 
    115112    RefPtr<PeerMediaDescription> clone() const
    116113    {
     
    179176    String m_icePassword;
    180177    Vector<RefPtr<IceCandidate>> m_iceCandidates;
    181 
    182     RefPtr<RealtimeMediaSource> m_source { nullptr };
    183178};
    184179
  • trunk/Source/WebCore/platform/mock/MockMediaEndpoint.cpp

    r206868 r206908  
    7474}
    7575
    76 Vector<RefPtr<MediaPayload>> MockMediaEndpoint::getDefaultAudioPayloads()
    77 {
    78     Vector<RefPtr<MediaPayload>> payloads;
     76MediaPayloadVector MockMediaEndpoint::getDefaultAudioPayloads()
     77{
     78    MediaPayloadVector payloads;
    7979
    8080    RefPtr<MediaPayload> payload = MediaPayload::create();
     
    102102}
    103103
    104 Vector<RefPtr<MediaPayload>> MockMediaEndpoint::getDefaultVideoPayloads()
    105 {
    106     Vector<RefPtr<MediaPayload>> payloads;
     104MediaPayloadVector MockMediaEndpoint::getDefaultVideoPayloads()
     105{
     106    MediaPayloadVector payloads;
    107107
    108108    RefPtr<MediaPayload> payload = MediaPayload::create();
  • trunk/Source/WebCore/platform/mock/MockMediaEndpoint.h

    r206868 r206908  
    4949
    5050    void generateDtlsInfo() override;
    51     Vector<RefPtr<MediaPayload>> getDefaultAudioPayloads() override;
    52     Vector<RefPtr<MediaPayload>> getDefaultVideoPayloads() override;
     51    MediaPayloadVector getDefaultAudioPayloads() override;
     52    MediaPayloadVector getDefaultVideoPayloads() override;
    5353    MediaPayloadVector filterPayloads(const MediaPayloadVector& remotePayloads, const MediaPayloadVector& defaultPayloads) override;
    5454
Note: See TracChangeset for help on using the changeset viewer.