Changeset 206964 in webkit

Timestamp:

Oct 8, 2016 8:46:39 PM (8 years ago)

Author:

Chris Dumez

Message:

Update CustomEvent to stop using legacy [ConstructorTemplate=Event]
​https://bugs.webkit.org/show_bug.cgi?id=163174

Reviewed by Darin Adler.

Source/WebCore:

Update CustomEvent to stop using legacy [ConstructorTemplate=Event] and
use an actual constructor instead, like in the specification:

• ​https://dom.spec.whatwg.org/#interface-customevent

There is a very minor behavior change when explictly passing undefined
as detail value in CustomEventInit. We used to initialize detail to
undefined but we now initialize it to null instead, which is its default
value. The new behavior matches the one of Chrome and Firefox.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateDefaultValue):
(GenerateDictionaryImplementationContent):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::convertDictionary<TestObj::Dictionary>):

• bindings/scripts/test/TestObj.idl:
• dom/CustomEvent.cpp:

(WebCore::CustomEvent::CustomEvent):

• dom/CustomEvent.h:
• dom/CustomEvent.idl:
• dom/Document.cpp:

(WebCore::Document::createEvent):

• dom/Event.cpp:

(WebCore::Event::Event):

• dom/Event.h:

LayoutTests:

Update existing layout test to reflect minor behavior change.

• fast/events/constructors/custom-event-constructor-expected.txt:
• fast/events/constructors/custom-event-constructor.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt (modified) (1 diff)
• LayoutTests/fast/events/constructors/custom-event-constructor.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (modified) (2 diffs)
• Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (modified) (2 diffs)
• Source/WebCore/bindings/scripts/test/TestObj.idl (modified) (1 diff)
• Source/WebCore/dom/CustomEvent.cpp (modified) (1 diff)
• Source/WebCore/dom/CustomEvent.h (modified) (2 diffs)
• Source/WebCore/dom/CustomEvent.idl (modified) (1 diff)
• Source/WebCore/dom/Document.cpp (modified) (1 diff)
• Source/WebCore/dom/Event.cpp (modified) (1 diff)
• Source/WebCore/dom/Event.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-10-08  Chris Dumez  <cdumez@apple.com>
+
+        Update CustomEvent to stop using legacy [ConstructorTemplate=Event]
+        https://bugs.webkit.org/show_bug.cgi?id=163174
+
+        Reviewed by Darin Adler.
+
+        Update existing layout test to reflect minor behavior change.
+
+        * fast/events/constructors/custom-event-constructor-expected.txt:
+        * fast/events/constructors/custom-event-constructor.html:
+
 2016-10-08  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/fast/events/constructors/custom-event-constructor-expected.txt

@@ -14 +14 @@
 PASS new CustomEvent('eventType', { detail: detailObject }).detail is detailObject
 PASS new CustomEvent('eventType', { detail: document }).detail is document
-PASS new CustomEvent('eventType', { detail: undefined }).detail is undefined
+PASS new CustomEvent('eventType', { detail: undefined }).detail is null
 PASS new CustomEvent('eventType', { detail: null }).detail is null
 PASS new CustomEvent('eventType', { get detail() { return true; } }).detail is true

trunk/LayoutTests/fast/events/constructors/custom-event-constructor.html

@@ -33 +33 @@
 
 // Detail is undefined.
-shouldBe("new CustomEvent('eventType', { detail: undefined }).detail", "undefined");
+shouldBeNull("new CustomEvent('eventType', { detail: undefined }).detail");
 
 // Detail is null.
-shouldBe("new CustomEvent('eventType', { detail: null }).detail", "null");
+shouldBeNull("new CustomEvent('eventType', { detail: null }).detail");
 
 // Detail is a getter.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-08  Chris Dumez  <cdumez@apple.com>
+
+        Update CustomEvent to stop using legacy [ConstructorTemplate=Event]
+        https://bugs.webkit.org/show_bug.cgi?id=163174
+
+        Reviewed by Darin Adler.
+
+        Update CustomEvent to stop using legacy [ConstructorTemplate=Event] and
+        use an actual constructor instead, like in the specification:
+        - https://dom.spec.whatwg.org/#interface-customevent
+
+        There is a very minor behavior change when explictly passing undefined
+        as detail value in CustomEventInit. We used to initialize detail to
+        undefined but we now initialize it to null instead, which is its default
+        value. The new behavior matches the one of Chrome and Firefox.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateDefaultValue):
+        (GenerateDictionaryImplementationContent):
+        * bindings/scripts/test/JS/JSTestObj.cpp:
+        (WebCore::convertDictionary<TestObj::Dictionary>):
+        * bindings/scripts/test/TestObj.idl:
+        * dom/CustomEvent.cpp:
+        (WebCore::CustomEvent::CustomEvent):
+        * dom/CustomEvent.h:
+        * dom/CustomEvent.idl:
+        * dom/Document.cpp:
+        (WebCore::Document::createEvent):
+        * dom/Event.cpp:
+        (WebCore::Event::Event):
+        * dom/Event.h:
+
 2016-10-08  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -983 +983 @@
         $value = $className . "::" . $enumerationValueName;
     }
-    $value = "nullptr" if $value eq "null";
+    if ($value eq "null") {
+        $value = $member->type eq "any" ? "jsNull()" : "nullptr";
+    }
     $value = "jsUndefined()" if $value eq "undefined";
 
@@ -1090 +1092 @@
         my @sortedMembers = sort { $a->name cmp $b->name } @{$dictionary->members};
         foreach my $member (@sortedMembers) {
-            $member->default("undefined") if $member->type eq "any"; # Use undefined as default value for member of type 'any'.
+            $member->default("undefined") if $member->type eq "any" and !defined($member->default); # Use undefined as default value for member of type 'any' unless specified otherwise.
 
             my $type = $member->type;

trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp

@@ -489 +489 @@
     } else
         anyValue = jsUndefined();
+    JSValue anyValueWithNullDefaultValue = isNullOrUndefined ? jsUndefined() : object->get(&state, Identifier::fromString(&state, "anyValueWithNullDefault"));
+    JSC::JSValue anyValueWithNullDefault;
+    if (!anyValueWithNullDefaultValue.isUndefined()) {
+        anyValueWithNullDefault = convert<JSC::JSValue>(state, anyValueWithNullDefaultValue);
+        RETURN_IF_EXCEPTION(throwScope, Nullopt);
+    } else
+        anyValueWithNullDefault = jsNull();
     JSValue booleanWithDefaultValue = isNullOrUndefined ? jsUndefined() : object->get(&state, Identifier::fromString(&state, "booleanWithDefault"));
     bool booleanWithDefault;
@@ -683 +690 @@
     } else
         unsignedLargeIntegerWithDefault = 0;
-    return TestObj::Dictionary { WTFMove(enumerationValueWithoutDefault), WTFMove(enumerationValueWithDefault), WTFMove(enumerationValueWithEmptyStringDefault), WTFMove(stringWithDefault), WTFMove(stringWithoutDefault), WTFMove(booleanWithDefault), WTFMove(booleanWithoutDefault), WTFMove(sequenceOfStrings), WTFMove(restrictedDouble), WTFMove(unrestrictedDouble), WTFMove(restrictedDoubleWithDefault), WTFMove(unrestrictedDoubleWithDefault), WTFMove(restrictedFloat), WTFMove(unrestrictedFloat), WTFMove(restrictedFloatWithDefault), WTFMove(unrestrictedFloatWithDefault), WTFMove(smallIntegerClamped), WTFMove(smallIntegerWithDefault), WTFMove(smallUnsignedIntegerEnforcedRange), WTFMove(smallUnsignedIntegerWithDefault), WTFMove(integer), WTFMove(integerWithDefault), WTFMove(unsignedInteger), WTFMove(unsignedIntegerWithDefault), WTFMove(largeInteger), WTFMove(largeIntegerWithDefault), WTFMove(unsignedLargeInteger), WTFMove(unsignedLargeIntegerWithDefault), WTFMove(nullableNode), WTFMove(anyValue), WTFMove(anyTypedefValue), dictionaryMember.value() };
+    return TestObj::Dictionary { WTFMove(enumerationValueWithoutDefault), WTFMove(enumerationValueWithDefault), WTFMove(enumerationValueWithEmptyStringDefault), WTFMove(stringWithDefault), WTFMove(stringWithoutDefault), WTFMove(booleanWithDefault), WTFMove(booleanWithoutDefault), WTFMove(sequenceOfStrings), WTFMove(restrictedDouble), WTFMove(unrestrictedDouble), WTFMove(restrictedDoubleWithDefault), WTFMove(unrestrictedDoubleWithDefault), WTFMove(restrictedFloat), WTFMove(unrestrictedFloat), WTFMove(restrictedFloatWithDefault), WTFMove(unrestrictedFloatWithDefault), WTFMove(smallIntegerClamped), WTFMove(smallIntegerWithDefault), WTFMove(smallUnsignedIntegerEnforcedRange), WTFMove(smallUnsignedIntegerWithDefault), WTFMove(integer), WTFMove(integerWithDefault), WTFMove(unsignedInteger), WTFMove(unsignedIntegerWithDefault), WTFMove(largeInteger), WTFMove(largeIntegerWithDefault), WTFMove(unsignedLargeInteger), WTFMove(unsignedLargeIntegerWithDefault), WTFMove(nullableNode), WTFMove(anyValue), WTFMove(anyValueWithNullDefault), WTFMove(anyTypedefValue), dictionaryMember.value() };
 }
 

trunk/Source/WebCore/bindings/scripts/test/TestObj.idl

@@ -460 +460 @@
     Node? nullableNode = null;
     any anyValue;
+    any anyValueWithNullDefault = null;
     AnyTypedef anyTypedefValue;
     TestDictionaryThatShouldTolerateNull dictionaryMember;

trunk/Source/WebCore/dom/CustomEvent.cpp

@@ -32 +32 @@
 namespace WebCore {
 
-CustomEvent::CustomEvent()
+CustomEvent::CustomEvent(IsTrusted isTrusted)
+    : Event(isTrusted)
 {
 }
 
-CustomEvent::CustomEvent(const AtomicString& type, const CustomEventInit& initializer)
-    : Event(type, initializer)
-    , m_detail(initializer.detail)
+CustomEvent::CustomEvent(JSC::ExecState& state, const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+    : Event(type, initializer, isTrusted)
+    , m_detail(state.vm(), initializer.detail)
 {
 }

trunk/Source/WebCore/dom/CustomEvent.h

@@ -33 +33 @@
 namespace WebCore {
 
-struct CustomEventInit : public EventInit {
-    Deprecated::ScriptValue detail;
-};
-
 class CustomEvent final : public Event {
 public:
     virtual ~CustomEvent();
 
-    static Ref<CustomEvent> createForBindings()
+    static Ref<CustomEvent> create(IsTrusted isTrusted = IsTrusted::No)
     {
-        return adoptRef(*new CustomEvent);
+        return adoptRef(*new CustomEvent(isTrusted));
     }
 
-    static Ref<CustomEvent> createForBindings(const AtomicString& type, const CustomEventInit& initializer)
+    struct Init : public EventInit {
+        Init(bool bubbles, bool cancelable, bool composed, JSC::JSValue detail)
+            : EventInit(bubbles, cancelable, composed)
+            , detail(detail)
+        { }
+
+        JSC::JSValue detail;
+    };
+
+    static Ref<CustomEvent> create(JSC::ExecState& state, const AtomicString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No)
     {
-        return adoptRef(*new CustomEvent(type, initializer));
+        return adoptRef(*new CustomEvent(state, type, initializer, isTrusted));
     }
 
@@ -60 +65 @@
 
 private:
-    CustomEvent();
-    CustomEvent(const AtomicString& type, const CustomEventInit& initializer);
+    CustomEvent(IsTrusted);
+    CustomEvent(JSC::ExecState&, const AtomicString& type, const Init& initializer, IsTrusted);
 
     Deprecated::ScriptValue m_detail; // FIXME: Why is it OK to use a strong reference here? What prevents a reference cycle?

trunk/Source/WebCore/dom/CustomEvent.idl

@@ -25 +25 @@
 
 // Introduced in DOM Level 3:
+// FIXME: This should be exposed to workers as well.
 [
-    ConstructorTemplate=Event,
+    Constructor(DOMString type, optional CustomEventInit eventInitDict),
+    ConstructorCallWith=ScriptState,
 ] interface CustomEvent : Event {
-    [InitializedByEventConstructor, CustomGetter] readonly attribute any detail;
+    [CustomGetter] readonly attribute any detail;
 
     [CallWith=ScriptState] void initCustomEvent(DOMString type, boolean bubbles, boolean cancelable, any detail);
 };
+
+dictionary CustomEventInit : EventInit {
+    any detail = null;
+};

trunk/Source/WebCore/dom/Document.cpp

@@ -4130 +4130 @@
 
     if (equalLettersIgnoringASCIICase(type, "customevent"))
-        return CustomEvent::createForBindings();
+        return CustomEvent::create();
     if (equalLettersIgnoringASCIICase(type, "event") || equalLettersIgnoringASCIICase(type, "events") || equalLettersIgnoringASCIICase(type, "htmlevents"))
         return Event::createForBindings();

trunk/Source/WebCore/dom/Event.cpp

@@ -32 +32 @@
 namespace WebCore {
 
-Event::Event()
-    : m_createTime(convertSecondsToDOMTimeStamp(currentTime()))
+Event::Event(IsTrusted isTrusted)
+    : m_isTrusted(isTrusted == IsTrusted::Yes)
+    , m_createTime(convertSecondsToDOMTimeStamp(currentTime()))
 {
 }

trunk/Source/WebCore/dom/Event.h

@@ -191 +191 @@
 
 protected:
-    Event();
+    Event(IsTrusted = IsTrusted::No);
     WEBCORE_EXPORT Event(const AtomicString& type, bool canBubble, bool cancelable);
     Event(const AtomicString& type, bool canBubble, bool cancelable, double timestamp);