Changeset 207135 in webkit

Timestamp:

Oct 11, 2016 7:06:29 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[mac] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=163248

Patch by Antoine Quint <Antoine Quint> on 2016-10-11
Reviewed by Antoine Quint.

Wait until all icon images are loaded before running the assertions. We can determine whether
a button's icon image is loaded by checking it's been sized.

• TestExpectations:
• media/modern-media-controls/airplay-button/airplay-button.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• TestExpectations (modified) (1 diff)
• media/modern-media-controls/airplay-button/airplay-button.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-10-11  Antoine Quint  <graouts@apple.com>
+
+        [mac] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=163248
+
+        Reviewed by Antoine Quint.
+
+        Wait until all icon images are loaded before running the assertions. We can determine whether
+        a button's icon image is loaded by checking it's been sized.
+
+        * TestExpectations:
+        * media/modern-media-controls/airplay-button/airplay-button.html:
+
 2016-10-11  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -987 +987 @@
 fast/text/letterpress-different.html [ ImageOnlyFailure ]
 
-webkit.org/b/163248 media/modern-media-controls/airplay-button/airplay-button.html [ Failure ]
 webkit.org/b/163249 media/modern-media-controls/play-pause-button/play-pause-button.html [ Failure ]

trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html

@@ -32 +32 @@
 scheduler.frameDidFire = function()
 {
+    if ([airplayButton, macOSFullscreenAirplayButton, iOSAirplayButton].some(button => button.width == 0))
+        return;
+
     shouldBeTrue('airplayButton.element.style.webkitMaskImage.includes("macOS/airplay@")');
     shouldBeTrue('macOSFullscreenAirplayButton.element.style.webkitMaskImage.includes("macOS/airplay-fullscreen@")');