Changeset 207160 in webkit


Ignore:
Timestamp:
Oct 11, 2016 1:18:27 PM (8 years ago)
Author:
dbates@webkit.org
Message:

REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
​https://bugs.webkit.org/show_bug.cgi?id=163259
<rdar://problem/28680515>

Reviewed by Jer Noble.

In WebKit1 on iOS we want to require user action to load and play videos by default and
allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
can load and play without being initiated by a user action.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Initialize the default value of the deprecated preference
WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
preference takes precedence over the values of its replacement preferences
WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.

Location:
trunk/Source/WebKit/mac
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/mac/ChangeLog

    r207159 r207160  
     12016-10-11  Daniel Bates  <dabates@apple.com>
     2
     3        REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
     4        https://bugs.webkit.org/show_bug.cgi?id=163259
     5        <rdar://problem/28680515>
     6
     7        Reviewed by Jer Noble.
     8
     9        In WebKit1 on iOS we want to require user action to load and play videos by default and
     10        allow an embedding app to change this behavior via -[UIWebView setMediaPlaybackRequiresUserAction:].
     11        Following r198251, -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO and videos
     12        can load and play without being initiated by a user action.
     13
     14        * WebView/WebPreferences.mm:
     15        (+[WebPreferences initialize]): Initialize the default value of the deprecated preference
     16        WebKitRequiresUserGestureForMediaPlaybackPreferenceKey to YES on iOS. The value of this
     17        preference takes precedence over the values of its replacement preferences
     18        WebKitRequiresUserGestureForVideoPlaybackPreferenceKey and WebKitRequiresUserGestureForAudioPlaybackPreferenceKey.
     19
    1202016-10-11  Daniel Bates  <dabates@apple.com>
    221

  • trunk/Source/WebKit/mac/WebView/WebPreferences.mm

    r207151 r207160  
    546546        [NSNumber numberWithBool:YES],  WebKitAVKitEnabled,
    547547#endif
     548        [NSNumber numberWithBool:YES],  WebKitRequiresUserGestureForMediaPlaybackPreferenceKey,
    548549        [NSNumber numberWithBool:NO],   WebKitRequiresUserGestureForVideoPlaybackPreferenceKey,
    549550        [NSNumber numberWithBool:NO],   WebKitRequiresUserGestureForAudioPlaybackPreferenceKey,
Note: See TracChangeset for help on using the changeset viewer.