Changeset 207174 in webkit

Timestamp:

Oct 11, 2016 4:07:35 PM (8 years ago)

Author:

Chris Dumez

Message:

Update UIRequestEvent to stop using legacy [ConstructorTemplate=Event]
​https://bugs.webkit.org/show_bug.cgi?id=163288

Reviewed by Darin Adler.

Update UIRequestEvent to stop using legacy [ConstructorTemplate=Event]
and use a constructor as in the specification:

• ​https://dvcs.w3.org/hg/IndieUI/raw-file/default/src/indie-ui-events.html#UIRequestEvent

• Modules/indieui/UIRequestEvent.cpp:

(WebCore::UIRequestEvent::create):
(WebCore::UIRequestEvent::UIRequestEvent):
(WebCore::UIRequestEvent::createForBindings): Deleted.

• Modules/indieui/UIRequestEvent.h:
• Modules/indieui/UIRequestEvent.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indieui/UIRequestEvent.cpp (modified) (2 diffs)
• Modules/indieui/UIRequestEvent.h (modified) (2 diffs)
• Modules/indieui/UIRequestEvent.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-11  Chris Dumez  <cdumez@apple.com>
+
+        Update UIRequestEvent to stop using legacy [ConstructorTemplate=Event]
+        https://bugs.webkit.org/show_bug.cgi?id=163288
+
+        Reviewed by Darin Adler.
+
+        Update UIRequestEvent to stop using legacy [ConstructorTemplate=Event]
+        and use a constructor as in the specification:
+        - https://dvcs.w3.org/hg/IndieUI/raw-file/default/src/indie-ui-events.html#UIRequestEvent
+
+        * Modules/indieui/UIRequestEvent.cpp:
+        (WebCore::UIRequestEvent::create):
+        (WebCore::UIRequestEvent::UIRequestEvent):
+        (WebCore::UIRequestEvent::createForBindings): Deleted.
+        * Modules/indieui/UIRequestEvent.h:
+        * Modules/indieui/UIRequestEvent.idl:
+
 2016-10-11  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/Modules/indieui/UIRequestEvent.cpp

@@ -31 +31 @@
 namespace WebCore {
 
-Ref<UIRequestEvent> UIRequestEvent::createForBindings(const AtomicString& type, const UIRequestEventInit& initializer)
+Ref<UIRequestEvent> UIRequestEvent::create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
 {
-    return adoptRef(*new UIRequestEvent(type, initializer));
+    return adoptRef(*new UIRequestEvent(type, initializer, isTrusted));
 }
 
@@ -41 +41 @@
 }
 
-UIRequestEvent::UIRequestEvent(const AtomicString& type, const UIRequestEventInit& initializer)
-    : UIEvent(type, initializer)
+UIRequestEvent::UIRequestEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+    : UIEvent(type, initializer, isTrusted)
     , m_receiver(initializer.receiver)
 {

trunk/Source/WebCore/Modules/indieui/UIRequestEvent.h

@@ -33 +33 @@
 
 namespace WebCore {
-    
-struct UIRequestEventInit : public UIEventInit {
-    RefPtr<EventTarget> receiver;
-};
 
 class UIRequestEvent : public UIEvent {
 public:
     static Ref<UIRequestEvent> create(const AtomicString& type, bool bubbles, bool cancelable, DOMWindow*, int detail, RefPtr<EventTarget>&& receiver);
-    static Ref<UIRequestEvent> createForBindings(const AtomicString& eventType, const UIRequestEventInit&);
+
+    struct Init : UIEventInit {
+        RefPtr<EventTarget> receiver;
+    };
+    static Ref<UIRequestEvent> create(const AtomicString& eventType, const Init&, IsTrusted = IsTrusted::No);
     
     virtual ~UIRequestEvent();
@@ -50 +50 @@
     UIRequestEvent(const AtomicString& type, bool bubbles, bool cancelable, DOMWindow*, int detail, RefPtr<EventTarget>&& receiver);
     
-    UIRequestEvent(const AtomicString& type, const UIRequestEventInit&);
+    UIRequestEvent(const AtomicString& type, const Init&, IsTrusted);
     
     EventInterface eventInterface() const override;

trunk/Source/WebCore/Modules/indieui/UIRequestEvent.idl

@@ -26 +26 @@
 [
     Conditional=INDIE_UI,
-    ConstructorTemplate=Event
+    Constructor(DOMString typeArg, optional UIRequestEventInit dictUIRequestEventInit),
 ] interface UIRequestEvent : UIEvent { 
     readonly attribute EventTarget receiver;
 };
 
+dictionary UIRequestEventInit : UIEventInit {
+    EventTarget? receiver = null;
+};