Changeset 207188 in webkit
- Timestamp:
- Oct 11, 2016 9:48:13 PM (7 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r207187 r207188 1 2016-10-11 Chris Dumez <cdumez@apple.com> 2 3 Update AnimationEvent to stop using legacy [ConstructorTemplate=Event] 4 https://bugs.webkit.org/show_bug.cgi?id=163312 5 6 Reviewed by Ryosuke Niwa. 7 8 Update AnimationEvent to stop using legacy [ConstructorTemplate=Event] 9 and use a regular constructor as in the specification: 10 - https://drafts.csswg.org/css-animations/#interface-animationevent 11 12 * dom/AnimationEvent.cpp: 13 (WebCore::AnimationEvent::AnimationEvent): 14 * dom/AnimationEvent.h: 15 * dom/AnimationEvent.idl: 16 1 17 2016-10-11 Chris Dumez <cdumez@apple.com> 2 18 -
trunk/Source/WebCore/dom/AnimationEvent.cpp
r198837 r207188 31 31 namespace WebCore { 32 32 33 AnimationEvent::AnimationEvent(const AtomicString& type, const AnimationEventInit& initializer)34 : Event(type, initializer )33 AnimationEvent::AnimationEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted) 34 : Event(type, initializer, isTrusted) 35 35 , m_animationName(initializer.animationName) 36 36 , m_elapsedTime(initializer.elapsedTime) -
trunk/Source/WebCore/dom/AnimationEvent.h
r197563 r207188 31 31 namespace WebCore { 32 32 33 struct AnimationEventInit : public EventInit {34 String animationName;35 double elapsedTime { 0 };36 };37 38 33 class AnimationEvent final : public Event { 39 34 public: … … 43 38 } 44 39 45 static Ref<AnimationEvent> createForBindings(const AtomicString& type, const AnimationEventInit& initializer) 40 struct Init : EventInit { 41 String animationName; 42 double elapsedTime { 0 }; 43 }; 44 45 static Ref<AnimationEvent> create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No) 46 46 { 47 return adoptRef(*new AnimationEvent(type, initializer ));47 return adoptRef(*new AnimationEvent(type, initializer, isTrusted)); 48 48 } 49 49 … … 57 57 private: 58 58 AnimationEvent(const AtomicString& type, const String& animationName, double elapsedTime); 59 AnimationEvent(const AtomicString&, const AnimationEventInit&);59 AnimationEvent(const AtomicString&, const Init&, IsTrusted); 60 60 61 61 String m_animationName; -
trunk/Source/WebCore/dom/AnimationEvent.idl
r176423 r207188 25 25 26 26 [ 27 Constructor Template=Event27 Constructor(DOMString type, optional AnimationEventInit animationEventInitDict), 28 28 ] interface AnimationEvent : Event { 29 [InitializedByEventConstructor] readonly attribute DOMString animationName; 30 [InitializedByEventConstructor] readonly attribute unrestricted double elapsedTime; 29 readonly attribute DOMString animationName; 30 readonly attribute double elapsedTime; 31 32 // FIXME: This is not supported yet. 33 // readonly attribute DOMString pseudoElement; 31 34 }; 32 35 36 dictionary AnimationEventInit : EventInit { 37 DOMString animationName = ""; 38 double elapsedTime = 0.0; 39 40 // FIXME: This is not supported yet. 41 // DOMString pseudoElement = ""; 42 }; 43
Note: See TracChangeset
for help on using the changeset viewer.