Changeset 207243 in webkit
- Timestamp:
- Oct 12, 2016 2:09:46 PM (8 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r207239 r207243 1 2016-10-12 Chris Dumez <cdumez@apple.com> 2 3 [Web IDL] Generated bindings include the wrong header when ImplementedAs is used on a dictionary 4 https://bugs.webkit.org/show_bug.cgi?id=163352 5 6 Reviewed by Ryosuke Niwa. 7 8 Generated bindings include the wrong header when ImplementedAs is used 9 on a dictionary. 10 11 * bindings/scripts/CodeGeneratorJS.pm: 12 (GenerateDictionaryHeader): 13 * bindings/scripts/test/JS/JSTestObj.cpp: 14 (WebCore::jsTestObjPrototypeFunctionOperationWithExternalDictionaryParameterCaller): 15 * bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp: 16 (WebCore::convertDictionary<DictionaryImplName>): 17 (WebCore::convertDictionary<TestStandaloneDictionary>): Deleted. 18 * bindings/scripts/test/JS/JSTestStandaloneDictionary.h: 19 * bindings/scripts/test/TestStandaloneDictionary.idl: 20 1 21 2016-10-12 Yusuke Suzuki <utatane.tea@gmail.com> 2 22 -
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
r207239 r207243 4366 4366 push(@headerContentHeader, GenerateHeaderContentHeader($dictionary)); 4367 4367 4368 $headerIncludes{"$ dictionaryName.h"} = 1;4368 $headerIncludes{"$className.h"} = 1; 4369 4369 $headerIncludes{"JSDOMConvert.h"} = 1; 4370 4370 -
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
r207193 r207243 7714 7714 if (UNLIKELY(state->argumentCount() < 1)) 7715 7715 return throwVMError(state, throwScope, createNotEnoughArgumentsError(state)); 7716 auto dict = convert<IDLDictionary< TestStandaloneDictionary>>(*state, state->uncheckedArgument(0));7716 auto dict = convert<IDLDictionary<DictionaryImplName>>(*state, state->uncheckedArgument(0)); 7717 7717 RETURN_IF_EXCEPTION(throwScope, encodedJSValue()); 7718 7718 impl.operationWithExternalDictionaryParameter(dict.value()); -
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp
r207150 r207243 27 27 namespace WebCore { 28 28 29 template<> Optional< TestStandaloneDictionary> convertDictionary<TestStandaloneDictionary>(ExecState& state, JSValue value)29 template<> Optional<DictionaryImplName> convertDictionary<DictionaryImplName>(ExecState& state, JSValue value) 30 30 { 31 31 VM& vm = state.vm(); … … 41 41 return Nullopt; 42 42 } 43 TestStandaloneDictionaryresult;43 DictionaryImplName result; 44 44 JSValue boolMemberValue = isNullOrUndefined ? jsUndefined() : object->get(&state, Identifier::fromString(&state, "boolMember")); 45 45 if (!boolMemberValue.isUndefined()) { -
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestStandaloneDictionary.h
r206877 r207243 21 21 #pragma once 22 22 23 #include "DictionaryImplName.h" 23 24 #include "JSDOMConvert.h" 24 #include "TestStandaloneDictionary.h"25 25 26 26 namespace WebCore { 27 27 28 template<> Optional< TestStandaloneDictionary> convertDictionary<TestStandaloneDictionary>(JSC::ExecState&, JSC::JSValue);28 template<> Optional<DictionaryImplName> convertDictionary<DictionaryImplName>(JSC::ExecState&, JSC::JSValue); 29 29 30 30 } // namespace WebCore -
trunk/Source/WebCore/bindings/scripts/test/TestStandaloneDictionary.idl
r206877 r207243 27 27 */ 28 28 29 dictionary TestStandaloneDictionary { 29 [ 30 ImplementedAs=DictionaryImplName, 31 ] dictionary TestStandaloneDictionary { 30 32 boolean boolMember; 31 33 DOMString stringMember;
Note: See TracChangeset
for help on using the changeset viewer.