Changeset 207333 in webkit


Ignore:
Timestamp:
Oct 14, 2016 2:49:47 AM (8 years ago)
Author:
commit-queue@webkit.org
Message:

REGRESSION (r207299): media/modern-media-controls/pip-button/pip-button.html and media/modern-media-controls/skip-back-button/skip-back-button.html are flaky
​https://bugs.webkit.org/show_bug.cgi?id=163411

Patch by Antoine Quint <Antoine Quint> on 2016-10-14
Reviewed by Antoine Quint.

Ensure all buttons have their required images loaded before we check on the mask-image set through CSS.

  • media/modern-media-controls/aspect-ratio-button/aspect-ratio-button.html:
  • media/modern-media-controls/forward-button/forward-button.html:
  • media/modern-media-controls/fullscreen-button/fullscreen-button.html:
  • media/modern-media-controls/mute-button/mute-button.html:
  • media/modern-media-controls/pip-button/pip-button.html:
  • media/modern-media-controls/rewind-button/rewind-button.html:
  • media/modern-media-controls/skip-back-button/skip-back-button.html:
  • media/modern-media-controls/tracks-button/tracks-button.html:
Location:
trunk/LayoutTests
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r207330 r207333  
     12016-10-14  Antoine Quint  <graouts@apple.com>
     2
     3        REGRESSION (r207299): media/modern-media-controls/pip-button/pip-button.html and media/modern-media-controls/skip-back-button/skip-back-button.html are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=163411
     5
     6        Reviewed by Antoine Quint.
     7
     8        Ensure all buttons have their required images loaded before we check on the mask-image set through CSS.
     9
     10        * media/modern-media-controls/aspect-ratio-button/aspect-ratio-button.html:
     11        * media/modern-media-controls/forward-button/forward-button.html:
     12        * media/modern-media-controls/fullscreen-button/fullscreen-button.html:
     13        * media/modern-media-controls/mute-button/mute-button.html:
     14        * media/modern-media-controls/pip-button/pip-button.html:
     15        * media/modern-media-controls/rewind-button/rewind-button.html:
     16        * media/modern-media-controls/skip-back-button/skip-back-button.html:
     17        * media/modern-media-controls/tracks-button/tracks-button.html:
     18
    1192016-10-14  Youenn Fablet  <youenn@apple.com>
    220

  • trunk/LayoutTests/media/modern-media-controls/aspect-ratio-button/aspect-ratio-button.html

    r207015 r207333  
    3131scheduler.frameDidFire = function()
    3232{
     33    if ([scaleToFillButton, scaleToFitButton].some(button => button.width == 0))
     34        return;
     35
    3336    shouldBeTrue('scaleToFillButton.element.style.webkitMaskImage.includes("macOS/scale-to-fill@")');
    3437    shouldBeTrue('scaleToFitButton.element.style.webkitMaskImage.includes("macOS/scale-to-fit@")');

  • trunk/LayoutTests/media/modern-media-controls/forward-button/forward-button.html

    r207015 r207333  
    2727scheduler.frameDidFire = function()
    2828{
     29    if (forwardButton.width == 0)
     30        return;
     31
    2932    shouldBeTrue('forwardButton.element.style.webkitMaskImage.includes("macOS/forward@")');
    3033    finishJSTest();

  • trunk/LayoutTests/media/modern-media-controls/fullscreen-button/fullscreen-button.html

    r207015 r207333  
    3232scheduler.frameDidFire = function()
    3333{
     34    if ([enterFullscreenButton, iOSEnterFullscreenButton, exitFullscreenButton].some(button => button.width == 0))
     35        return;
     36
    3437    shouldBeTrue('enterFullscreenButton.element.style.webkitMaskImage.includes("macOS/enter-fullscreen@")');
    3538    shouldBeTrue('iOSEnterFullscreenButton.element.style.webkitMaskImage.includes("iOS/enter-fullscreen@")');

  • trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button.html

    r207015 r207333  
    3333scheduler.frameDidFire = function()
    3434{
     35    if ([muteButton, mutedButton].some(button => button.width == 0))
     36        return;
     37
    3538    shouldBeTrue('muteButton.element.style.webkitMaskImage.includes("macOS/volume@")');
    3639    shouldBeTrue('mutedButton.element.style.webkitMaskImage.includes("macOS/volume-mute@")');

  • trunk/LayoutTests/media/modern-media-controls/pip-button/pip-button.html

    r207015 r207333  
    2929scheduler.frameDidFire = function()
    3030{
     31    if ([pipButton, iOSPiPButton].some(button => button.width == 0))
     32        return;
     33
    3134    shouldBeTrue('pipButton.element.style.webkitMaskImage.includes("macOS/pip-in@")');
    3235    shouldBeTrue('iOSPiPButton.element.style.webkitMaskImage.includes("iOS/pip-in@")');

  • trunk/LayoutTests/media/modern-media-controls/rewind-button/rewind-button.html

    r207015 r207333  
    2727scheduler.frameDidFire = function()
    2828{
     29    if (rewindButton.width == 0)
     30        return;
     31
    2932    shouldBeTrue('rewindButton.element.style.webkitMaskImage.includes("macOS/rewind@")');
    3033    finishJSTest();

  • trunk/LayoutTests/media/modern-media-controls/skip-back-button/skip-back-button.html

    r207015 r207333  
    2929scheduler.frameDidFire = function()
    3030{
     31    if ([skipBackButton, iOSSkipBackButton].some(button => button.width == 0))
     32        return;
     33
    3134    shouldBeTrue('skipBackButton.element.style.webkitMaskImage.includes("macOS/interval-skip-back@")');
    3235    shouldBeTrue('iOSSkipBackButton.element.style.webkitMaskImage.includes("iOS/interval-skip-back@")');

  • trunk/LayoutTests/media/modern-media-controls/tracks-button/tracks-button.html

    r207015 r207333  
    2929scheduler.frameDidFire = function()
    3030{
     31    if ([tracksButton, fullscreenTracksButton].some(button => button.width == 0))
     32        return;
     33
    3134    shouldBeTrue('tracksButton.element.style.webkitMaskImage.includes("macOS/media-selection@")');
    3235    shouldBeTrue('fullscreenTracksButton.element.style.webkitMaskImage.includes("macOS/media-selection-fullscreen@")');
Note: See TracChangeset for help on using the changeset viewer.