Changeset 207337 in webkit


Ignore:
Timestamp:
Oct 14, 2016 7:09:45 AM (7 years ago)
Author:
commit-queue@webkit.org
Message:

[Readable Streams API] Cleanup patch, fix small inconsistencies
https://bugs.webkit.org/show_bug.cgi?id=163329

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2016-10-14
Reviewed by Youenn Fablet.

Cleanup patch, fixed 3 small inconsistences between implementation and spec.

No change in behaviour.

  • Modules/streams/ReadableStream.idl: Added optional parameter in getReader.
  • Modules/streams/ReadableStreamDefaultController.js:

(error): Call readableStreamDefaultControllerError instead of readableStreamError.

  • Modules/streams/ReadableStreamInternals.js: Added missing ASSERT in readableStreamDefaultControllerCallPullIfNeeded.
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r207336 r207337  
     12016-10-14  Romain Bellessort  <romain.bellessort@crf.canon.fr>
     2
     3        [Readable Streams API] Cleanup patch, fix small inconsistencies
     4        https://bugs.webkit.org/show_bug.cgi?id=163329
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Cleanup patch, fixed 3 small inconsistences between implementation and spec.
     9
     10        No change in behaviour.
     11
     12        * Modules/streams/ReadableStream.idl: Added optional parameter in getReader.
     13        * Modules/streams/ReadableStreamDefaultController.js:
     14        (error): Call readableStreamDefaultControllerError instead of readableStreamError.
     15        * Modules/streams/ReadableStreamInternals.js: Added missing ASSERT in readableStreamDefaultControllerCallPullIfNeeded.
     16
    1172016-10-14  Youenn Fablet  <youenn@apple.com>
    218
  • trunk/Source/WebCore/Modules/streams/ReadableStream.idl

    r205549 r207337  
    3737] interface ReadableStream {
    3838    [NotEnumerable] Promise cancel(optional any reason);
    39     [NotEnumerable] Object getReader();
     39    [NotEnumerable] Object getReader(optional any options);
    4040    [NotEnumerable] Promise pipeTo(any streams, optional any options);
    4141    [NotEnumerable] Object pipeThrough(any dest, any options);
  • trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultController.js

    r206870 r207337  
    5353        @throwTypeError("ReadableStream is not readable");
    5454
    55     @readableStreamError(stream, error);
     55    @readableStreamDefaultControllerError(this, error);
    5656}
    5757
  • trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js

    r206912 r207337  
    300300    }
    301301
     302    @assert(!controller.@pullAgain);
    302303    controller.@pulling = true;
    303304
Note: See TracChangeset for help on using the changeset viewer.