Changeset 207343 in webkit

Timestamp:

Oct 14, 2016 9:23:18 AM (8 years ago)

Author:

Manuel Rego Casasnovas

Message:

[css-grid] Changing the argument on fit-content() doesn't cause the grid to be relayout
​https://bugs.webkit.org/show_bug.cgi?id=163434

Reviewed by Sergio Villar Senin.

Source/WebCore:

When fit-content() was implemented a new attribute
m_fitContentTrackBreadth was added to GridTrackSize.
However we forgot to include it in the == operator implementation,
so we were missing the changes on that value.

Now if you change the argument of a fit-content() track,
the track size is properly recomputed.

Test: fast/css-grid-layout/grid-change-fit-content-argument.html

• rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::operator==): Check m_fitContentTrackBreadth.

LayoutTests:

• fast/css-grid-layout/grid-change-fit-content-argument-expected.txt: Added.
• fast/css-grid-layout/grid-change-fit-content-argument.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css-grid-layout/grid-change-fit-content-argument-expected.txt (added)
• LayoutTests/fast/css-grid-layout/grid-change-fit-content-argument.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/GridTrackSize.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [css-grid] Changing the argument on fit-content() doesn't cause the grid to be relayout
+        https://bugs.webkit.org/show_bug.cgi?id=163434
+
+        Reviewed by Sergio Villar Senin.
+
+        * fast/css-grid-layout/grid-change-fit-content-argument-expected.txt: Added.
+        * fast/css-grid-layout/grid-change-fit-content-argument.html: Added.
+
 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [css-grid] Changing the argument on fit-content() doesn't cause the grid to be relayout
+        https://bugs.webkit.org/show_bug.cgi?id=163434
+
+        Reviewed by Sergio Villar Senin.
+
+        When fit-content() was implemented a new attribute
+        m_fitContentTrackBreadth was added to GridTrackSize.
+        However we forgot to include it in the == operator implementation,
+        so we were missing the changes on that value.
+
+        Now if you change the argument of a fit-content() track,
+        the track size is properly recomputed.
+
+        Test: fast/css-grid-layout/grid-change-fit-content-argument.html
+
+        * rendering/style/GridTrackSize.h:
+        (WebCore::GridTrackSize::operator==): Check m_fitContentTrackBreadth.
+
 2016-10-14  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/rendering/style/GridTrackSize.h

@@ -94 +94 @@
     bool operator==(const GridTrackSize& other) const
     {
-        return m_type == other.m_type && m_minTrackBreadth == other.m_minTrackBreadth && m_maxTrackBreadth == other.m_maxTrackBreadth;
+        return m_type == other.m_type && m_minTrackBreadth == other.m_minTrackBreadth && m_maxTrackBreadth == other.m_maxTrackBreadth
+            && m_fitContentTrackBreadth == other.m_fitContentTrackBreadth;
     }