Changeset 207347 in webkit

Timestamp:

Oct 14, 2016 11:14:03 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

test262: @isConstructor incorrectly thinks Math.cos is a constructor
​https://bugs.webkit.org/show_bug.cgi?id=163437

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-10-14
Reviewed by Saam Barati.

JSTests:

• stress/is-constructor.js: Added.

(assert):
(prototype.assert):
New test to cover the @isConstructor builtin.

• test262.yaml:

Test now passes.

Source/JavaScriptCore:

• runtime/JSFunction.cpp:

(JSC::JSFunction::getConstructData):
By default, Host JSFunctions are not constructable. They get
the default callHostFunctionAsConstructor native constructor.
When getting construct data we can return ConstructType::None
in these cases instead of indicating it might be constructable
and later throwing an exception when construction is attempted.

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/is-constructor.js (added)
• JSTests/test262.yaml (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/JSFunction.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
+
+        test262: @isConstructor incorrectly thinks Math.cos is a constructor
+        https://bugs.webkit.org/show_bug.cgi?id=163437
+
+        Reviewed by Saam Barati.
+
+        * stress/is-constructor.js: Added.
+        (assert):
+        (prototype.assert):
+        New test to cover the @isConstructor builtin.
+
+        * test262.yaml:
+        Test now passes.
+
 2016-10-14  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/JSTests/test262.yaml

@@ -3055 +3055 @@
   cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
 - path: test262/test/built-ins/Array/of/return-a-new-array-object.js
-  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
+  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []
 - path: test262/test/built-ins/Array/of/return-a-new-array-object.js
-  cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
+  cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], [:strict]
 - path: test262/test/built-ins/Array/of/return-abrupt-from-contructor.js
   cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js"], []

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
+
+        test262: @isConstructor incorrectly thinks Math.cos is a constructor
+        https://bugs.webkit.org/show_bug.cgi?id=163437
+
+        Reviewed by Saam Barati.
+
+        * runtime/JSFunction.cpp:
+        (JSC::JSFunction::getConstructData):
+        By default, Host JSFunctions are not constructable. They get
+        the default callHostFunctionAsConstructor native constructor.
+        When getting construct data we can return ConstructType::None
+        in these cases instead of indicating it might be constructable
+        and later throwing an exception when construction is attempted.
+
 2016-10-14  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

@@ -574 +574 @@
 
     if (thisObject->isHostFunction()) {
+        if (thisObject->nativeConstructor() == callHostFunctionAsConstructor)
+            return ConstructType::None;
         constructData.native.function = thisObject->nativeConstructor();
         return ConstructType::Host;