Changeset 207370 in webkit

Timestamp:

Oct 14, 2016 9:18:19 PM (8 years ago)

Author:

Simon Fraser

Message:

REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
​https://bugs.webkit.org/show_bug.cgi?id=163478

Reviewed by Daniel Bates.

Handle a None other in Contributor.eq.

• Scripts/webkitpy/common/config/committers.py:

(Contributor.eq):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/config/committers.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-10-14  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
+        https://bugs.webkit.org/show_bug.cgi?id=163478
+
+        Reviewed by Daniel Bates.
+        
+        Handle a None other in Contributor.__eq__.
+
+        * Scripts/webkitpy/common/config/committers.py:
+        (Contributor.__eq__):
+
 2016-10-14  JF Bastien  <jfbastien@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/config/committers.py

@@ -77 +77 @@
 
     def __eq__(self, other):
-        return (self.full_name == other.full_name
+        return (other is not None
+            and self.full_name == other.full_name
             and self.emails == other.emails
             and self._case_preserved_emails == other._case_preserved_emails