Changeset 207466 in webkit

Timestamp:

Oct 18, 2016 10:07:35 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Remote Web Inspector: Timeline UI not updating while recording
​https://bugs.webkit.org/show_bug.cgi?id=163582
<rdar://problem/28766837>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-10-18
Reviewed by Timothy Hatcher.

• WebProcess/WebPage/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::frontendLoaded):
Local inspector windows keep the web view alive and toggle the
WebInspector.visible state depending on whether or not an inspector is
open. Remote Inspector windows go away when closed, so they can always
be marked as open. This matches earlier remote inspector behavior.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/RemoteWebInspectorUI.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Remote Web Inspector: Timeline UI not updating while recording
+        https://bugs.webkit.org/show_bug.cgi?id=163582
+        <rdar://problem/28766837>
+
+        Reviewed by Timothy Hatcher.
+
+        * WebProcess/WebPage/RemoteWebInspectorUI.cpp:
+        (WebKit::RemoteWebInspectorUI::frontendLoaded):
+        Local inspector windows keep the web view alive and toggle the
+        WebInspector.visible state depending on whether or not an inspector is
+        open. Remote Inspector windows go away when closed, so they can always
+        be marked as open. This matches earlier remote inspector behavior.
+
 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/RemoteWebInspectorUI.cpp

@@ -96 +96 @@
     m_frontendAPIDispatcher.frontendLoaded();
 
+    m_frontendAPIDispatcher.dispatchCommand(ASCIILiteral("setIsVisible"), true);
+
     bringToFront();
 }