Changeset 207494 in webkit


Ignore:
Timestamp:
Oct 18, 2016 3:33:35 PM (7 years ago)
Author:
Ryan Haddad
Message:

Unreviewed, rolling out r207413.

This change broke iOS builds.

Reverted changeset:

"[iOS] Hook up WebPlatformTouchPoint's radiusX / radiusY to
_UIWebTouchPoint.majorRadiusInScreenCoordinates"
https://bugs.webkit.org/show_bug.cgi?id=163547
http://trac.webkit.org/changeset/207413

Location:
trunk/Source/WebKit2
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit2/ChangeLog

    r207484 r207494  
     12016-10-18  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Unreviewed, rolling out r207413.
     4
     5        This change broke iOS builds.
     6
     7        Reverted changeset:
     8
     9        "[iOS] Hook up WebPlatformTouchPoint's radiusX / radiusY to
     10        _UIWebTouchPoint.majorRadiusInScreenCoordinates"
     11        https://bugs.webkit.org/show_bug.cgi?id=163547
     12        http://trac.webkit.org/changeset/207413
     13
    1142016-10-18  Commit Queue  <commit-queue@webkit.org>
    215
  • trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h

    r207413 r207494  
    655655    UITouchPhase phase;
    656656#if __IPHONE_OS_VERSION_MIN_REQUIRED > 100000
    657     CGFloat majorRadiusInScreenCoordinates;
     657    // FIXME: Uncomment this once UIKit is updated (rdar://problem/28555313).
     658    // CGFloat majorRadiusInScreenCoordinates;
    658659    CGFloat force;
    659660    CGFloat altitudeAngle;
  • trunk/Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm

    r207413 r207494  
    104104        WebPlatformTouchPoint platformTouchPoint = WebPlatformTouchPoint(identifier, location, phase);
    105105#if ENABLE(IOS_TOUCH_EVENTS)
    106         platformTouchPoint.setRadiusX(touchPoint.majorRadiusInScreenCoordinates);
    107         platformTouchPoint.setRadiusY(touchPoint.majorRadiusInScreenCoordinates);
     106        // FIXME: We should use touchPoint.majorRadiusInScreenCoordinates for radiusX / radiusY once it is available (rdar://problem/28555313).
     107        platformTouchPoint.setRadiusX(0);
     108        platformTouchPoint.setRadiusY(0);
    108109        platformTouchPoint.setRotationAngle(0); // Not available in _UIWebTouchEvent yet.
    109110        platformTouchPoint.setForce(touchPoint.force);
Note: See TracChangeset for help on using the changeset viewer.