Changeset 207496 in webkit

Timestamp:

Oct 18, 2016 4:04:13 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: AXI: focused/focusable state should be based on Accessibility Object instead of Element
​https://bugs.webkit.org/show_bug.cgi?id=163088
<rdar://problem/16421985>

Patch by Aaron Chu <​aaron_chu@apple.com> on 2016-10-18
Reviewed by Darin Adler.

Changed code in InspectDOMAgent so that it determines the focusability of a Node based
on the AccessibilityNodeObject and not the Element class.

Covered by existing tests:
LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorDOMAgent.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-18  Aaron Chu  <aaron_chu@apple.com>
+
+        Web Inspector: AXI: focused/focusable state should be based on Accessibility Object instead of Element
+        https://bugs.webkit.org/show_bug.cgi?id=163088
+        <rdar://problem/16421985>
+
+        Reviewed by Darin Adler.
+
+        Changed code in InspectDOMAgent so that it determines the focusability of a Node based
+        on the AccessibilityNodeObject and not the Element class.
+
+        Covered by existing tests: 
+        LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html
+
+        * inspector/InspectorDOMAgent.cpp:
+        (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
+
 2016-10-18  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp

@@ -1676 +1676 @@
             
             if (is<Element>(*node)) {
-                supportsFocused = downcast<Element>(*node).isFocusable();
+                supportsFocused = axObject->canSetFocusAttribute();
                 if (supportsFocused)
                     focused = axObject->isFocused();