Changeset 207565 in webkit

Timestamp:

Oct 19, 2016 1:34:14 PM (8 years ago)

Author:

hyatt@apple.com

Message:

[CSS Parser] class and id parsing need to be case-insensitive in HTML quirks mode
​https://bugs.webkit.org/show_bug.cgi?id=163685

Reviewed by Zalan Bujtas.

Class and ID parsing should be case-insensitive in quirks mode. Apply the same hack
that the old parser did and lowercase the class and ids in place.

• css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumeId):
(WebCore::CSSSelectorParser::consumeClass):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/parser/CSSSelectorParser.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-19  Dave Hyatt  <hyatt@apple.com>
+
+        [CSS Parser] class and id parsing need to be case-insensitive in HTML quirks mode
+        https://bugs.webkit.org/show_bug.cgi?id=163685
+
+        Reviewed by Zalan Bujtas.
+
+        Class and ID parsing should be case-insensitive in quirks mode. Apply the same hack
+        that the old parser did and lowercase the class and ids in place.
+
+        * css/parser/CSSSelectorParser.cpp:
+        (WebCore::CSSSelectorParser::consumeId):
+        (WebCore::CSSSelectorParser::consumeClass):
+
 2016-10-19  Nan Wang  <n_wang@apple.com>
 

trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp

@@ -31 +31 @@
 #include "CSSSelectorParser.h"
 
+#include "CSSParserIdioms.h"
 #include "CSSParserMode.h"
 #include "CSSSelectorList.h"
@@ -357 +358 @@
     std::unique_ptr<CSSParserSelector> selector = std::unique_ptr<CSSParserSelector>(new CSSParserSelector());
     selector->setMatch(CSSSelector::Id);
-    AtomicString value = range.consume().value().toAtomicString();
-    selector->setValue(value);
+    
+    // FIXME-NEWPARSER: Avoid having to do this, but the old parser does and we need
+    // to be compatible for now.
+    StringView stringView = range.consume().value();
+    if (m_context.mode == HTMLQuirksMode)
+        convertToASCIILowercaseInPlace(stringView);
+    selector->setValue(stringView.toAtomicString());
+
     return selector;
 }
@@ -371 +378 @@
     std::unique_ptr<CSSParserSelector> selector = std::unique_ptr<CSSParserSelector>(new CSSParserSelector());
     selector->setMatch(CSSSelector::Class);
-    AtomicString value = range.consume().value().toAtomicString();
-    selector->setValue(value);
+    
+    // FIXME-NEWPARSER: Avoid having to do this, but the old parser does and we need
+    // to be compatible for now.
+    StringView stringView = range.consume().value();
+    if (m_context.mode == HTMLQuirksMode)
+        convertToASCIILowercaseInPlace(stringView);
+    selector->setValue(stringView.toAtomicString());
+
     return selector;
 }