Changeset 207581 in webkit


Ignore:
Timestamp:
Oct 19, 2016 5:39:09 PM (8 years ago)
Author:
mmaxfield@apple.com
Message:

CSS font-variation-settings does not handle uppercase axis names in variable fonts
​https://bugs.webkit.org/show_bug.cgi?id=163546

Reviewed by Dean Jackson.

Source/WebCore:

Remove the extra toASCIILower() call.

Test: fast/text/variations/case-axis-names.html

  • css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseFontVariationTag):

LayoutTests:

  • fast/text/variations/case-axis-names-expected.html: Added.
  • fast/text/variations/case-axis-names.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r207578 r207581  
     12016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        CSS font-variation-settings does not handle uppercase axis names in variable fonts
     4        https://bugs.webkit.org/show_bug.cgi?id=163546
     5
     6        Reviewed by Dean Jackson.
     7
     8        * fast/text/variations/case-axis-names-expected.html: Added.
     9        * fast/text/variations/case-axis-names.html: Added.
     10
    1112016-10-19  Joone Hur  <joone.hur@intel.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r207580 r207581  
     12016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        CSS font-variation-settings does not handle uppercase axis names in variable fonts
     4        https://bugs.webkit.org/show_bug.cgi?id=163546
     5
     6        Reviewed by Dean Jackson.
     7
     8        Remove the extra toASCIILower() call.
     9
     10        Test: fast/text/variations/case-axis-names.html
     11
     12        * css/parser/CSSParser.cpp:
     13        (WebCore::CSSParser::parseFontVariationTag):
     14
    1152016-10-19  Anders Carlsson  <andersca@apple.com>
    216

  • trunk/Source/WebCore/css/parser/CSSParser.cpp

    r207536 r207581  
    1059410594        if (character < 0x20 || character > 0x7E)
    1059510595            return false;
    10596         tag[i] = toASCIILower(character);
     10596        tag[i] = character;
    1059710597    }
    1059810598
Note: See TracChangeset for help on using the changeset viewer.