Changeset 207588 in webkit

Timestamp:

Oct 20, 2016 12:26:55 AM (8 years ago)

Author:

nael.ouedraogo@crf.canon.fr

Message:

WebRTC: The MediaStreamTrackEvent init dictionary needs a required track member
​https://bugs.webkit.org/show_bug.cgi?id=146232

Update MediaStreamTrackEvent IDL as per specification.

Source/WebCore:

Reviewed by Darin Adler.

No additional test required, rebase existings tests.

• Modules/mediastream/MediaStreamTrackEvent.idl:

LayoutTests:

No additional test required, rebase existings tests.

Reviewed by Darin Adler.

• fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
• fast/mediastream/MediaStreamTrackEvent-constructor.html: Remove

useless tests.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt (modified) (1 diff)
• LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-10-20  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
+
+        WebRTC: The MediaStreamTrackEvent init dictionary needs a required track member
+        https://bugs.webkit.org/show_bug.cgi?id=146232
+
+        Update MediaStreamTrackEvent IDL as per specification.
+
+        No additional test required, rebase existings tests.
+
+        Reviewed by Darin Adler.
+
+        * fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
+        * fast/mediastream/MediaStreamTrackEvent-constructor.html: Remove
+        useless tests.
+
 2016-10-19  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt

@@ -10 +10 @@
 
 *** No initializer passed ***
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent').bubbles is false
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent').cancelable is false
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent').track is null
+PASS new MediaStreamTrackEvent('MediaStreamTrackEvent') threw exception TypeError: Not enough arguments.
 
 *** Bubbles and cancelable true, track is missing ***
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).bubbles is true
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).cancelable is true
-PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).track is null
+PASS new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }) threw exception TypeError: Type error.
 
 *** Bubbles and cancelable true, invalid track ***

trunk/LayoutTests/fast/mediastream/MediaStreamTrackEvent-constructor.html

@@ -24 +24 @@
             {
                 debug("<br>*** No initializer passed ***");
-                shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent').bubbles", "false");
-                shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent').cancelable", "false");
-                shouldBeNull("new MediaStreamTrackEvent('MediaStreamTrackEvent').track");
-    
+                shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent')", "TypeError");
+
                 debug("<br>*** Bubbles and cancelable true, track is missing ***");
-                shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).bubbles", "true");
-                shouldBe("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).cancelable", "true");
-                shouldBeNull("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true }).track");
-    
+                shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true })", "TypeError");
+
                 debug("<br>*** Bubbles and cancelable true, invalid track ***");
                 shouldThrowErrorName("new MediaStreamTrackEvent('MediaStreamTrackEvent', { bubbles: true, cancelable: true, track: MediaStreamTrack })", "TypeError");

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-20  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
+
+        WebRTC: The MediaStreamTrackEvent init dictionary needs a required track member
+        https://bugs.webkit.org/show_bug.cgi?id=146232
+
+        Update MediaStreamTrackEvent IDL as per specification.
+
+        Reviewed by Darin Adler.
+
+        No additional test required, rebase existings tests.
+
+        * Modules/mediastream/MediaStreamTrackEvent.idl:
+
 2016-10-19  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.idl

@@ -25 +25 @@
 [
     Conditional=MEDIA_STREAM,
-    Constructor(DOMString type, optional MediaStreamTrackEventInit eventInitDict),
+    Constructor(DOMString type, MediaStreamTrackEventInit eventInitDict),
 ] interface MediaStreamTrackEvent : Event {
-    readonly attribute MediaStreamTrack? track;
+    readonly attribute MediaStreamTrack track;
 };
 
 dictionary MediaStreamTrackEventInit : EventInit {
-    // FIXME: The specification says that this member should be required and non-nullable.
-    MediaStreamTrack? track = null;
+    required MediaStreamTrack track;
 };