Changeset 207625 in webkit
- Timestamp:
- Oct 20, 2016 11:02:31 AM (7 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r207623 r207625 1 2016-10-19 Yusuke Suzuki <utatane.tea@gmail.com> 2 3 [JSC] Move InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero to out of line type info flags 4 https://bugs.webkit.org/show_bug.cgi?id=163716 5 6 Reviewed by Saam Barati. 7 8 We found that all the accesses to the InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero flag is 9 done through the Structure. There is no user that accesses this flag in the cell inlined member. And JIT 10 code does not access it directly. That means that we can move this flag from inlined flags to out of line 11 flags. This patch moves it to the out of line flags. And make one bit empty in inlined flags. Later this 12 new empty flag will be used by megamorphic DOMJIT implementation. 13 14 * runtime/JSTypeInfo.h: 15 (JSC::TypeInfo::hasStaticPropertyTable): 16 (JSC::TypeInfo::interceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero): 17 1 18 2016-10-20 Keith Miller <keith_miller@apple.com> 2 19 -
trunk/Source/JavaScriptCore/runtime/JSTypeInfo.h
r206525 r207625 40 40 static const unsigned TypeOfShouldCallGetCallData = 1 << 2; // Need this flag if you override getCallData() and you want typeof to use this to determine if it should say "function". Currently we always set this flag when we override getCallData(). 41 41 static const unsigned OverridesGetOwnPropertySlot = 1 << 3; 42 static const unsigned InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero = 1 << 4;43 42 static const unsigned StructureIsImmortal = 1 << 5; 44 43 static const unsigned OverridesToThis = 1 << 6; // If this is false then this returns something other than 'this'. Non-object cells that are visible to JS have this set as do some exotic objects. … … 52 51 static const unsigned IsEnvironmentRecord = 1 << 13; 53 52 static const unsigned GetOwnPropertySlotIsImpureForPropertyAbsence = 1 << 14; 53 static const unsigned InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero = 1 << 15; 54 54 55 55 class TypeInfo { … … 84 84 static bool overridesGetOwnPropertySlot(InlineTypeFlags flags) { return flags & OverridesGetOwnPropertySlot; } 85 85 static bool hasStaticPropertyTable(InlineTypeFlags flags) { return flags & HasStaticPropertyTable; } 86 bool interceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero() const { return isSetOnFlags1(InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero); }87 86 bool structureIsImmortal() const { return isSetOnFlags1(StructureIsImmortal); } 88 87 bool overridesToThis() const { return isSetOnFlags1(OverridesToThis); } … … 93 92 bool newImpurePropertyFiresWatchpoints() const { return isSetOnFlags2(NewImpurePropertyFiresWatchpoints); } 94 93 bool isEnvironmentRecord() const { return isSetOnFlags2(IsEnvironmentRecord); } 94 bool interceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero() const { return isSetOnFlags2(InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero); } 95 95 96 96 static ptrdiff_t flagsOffset()
Note: See TracChangeset
for help on using the changeset viewer.