Changeset 207765 in webkit

Timestamp:

Oct 24, 2016 10:53:40 AM (7 years ago)

Author:

mark.lam@apple.com

Message:

Dumping of op_negate bytecode is broken.
​https://bugs.webkit.org/show_bug.cgi?id=163896

Reviewed by Darin Adler.

It thinks the bytecode consists of only 3 machine words, when it consists of 4.
This is now fixed.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/CodeBlock.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-10-24  Mark Lam  <mark.lam@apple.com>
+
+        Dumping of op_negate bytecode is broken.
+        https://bugs.webkit.org/show_bug.cgi?id=163896
+
+        Reviewed by Darin Adler.
+
+        It thinks the bytecode consists of only 3 machine words, when it consists of 4.
+        This is now fixed.
+
+        * bytecode/CodeBlock.cpp:
+        (JSC::CodeBlock::dumpBytecode):
+
 2016-10-24  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/JavaScriptCore/bytecode/CodeBlock.cpp

@@ -1000 +1000 @@
         case op_negate: {
             printUnaryOp(out, exec, location, it, "negate");
+            ++it; // op_negate has an extra operand for the ArithProfile.
             break;
         }