Changeset 207896 in webkit

Timestamp:

Oct 26, 2016 6:24:12 AM (7 years ago)

Author:

akling@apple.com

Message:

Fix mach port leak in ResourceUsageThread.
<​https://webkit.org/b/164012>

Reviewed by Antti Koivisto.

The threads returned by task_threads() need to be deallocated.

• page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::cpuUsage):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/cocoa/ResourceUsageThreadCocoa.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-10-26  Andreas Kling  <akling@apple.com>
+
+        Fix mach port leak in ResourceUsageThread.
+        <https://webkit.org/b/164012>
+
+        Reviewed by Antti Koivisto.
+
+        The threads returned by task_threads() need to be deallocated.
+
+        * page/cocoa/ResourceUsageThreadCocoa.mm:
+        (WebCore::cpuUsage):
+
 2016-10-26  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
 

trunk/Source/WebCore/page/cocoa/ResourceUsageThreadCocoa.mm

@@ -165 +165 @@
         if (!(threadBasicInfo->flags & TH_FLAGS_IDLE))
             usage += threadBasicInfo->cpu_usage / static_cast<float>(TH_USAGE_SCALE) * 100.0;
+
+        mach_port_deallocate(mach_task_self(), threadList[i]);
     }