Changeset 207928 in webkit


Ignore:
Timestamp:
Oct 26, 2016 5:17:52 PM (7 years ago)
Author:
BJ Burg
Message:

Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
​https://bugs.webkit.org/show_bug.cgi?id=164046

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/InspectorFrontendChannel.h:
  • inspector/remote/RemoteConnectionToTarget.h:
  • inspector/remote/RemoteConnectionToTarget.mm:

(Inspector::RemoteConnectionToTarget::sendMessageToFrontend):

Source/WebCore:

  • inspector/InspectorClient.cpp:

(WebCore::InspectorClient::doDispatchMessageOnFrontendPage):

  • inspector/InspectorClient.h:
  • testing/Internals.cpp:

(WebCore::InspectorStubFrontend::sendMessageToFrontend):

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

(WebInspectorClient::sendMessageToFrontend):

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::sendMessageToFrontend):

  • WebProcess/WebPage/WebInspector.h:
Location:
trunk/Source
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r207927 r207928  
     12016-10-26  Brian Burg  <bburg@apple.com>
     2
     3        Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
     4        https://bugs.webkit.org/show_bug.cgi?id=164046
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        * inspector/InspectorFrontendChannel.h:
     9        * inspector/remote/RemoteConnectionToTarget.h:
     10        * inspector/remote/RemoteConnectionToTarget.mm:
     11        (Inspector::RemoteConnectionToTarget::sendMessageToFrontend):
     12
    1132016-10-26  JF Bastien  <jfbastien@apple.com>
    214

  • trunk/Source/JavaScriptCore/inspector/InspectorFrontendChannel.h

    r204479 r207928  
    4343    virtual ~FrontendChannel() { }
    4444    virtual ConnectionType connectionType() const = 0;
    45     virtual bool sendMessageToFrontend(const String& message) = 0;
     45    virtual void sendMessageToFrontend(const String& message) = 0;
    4646};
    4747

  • trunk/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.h

    r204686 r207928  
    6464    // FrontendChannel overrides.
    6565    ConnectionType connectionType() const override { return ConnectionType::Remote; }
    66     bool sendMessageToFrontend(const String&) override;
     66    void sendMessageToFrontend(const String&) override;
    6767
    6868private:

  • trunk/Source/JavaScriptCore/inspector/remote/RemoteConnectionToTarget.mm

    r204466 r207928  
    229229}
    230230
    231 bool RemoteConnectionToTarget::sendMessageToFrontend(const String& message)
    232 {
    233     if (!m_target)
    234         return false;
     231void RemoteConnectionToTarget::sendMessageToFrontend(const String& message)
     232{
     233    if (!targetIdentifier())
     234        return;
    235235
    236236    RemoteInspector::singleton().sendMessageToRemote(targetIdentifier().value(), message);
    237     return true;
    238237}
    239238

  • trunk/Source/WebCore/ChangeLog

    r207914 r207928  
     12016-10-26  Brian Burg  <bburg@apple.com>
     2
     3        Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
     4        https://bugs.webkit.org/show_bug.cgi?id=164046
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        * inspector/InspectorClient.cpp:
     9        (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
     10        * inspector/InspectorClient.h:
     11        * testing/Internals.cpp:
     12        (WebCore::InspectorStubFrontend::sendMessageToFrontend):
     13
    1142016-10-26  Chris Dumez  <cdumez@apple.com>
    215

  • trunk/Source/WebCore/inspector/InspectorClient.cpp

    r178820 r207928  
    4242namespace WebCore {
    4343
    44 bool InspectorClient::doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message)
     44void InspectorClient::doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message)
    4545{
    4646    if (!frontendPage)
    47         return false;
     47        return;
    4848
    49     String dispatchToFrontend = "InspectorFrontendAPI.dispatchMessageAsync(" + message + ");";
    50 
    51     // FIXME: This should execute the script in the appropriate world.
     49    String dispatchToFrontend = makeString("InspectorFrontendAPI.dispatchMessageAsync(", message, ");");
    5250    frontendPage->mainFrame().script().evaluate(ScriptSourceCode(dispatchToFrontend));
    53     return true;
    5451}
    5552

  • trunk/Source/WebCore/inspector/InspectorClient.h

    r204479 r207928  
    6464    virtual bool handleJavaScriptDialog(bool, const String*) { return false; }
    6565
    66     WEBCORE_EXPORT static bool doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message);
     66    WEBCORE_EXPORT static void doDispatchMessageOnFrontendPage(Page* frontendPage, const String& message);
    6767};
    6868

  • trunk/Source/WebCore/testing/Internals.cpp

    r207839 r207928  
    251251    void setAttachedWindowWidth(unsigned) final { }
    252252
    253     bool sendMessageToFrontend(const String& message) final;
     253    void sendMessageToFrontend(const String& message) final;
    254254    ConnectionType connectionType() const final { return ConnectionType::Local; }
    255255
    … …  
    294294}
    295295
    296 bool InspectorStubFrontend::sendMessageToFrontend(const String& message)
     296void InspectorStubFrontend::sendMessageToFrontend(const String& message)
    297297{
    298298    ASSERT_ARG(message, !message.isEmpty());
    299299
    300     return InspectorClient::doDispatchMessageOnFrontendPage(frontendPage(), message);
     300    InspectorClient::doDispatchMessageOnFrontendPage(frontendPage(), message);
    301301}
    302302

  • trunk/Source/WebKit/cf/ChangeLog

    r207151 r207928  
     12016-10-26  Brian Burg  <bburg@apple.com>
     2
     3        Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
     4        https://bugs.webkit.org/show_bug.cgi?id=164046
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        * WebCoreSupport/WebInspectorClientCF.cpp:
     9        (WebInspectorClient::sendMessageToFrontend):
     10
    1112016-10-11  Alex Christensen  <achristensen@webkit.org>
    212

  • trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp

    r207151 r207928  
    9090}
    9191
    92 bool WebInspectorClient::sendMessageToFrontend(const String& message)
     92void WebInspectorClient::sendMessageToFrontend(const String& message)
    9393{
    94     return doDispatchMessageOnFrontendPage(m_frontendPage, message);
     94    doDispatchMessageOnFrontendPage(m_frontendPage, message);
    9595}
    9696

  • trunk/Source/WebKit/mac/ChangeLog

    r207769 r207928  
     12016-10-26  Brian Burg  <bburg@apple.com>
     2
     3        Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
     4        https://bugs.webkit.org/show_bug.cgi?id=164046
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        * WebCoreSupport/WebInspectorClient.h:
     9
    1102016-10-21  Alex Christensen  <achristensen@webkit.org>
    211

  • trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h

    r197563 r207928  
    7474    void didSetSearchingForNode(bool) override;
    7575
    76     bool sendMessageToFrontend(const String&) override;
     76    void sendMessageToFrontend(const String&) override;
    7777    ConnectionType connectionType() const override { return ConnectionType::Local; }
    7878

  • trunk/Source/WebKit/win/ChangeLog

    r207585 r207928  
     12016-10-26  Brian Burg  <bburg@apple.com>
     2
     3        Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
     4        https://bugs.webkit.org/show_bug.cgi?id=164046
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        * WebCoreSupport/WebInspectorClient.h:
     9
    1102016-10-19  Alex Christensen  <achristensen@webkit.org>
    211

  • trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h

    r197563 r207928  
    6464    // FrontendChannel API.
    6565    ConnectionType connectionType() const override { return ConnectionType::Local; }
    66     bool sendMessageToFrontend(const WTF::String&) override;
     66    void sendMessageToFrontend(const WTF::String&) override;
    6767
    6868    bool inspectorStartsAttached();

  • trunk/Source/WebKit2/ChangeLog

    r207898 r207928  
     12016-10-26  Brian Burg  <bburg@apple.com>
     2
     3        Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
     4        https://bugs.webkit.org/show_bug.cgi?id=164046
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        * WebProcess/WebPage/WebInspector.cpp:
     9        (WebKit::WebInspector::sendMessageToFrontend):
     10        * WebProcess/WebPage/WebInspector.h:
     11
    1122016-10-26  Eric Carlson  <eric.carlson@apple.com>
    213

  • trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp

    r201101 r207928  
    280280}
    281281
    282 bool WebInspector::sendMessageToFrontend(const String& message)
     282void WebInspector::sendMessageToFrontend(const String& message)
    283283{
    284284#if ENABLE(INSPECTOR_SERVER)
    … …  
    288288#endif
    289289        m_frontendConnection->send(Messages::WebInspectorUI::SendMessageToFrontend(message), 0);
    290     return true;
    291290}
    292291

  • trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.h

    r205403 r207928  
    4545    void updateDockingAvailability();
    4646
    47     bool sendMessageToFrontend(const String& message) override;
     47    void sendMessageToFrontend(const String& message) override;
    4848    ConnectionType connectionType() const override { return ConnectionType::Local; }
    4949
Note: See TracChangeset for help on using the changeset viewer.