Changeset 208082 in webkit


Ignore:
Timestamp:
Oct 28, 2016 4:49:46 PM (7 years ago)
Author:
rniwa@webkit.org
Message:

Add CEReactions to the remaining HTML DOM APIs
​https://bugs.webkit.org/show_bug.cgi?id=163969

Reviewed by Chris Dumez.

Source/WebCore:

Added CEReactions to the remaining DOM and HTML APIs as needed.

Tests: fast/custom-elements/reactions-for-indieui.html

fast/custom-elements/reactions/Document.html
fast/custom-elements/reactions/HTMLAnchorElement.html
fast/custom-elements/reactions/HTMLOptionElement.html
fast/custom-elements/reactions/HTMLOptionsCollection.html
fast/custom-elements/reactions/HTMLOutputElement.html
fast/custom-elements/reactions/HTMLSelectElement.html
fast/custom-elements/reactions/HTMLTableElement.html
fast/custom-elements/reactions/HTMLTableRowElement.html
fast/custom-elements/reactions/HTMLTableSectionElement.html
fast/custom-elements/reactions/HTMLTitleElement.html
fast/custom-elements/reactions/ShadowRoot.html

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::setLength):
(WebCore::JSHTMLOptionsCollection::indexSetter):

  • bindings/js/JSHTMLSelectElementCustom.cpp:

(WebCore::JSHTMLSelectElement::indexSetter):

  • dom/CharacterData.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/ShadowRoot.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTitleElement.idl:

LayoutTests:

Added W3C style testharness.js tests for CEReactions to various HTMLElements under fast/custom-elements/reactions.
Also added some WebKit specific tests using the same harness outside that directory.

  • fast/custom-elements/reactions-for-indieui-expected.txt: Added.
  • fast/custom-elements/reactions-for-indieui.html: Added.
  • fast/custom-elements/reactions-for-webkit-extensions-expected.txt:
  • fast/custom-elements/reactions-for-webkit-extensions.html:
  • fast/custom-elements/reactions/Document-expected.txt: Added.
  • fast/custom-elements/reactions/Document.html: Added.
  • fast/custom-elements/reactions/HTMLAnchorElement-expected.txt: Added.
  • fast/custom-elements/reactions/HTMLAnchorElement.html: Added.
  • fast/custom-elements/reactions/HTMLOptionElement-expected.txt: Added.
  • fast/custom-elements/reactions/HTMLOptionElement.html: Added.
  • fast/custom-elements/reactions/HTMLOptionsCollection-expected.txt: Added.
  • fast/custom-elements/reactions/HTMLOptionsCollection.html: Added.
  • fast/custom-elements/reactions/HTMLOutputElement-expected.txt: Added.
  • fast/custom-elements/reactions/HTMLOutputElement.html: Added.
  • fast/custom-elements/reactions/HTMLSelectElement-expected.txt: Added.
  • fast/custom-elements/reactions/HTMLSelectElement.html: Added.
  • fast/custom-elements/reactions/HTMLTableElement-expected.txt: Added.
  • fast/custom-elements/reactions/HTMLTableElement.html: Added.
  • fast/custom-elements/reactions/HTMLTableRowElement-expected.txt: Added.
  • fast/custom-elements/reactions/HTMLTableRowElement.html: Added.
  • fast/custom-elements/reactions/HTMLTableSectionElement-expected.txt: Added.
  • fast/custom-elements/reactions/HTMLTableSectionElement.html: Added.
  • fast/custom-elements/reactions/HTMLTitleElement-expected.txt: Added.
  • fast/custom-elements/reactions/HTMLTitleElement.html: Added.
  • fast/custom-elements/reactions/ShadowRoot-expected.txt: Added.
  • fast/custom-elements/reactions/ShadowRoot.html: Added.
  • fast/custom-elements/resources/additional-helpers.js: Added.
  • fast/custom-elements/upgrading-enqueue-reactions-expected.txt:
  • fast/custom-elements/upgrading-enqueue-reactions.html:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
Location:
trunk
Files:
25 added
24 edited
1 copied

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r208080 r208082  
     12016-10-28  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Add CEReactions to the remaining HTML DOM APIs
     4        https://bugs.webkit.org/show_bug.cgi?id=163969
     5
     6        Reviewed by Chris Dumez.
     7
     8        Added W3C style testharness.js tests for CEReactions to various HTMLElements under fast/custom-elements/reactions.
     9        Also added some WebKit specific tests using the same harness outside that directory.
     10
     11        * fast/custom-elements/reactions-for-indieui-expected.txt: Added.
     12        * fast/custom-elements/reactions-for-indieui.html: Added.
     13        * fast/custom-elements/reactions-for-webkit-extensions-expected.txt:
     14        * fast/custom-elements/reactions-for-webkit-extensions.html:
     15        * fast/custom-elements/reactions/Document-expected.txt: Added.
     16        * fast/custom-elements/reactions/Document.html: Added.
     17        * fast/custom-elements/reactions/HTMLAnchorElement-expected.txt: Added.
     18        * fast/custom-elements/reactions/HTMLAnchorElement.html: Added.
     19        * fast/custom-elements/reactions/HTMLOptionElement-expected.txt: Added.
     20        * fast/custom-elements/reactions/HTMLOptionElement.html: Added.
     21        * fast/custom-elements/reactions/HTMLOptionsCollection-expected.txt: Added.
     22        * fast/custom-elements/reactions/HTMLOptionsCollection.html: Added.
     23        * fast/custom-elements/reactions/HTMLOutputElement-expected.txt: Added.
     24        * fast/custom-elements/reactions/HTMLOutputElement.html: Added.
     25        * fast/custom-elements/reactions/HTMLSelectElement-expected.txt: Added.
     26        * fast/custom-elements/reactions/HTMLSelectElement.html: Added.
     27        * fast/custom-elements/reactions/HTMLTableElement-expected.txt: Added.
     28        * fast/custom-elements/reactions/HTMLTableElement.html: Added.
     29        * fast/custom-elements/reactions/HTMLTableRowElement-expected.txt: Added.
     30        * fast/custom-elements/reactions/HTMLTableRowElement.html: Added.
     31        * fast/custom-elements/reactions/HTMLTableSectionElement-expected.txt: Added.
     32        * fast/custom-elements/reactions/HTMLTableSectionElement.html: Added.
     33        * fast/custom-elements/reactions/HTMLTitleElement-expected.txt: Added.
     34        * fast/custom-elements/reactions/HTMLTitleElement.html: Added.
     35        * fast/custom-elements/reactions/ShadowRoot-expected.txt: Added.
     36        * fast/custom-elements/reactions/ShadowRoot.html: Added.
     37        * fast/custom-elements/resources/additional-helpers.js: Added.
     38        * fast/custom-elements/upgrading-enqueue-reactions-expected.txt:
     39        * fast/custom-elements/upgrading-enqueue-reactions.html:
     40        * platform/efl/TestExpectations:
     41        * platform/gtk/TestExpectations:
     42
    1432016-10-28  Antoine Quint  <graouts@apple.com>
    244

  • trunk/LayoutTests/fast/custom-elements/reactions-for-indieui.html

    r208081 r208082  
    22<html>
    33<head>
    4 <title>Custom Elements: CEReactions on HTMLElement interface</title>
     4<title>Custom Elements: CEReactions on uiactions of Element interface</title>
    55<meta name="author" title="Ryosuke Niwa" href="mailto:rniwa@webkit.org">
    6 <meta name="assert" content="webkitdropzone of HTMLElement interface must have CEReactions">
     6<meta name="assert" content="uiactions of Element interface must have CEReactions">
    77<meta name="help" content="https://dom.spec.whatwg.org/#node">
    88<script src="../../resources/testharness.js"></script>
    … …  
    1515<script>
    1616
    17 testReflectAttribute('webkitdropzone', 'webkitdropzone', 'copy', 'move', 'dropzone on HTMLElement');
     17testReflectAttribute('uiactions', 'uiactions', 'delete', 'dismiss', 'uiactions on Element');
    1818
    1919</script>

  • trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt

    r207571 r208082  
    22PASS dropzone on HTMLElement must enqueue an attributeChanged reaction when adding webkitdropzone content attribute
    33PASS dropzone on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute
     4PASS data on CharacterData must enqueue an attributeChanged reaction when replacing an existing attribute
     5PASS data on CharacterData must not enqueue an attributeChanged reaction when replacing an existing unobserved attribute
     6PASS appendData on CharacterData must enqueue an attributeChangedCallback when mutating an existing attribute
     7PASS insertData on CharacterData must enqueue an attributeChangedCallback when mutating an existing attribute
     8PASS deleteData on CharacterData must enqueue an attributeChangedCallback when mutating an existing attribute
     9PASS replaceData on CharacterData must enqueue an attributeChangedCallback when mutating an existing attribute
     10PASS remove(HTMLOptionElement) on HTMLOptionsCollection must enqueue disconnectedCallback when removing a custom element
     11PASS remove(HTMLOptionElement) on HTMLSelectElement must enqueue disconnectedCallback when removing a custom element
    412

  • trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html

    r207864 r208082  
    22<html>
    33<head>
    4 <title>Custom Elements: CEReactions on HTMLElement interface</title>
     4<title>Custom Elements: CEReactions on HTMLElement and Attr interfaces</title>
    55<meta name="author" title="Ryosuke Niwa" href="mailto:rniwa@webkit.org">
    6 <meta name="assert" content="webkitdropzone of HTMLElement interface must have CEReactions">
     6<meta name="assert" content="webkitdropzone of HTMLElement and Attr interface must have CEReactions">
    77<meta name="help" content="https://dom.spec.whatwg.org/#node">
    88<script src="../../resources/testharness.js"></script>
    … …  
    1010<script src="../../imported/w3c/web-platform-tests/custom-elements/resources/custom-elements-helpers.js"></script>
    1111<script src="../../imported/w3c/web-platform-tests/custom-elements/reactions/resources/reactions.js"></script>
     12<script src="resources/additional-helpers.js"></script>
    1213</head>
    1314<body>
    … …  
    1718testReflectAttribute('webkitdropzone', 'webkitdropzone', 'copy', 'move', 'dropzone on HTMLElement');
    1819
     20testAttributeMutator(function (element, name, value) {
     21    element.attributes[name].firstChild.data = value;
     22}, 'data on CharacterData');
     23
     24test(function () {
     25    var element = define_new_custom_element(['title']);
     26    var instance = document.createElement(element.name);
     27    instance.setAttribute('title', 'hello');
     28    assert_array_equals(element.takeLog().types(), ['constructed', 'attributeChanged']);
     29    instance.attributes.title.firstChild.appendData(' world');
     30    var logEntries = element.takeLog();
     31    assert_array_equals(logEntries.types(), ['attributeChanged']);
     32    assert_attribute_log_entry(logEntries.last(), {name: 'title', oldValue: 'hello', newValue: 'hello world', namespace: null});
     33}, 'appendData on CharacterData must enqueue an attributeChangedCallback when mutating an existing attribute');
     34
     35test(function () {
     36    var element = define_new_custom_element(['title']);
     37    var instance = document.createElement(element.name);
     38    instance.setAttribute('title', 'foo');
     39    assert_array_equals(element.takeLog().types(), ['constructed', 'attributeChanged']);
     40    instance.attributes.title.firstChild.insertData(2, 'bar');
     41    var logEntries = element.takeLog();
     42    assert_array_equals(logEntries.types(), ['attributeChanged']);
     43    assert_attribute_log_entry(logEntries.last(), {name: 'title', oldValue: 'foo', newValue: 'fobaro', namespace: null});
     44}, 'insertData on CharacterData must enqueue an attributeChangedCallback when mutating an existing attribute');
     45
     46test(function () {
     47    var element = define_new_custom_element(['title']);
     48    var instance = document.createElement(element.name);
     49    instance.setAttribute('title', 'hello world');
     50    assert_array_equals(element.takeLog().types(), ['constructed', 'attributeChanged']);
     51    instance.attributes.title.firstChild.deleteData(5, 100);
     52    var logEntries = element.takeLog();
     53    assert_array_equals(logEntries.types(), ['attributeChanged']);
     54    assert_attribute_log_entry(logEntries.last(), {name: 'title', oldValue: 'hello world', newValue: 'hello', namespace: null});
     55}, 'deleteData on CharacterData must enqueue an attributeChangedCallback when mutating an existing attribute');
     56
     57test(function () {
     58    var element = define_new_custom_element(['title']);
     59    var instance = document.createElement(element.name);
     60    instance.setAttribute('title', 'hello');
     61    assert_array_equals(element.takeLog().types(), ['constructed', 'attributeChanged']);
     62    instance.attributes.title.firstChild.replaceData(1, 4, 'i');
     63    var logEntries = element.takeLog();
     64    assert_array_equals(logEntries.types(), ['attributeChanged']);
     65    assert_attribute_log_entry(logEntries.last(), {name: 'title', oldValue: 'hello', newValue: 'hi', namespace: null});
     66}, 'replaceData on CharacterData must enqueue an attributeChangedCallback when mutating an existing attribute');
     67
     68test_with_window(function (contentWindow) {
     69    const element = define_custom_element_in_window(contentWindow, 'custom-element', []);
     70
     71    const contentDocument = contentWindow.document;
     72    contentDocument.body.innerHTML = `<select><option></option></select>`;
     73    const option = contentDocument.querySelector('option');
     74
     75    const instance = contentDocument.createElement(element.name);
     76    option.appendChild(instance);
     77    instance.textContent = 'hello';
     78
     79    assert_array_equals(element.takeLog().types(), ['constructed', 'connected']);
     80    assert_equals(option.innerHTML, '<custom-element>hello</custom-element>');
     81
     82    const select = contentDocument.querySelector('select');
     83    assert_equals(select.options[0], option);
     84    select.options.remove(option);
     85    assert_equals(select.options.length, 0);
     86    assert_array_equals(element.takeLog().types(), ['disconnected']);
     87}, 'remove(HTMLOptionElement) on HTMLOptionsCollection must enqueue disconnectedCallback when removing a custom element');
     88
     89test_with_window(function (contentWindow) {
     90    const element = define_custom_element_in_window(contentWindow, 'custom-element', []);
     91
     92    const contentDocument = contentWindow.document;
     93    contentDocument.body.innerHTML = `<select><option></option></select>`;
     94    const option = contentDocument.querySelector('option');
     95
     96    const instance = contentDocument.createElement(element.name);
     97    option.appendChild(instance);
     98    instance.textContent = 'hello';
     99
     100    assert_array_equals(element.takeLog().types(), ['constructed', 'connected']);
     101    assert_equals(option.innerHTML, '<custom-element>hello</custom-element>');
     102
     103    const select = contentDocument.querySelector('select');
     104    assert_equals(select.options[0], option);
     105    select.remove(option);
     106    assert_equals(select.options.length, 0);
     107    assert_array_equals(element.takeLog().types(), ['disconnected']);
     108}, 'remove(HTMLOptionElement) on HTMLSelectElement must enqueue disconnectedCallback when removing a custom element');
     109
    19110</script>
    20111</body>

  • trunk/LayoutTests/fast/custom-elements/upgrading-enqueue-reactions-expected.txt

    r207710 r208082  
    1 CONSOLE MESSAGE: line 157: Exception thrown as a part of test
     1CONSOLE MESSAGE: line 140: Exception thrown as a part of test
    22
    33PASS Upgrading a custom element must enqueue attributeChangedCallback on each attribute

  • trunk/LayoutTests/fast/custom-elements/upgrading-enqueue-reactions.html

    r207710 r208082  
    99<script src="../../resources/testharnessreport.js"></script>
    1010<script src="../../imported/w3c/web-platform-tests/custom-elements/resources/custom-elements-helpers.js"></script>
     11<script src="resources/additional-helpers.js"></script>
    1112</head>
    1213<body>
    … …  
    1415<script>
    1516setup({allow_uncaught_exception:true});
    16 
    17 function create_constructor_log(element) {
    18     return {type: 'constructed', element: element};
    19 }
    20 
    21 function assert_constructor_log_entry(log, element) {
    22     assert_equals(log.type, 'constructed');
    23     assert_equals(log.element, element);
    24 }
    25 
    26 function create_connected_callback_log(element) {
    27     return {type: 'connected', element: element};
    28 }
    29 
    30 function assert_connected_log_entry(log, element) {
    31     assert_equals(log.type, 'connected');
    32     assert_equals(log.element, element);
    33 }
    3417
    3518test_with_window(function (contentWindow) {

  • trunk/LayoutTests/platform/efl/TestExpectations

    r208057 r208082  
    16371637# Requires INDIE_UI support
    16381638webkit.org/b/111446 indieui [ Skip ]
     1639webkit.org/b/111446 fast/custom-elements/reactions-for-indieui.html [ Skip ]
    16391640
    16401641# Requires support for Web notifications

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r208003 r208082  
    177177# Datalist is not yet enabled.
    178178webkit.org/b/98934 fast/forms/datalist [ Skip ]
     179webkit.org/b/98934 fast/custom-elements/reactions-for-indieui.html [ Skip ]
    179180
    180181# ENABLE_INPUT_TYPE_* are not enabled.

  • trunk/Source/WebCore/ChangeLog

    r208080 r208082  
     12016-10-28  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        Add CEReactions to the remaining HTML DOM APIs
     4        https://bugs.webkit.org/show_bug.cgi?id=163969
     5
     6        Reviewed by Chris Dumez.
     7
     8        Added CEReactions to the remaining DOM and HTML APIs as needed.
     9
     10        Tests: fast/custom-elements/reactions-for-indieui.html
     11               fast/custom-elements/reactions/Document.html
     12               fast/custom-elements/reactions/HTMLAnchorElement.html
     13               fast/custom-elements/reactions/HTMLOptionElement.html
     14               fast/custom-elements/reactions/HTMLOptionsCollection.html
     15               fast/custom-elements/reactions/HTMLOutputElement.html
     16               fast/custom-elements/reactions/HTMLSelectElement.html
     17               fast/custom-elements/reactions/HTMLTableElement.html
     18               fast/custom-elements/reactions/HTMLTableRowElement.html
     19               fast/custom-elements/reactions/HTMLTableSectionElement.html
     20               fast/custom-elements/reactions/HTMLTitleElement.html
     21               fast/custom-elements/reactions/ShadowRoot.html
     22
     23        * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
     24        (WebCore::JSHTMLOptionsCollection::setLength):
     25        (WebCore::JSHTMLOptionsCollection::indexSetter):
     26        * bindings/js/JSHTMLSelectElementCustom.cpp:
     27        (WebCore::JSHTMLSelectElement::indexSetter):
     28        * dom/CharacterData.idl:
     29        * dom/Document.idl:
     30        * dom/Element.idl:
     31        * dom/ShadowRoot.idl:
     32        * html/HTMLAnchorElement.idl:
     33        * html/HTMLDocument.idl:
     34        * html/HTMLOptionElement.idl:
     35        * html/HTMLOptionsCollection.idl:
     36        * html/HTMLOutputElement.idl:
     37        * html/HTMLSelectElement.idl:
     38        * html/HTMLTableElement.idl:
     39        * html/HTMLTableRowElement.idl:
     40        * html/HTMLTableSectionElement.idl:
     41        * html/HTMLTitleElement.idl:
     42
    1432016-10-28  Antoine Quint  <graouts@apple.com>
    244

  • trunk/Source/WebCore/bindings/js/JSHTMLOptionsCollectionCustom.cpp

    r204063 r208082  
    2121#include "JSHTMLOptionsCollection.h"
    2222
     23#include "CustomElementReactionQueue.h"
    2324#include "ExceptionCode.h"
    2425#include "HTMLNames.h"
    … …  
    5051void JSHTMLOptionsCollection::setLength(ExecState& state, JSValue value)
    5152{
     53#if ENABLE(CUSTOM_ELEMENTS)
     54    CustomElementReactionStack customElementReactionStack;
     55#endif
     56
    5257    ExceptionCode ec = 0;
    5358    unsigned newLength = 0;
    … …  
    6873void JSHTMLOptionsCollection::indexSetter(ExecState* exec, unsigned index, JSValue value)
    6974{
     75#if ENABLE(CUSTOM_ELEMENTS)
     76    CustomElementReactionStack customElementReactionStack;
     77#endif
     78
    7079    selectIndexSetter(&wrapped().selectElement(), exec, index, value);
    7180}

  • trunk/Source/WebCore/bindings/js/JSHTMLSelectElementCustom.cpp

    r204064 r208082  
    2222#include "JSHTMLSelectElementCustom.h"
    2323
     24#include "CustomElementReactionQueue.h"
    2425#include "ExceptionCode.h"
    2526#include "HTMLNames.h"
    … …  
    5051void JSHTMLSelectElement::indexSetter(JSC::ExecState* exec, unsigned index, JSC::JSValue value)
    5152{
     53#if ENABLE(CUSTOM_ELEMENTS)
     54    CustomElementReactionStack customElementReactionStack;
     55#endif
    5256    selectIndexSetter(&wrapped(), exec, index, value);
    5357}

  • trunk/Source/WebCore/dom/CharacterData.idl

    r206723 r208082  
    1919
    2020interface CharacterData : Node {
    21     [TreatNullAs=EmptyString] attribute DOMString data;
     21    [CEReactions, TreatNullAs=EmptyString] attribute DOMString data;
    2222    readonly attribute unsigned long length;
    2323
    2424    [MayThrowLegacyException] DOMString? substringData(unsigned long offset, unsigned long length);
    2525
    26     void appendData(DOMString data);
    27     [MayThrowLegacyException] void insertData(unsigned long offset, DOMString data);
    28     [MayThrowLegacyException] void deleteData(unsigned long offset, unsigned long length);
    29     [MayThrowLegacyException] void replaceData(unsigned long offset, unsigned long length, DOMString data);
     26    [CEReactions] void appendData(DOMString data);
     27    [CEReactions, MayThrowLegacyException] void insertData(unsigned long offset, DOMString data);
     28    [CEReactions, MayThrowLegacyException] void deleteData(unsigned long offset, unsigned long length);
     29    [CEReactions, MayThrowLegacyException] void replaceData(unsigned long offset, unsigned long length, DOMString data);
    3030};
    3131

  • trunk/Source/WebCore/dom/Document.idl

    r208070 r208082  
    9292    DOMString queryCommandValue(DOMString command);
    9393
    94     attribute DOMString title;
     94    [CEReactions] attribute DOMString title;
    9595    attribute DOMString dir;
    9696    attribute DOMString designMode;
    … …  
    102102    [GetterMayThrowLegacyException, SetterMayThrowLegacyException] attribute USVString cookie;
    103103
    104     [SetterMayThrowLegacyException, ImplementedAs=bodyOrFrameset] attribute HTMLElement? body;
     104    [CEReactions, ImplementedAs=bodyOrFrameset, SetterMayThrowLegacyException] attribute HTMLElement? body;
    105105
    106106    readonly attribute HTMLHeadElement? head;

  • trunk/Source/WebCore/dom/Element.idl

    r208001 r208082  
    122122
    123123#if defined(ENABLE_INDIE_UI) && ENABLE_INDIE_UI
    124     [Reflect] attribute DOMString uiactions;
     124    [CEReactions, Reflect] attribute DOMString uiactions;
    125125#endif
    126126

  • trunk/Source/WebCore/dom/ShadowRoot.idl

    r208001 r208082  
    3131    readonly attribute Element          host;
    3232
    33     [TreatNullAs=EmptyString, SetterMayThrowLegacyException] attribute DOMString innerHTML;
     33    [CEReactions, SetterMayThrowLegacyException, TreatNullAs=EmptyString] attribute DOMString innerHTML;
    3434};
    3535

  • trunk/Source/WebCore/html/HTMLAnchorElement.idl

    r207355 r208082  
    3232    [Reflect] attribute DOMString type;
    3333
    34     attribute DOMString text;
     34    [CEReactions] attribute DOMString text;
    3535
    3636    [PutForwards=value] readonly attribute DOMTokenList relList;

  • trunk/Source/WebCore/html/HTMLDocument.idl

    r207519 r208082  
    2626    OverrideBuiltins,
    2727] interface HTMLDocument : Document {
    28     [Custom, ForwardDeclareInHeader] void open();
     28    [CEReactions, Custom, ForwardDeclareInHeader] void open();
    2929    void close();
    30     [Custom] void write(optional DOMString text);
    31     [Custom] void writeln(optional DOMString text);
     30    [CEReactions, Custom] void write(optional DOMString text);
     31    [CEReactions, Custom] void writeln(optional DOMString text);
    3232
    3333    [Custom, Replaceable] readonly attribute HTMLAllCollection all;

  • trunk/Source/WebCore/html/HTMLOptionElement.idl

    r206723 r208082  
    3131    attribute DOMString value;
    3232
    33     attribute DOMString text;
     33    [CEReactions] attribute DOMString text;
    3434    readonly attribute long index;
    3535};

  • trunk/Source/WebCore/html/HTMLOptionsCollection.idl

    r207497 r208082  
    2626] interface HTMLOptionsCollection : HTMLCollection {
    2727    attribute long selectedIndex;
    28     [CustomSetter, SetterMayThrowLegacyException] attribute unsigned long length;
     28    [CEReactions, CustomSetter, SetterMayThrowLegacyException] attribute unsigned long length;
    2929
    3030    getter HTMLOptionElement? item(unsigned long index);
    3131    getter HTMLOptionElement? namedItem(DOMString name);
    3232
    33     [MayThrowException] void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null);
     33    [CEReactions, MayThrowException] void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null);
    3434
    35     void remove(long index);
     35    [CEReactions] void remove(long index);
    3636    // FIXME: This overload is not in the specification and has been dropped in Blink.
    37     void remove(HTMLOptionElement option);
     37    [CEReactions] void remove(HTMLOptionElement option);
    3838};

  • trunk/Source/WebCore/html/HTMLOutputElement.idl

    r207426 r208082  
    3030
    3131    readonly attribute DOMString type;
    32     [TreatNullAs=EmptyString] attribute DOMString defaultValue;
    33     [TreatNullAs=EmptyString] attribute DOMString value;
     32    [CEReactions, TreatNullAs=EmptyString] attribute DOMString defaultValue;
     33    [CEReactions, TreatNullAs=EmptyString] attribute DOMString value;
    3434
    3535    readonly attribute boolean willValidate;

  • trunk/Source/WebCore/html/HTMLSelectElement.idl

    r207497 r208082  
    3636
    3737    readonly attribute HTMLOptionsCollection options;
    38     [SetterMayThrowLegacyException] attribute unsigned long length;
     38    [CEReactions, SetterMayThrowLegacyException] attribute unsigned long length;
    3939
    4040    getter HTMLOptionElement? item(unsigned long index);
    4141    HTMLOptionElement? namedItem(DOMString name);
    4242
    43     [MayThrowException] void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null);
     43    [CEReactions, MayThrowException] void add((HTMLOptionElement or HTMLOptGroupElement) element, optional (HTMLElement or long)? before = null);
    4444
    4545    [MayThrowLegacyException] void remove(); // ChildNode overload
    4646    // FIXME: This overload is not in the specification and was dropped in Blink.
    47     void remove(HTMLOptionElement option);
    48     [ImplementedAs=removeByIndex] void remove(long index);
     47    [CEReactions] void remove(HTMLOptionElement option);
     48    [CEReactions, ImplementedAs=removeByIndex] void remove(long index);
    4949
    5050    readonly attribute HTMLCollection selectedOptions;

  • trunk/Source/WebCore/html/HTMLTableElement.idl

    r207355 r208082  
    2020
    2121interface HTMLTableElement : HTMLElement {
    22     [SetterMayThrowLegacyException] attribute HTMLTableCaptionElement? caption;
    23     [SetterMayThrowLegacyException] attribute HTMLTableSectionElement? tHead;
    24     [SetterMayThrowLegacyException] attribute HTMLTableSectionElement? tFoot;
     22    [CEReactions, SetterMayThrowLegacyException] attribute HTMLTableCaptionElement? caption;
     23    [CEReactions, SetterMayThrowLegacyException] attribute HTMLTableSectionElement? tHead;
     24    [CEReactions, SetterMayThrowLegacyException] attribute HTMLTableSectionElement? tFoot;
    2525
    2626    readonly attribute HTMLCollection rows;
    … …  
    3939
    4040    HTMLElement createTHead();
    41     void deleteTHead();
     41    [CEReactions] void deleteTHead();
    4242    HTMLElement createTFoot();
    43     void deleteTFoot();
     43    [CEReactions] void deleteTFoot();
    4444    HTMLElement createTBody();
    4545    HTMLElement createCaption();
    46     void deleteCaption();
     46    [CEReactions] void deleteCaption();
    4747
    4848    [MayThrowLegacyException] HTMLElement insertRow(optional long index = -1);
    49     [MayThrowLegacyException] void deleteRow(long index);
     49    [CEReactions, MayThrowLegacyException] void deleteRow(long index);
    5050};
    5151

  • trunk/Source/WebCore/html/HTMLTableRowElement.idl

    r207355 r208082  
    2929    [Reflect] attribute DOMString vAlign;
    3030    [MayThrowLegacyException] HTMLElement insertCell(optional long index = -1);
    31     [MayThrowLegacyException] void deleteCell(long index);
     31    [CEReactions, MayThrowLegacyException] void deleteCell(long index);
    3232};
    3333

  • trunk/Source/WebCore/html/HTMLTableSectionElement.idl

    r207355 r208082  
    2828    readonly attribute HTMLCollection rows;
    2929    [MayThrowLegacyException] HTMLElement insertRow(optional long index = -1);
    30     [MayThrowLegacyException] void deleteRow(long index);
     30    [CEReactions, MayThrowLegacyException] void deleteRow(long index);
    3131};
    3232

  • trunk/Source/WebCore/html/HTMLTitleElement.idl

    r205104 r208082  
    1919
    2020interface HTMLTitleElement : HTMLElement {
    21     attribute DOMString text;
     21    [CEReactions] attribute DOMString text;
    2222};
    2323
Note: See TracChangeset for help on using the changeset viewer.