Changeset 208413 in webkit

Timestamp:

Nov 4, 2016 7:48:16 PM (7 years ago)

Author:

jfbastien@apple.com

Message:

testWASM should be very sad if no options are provided
​https://bugs.webkit.org/show_bug.cgi?id=164444

Reviewed by Saam Barati.

Detect missing or invalid options on the command line.

• testWasm.cpp:

(CommandLine::parseArguments):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• testWasm.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-11-04  JF Bastien  <jfbastien@apple.com>
+
+        testWASM should be very sad if no options are provided
+        https://bugs.webkit.org/show_bug.cgi?id=164444
+
+        Reviewed by Saam Barati.
+
+        Detect missing or invalid options on the command line.
+
+        * testWasm.cpp:
+        (CommandLine::parseArguments):
+
 2016-11-04  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/testWasm.cpp

@@ -47 +47 @@
     }
 
-    Vector<String> m_arguments;
     bool m_runLEBTests { false };
     bool m_runWasmTests { false };
@@ -69 +68 @@
     int i = 1;
 
+    if (argc == i)
+        printUsageStatement(false);
+
     for (; i < argc; ++i) {
         const char* arg = argv[i];
-        if (!strcmp(arg, "-h") || !strcmp(arg, "--help"))
+
+        if (!strcmp(arg, "-h") || !strcmp(arg, "--help")) {
             printUsageStatement(true);
-
-        if (!strcmp(arg, "-l") || !strcmp(arg, "--leb"))
+            RELEASE_ASSERT_NOT_REACHED();
+        }
+
+        if (!strcmp(arg, "-l") || !strcmp(arg, "--leb")) {
             m_runLEBTests = true;
-
-        if (!strcmp(arg, "-w") || !strcmp(arg, "--web"))
+            continue;
+        }
+
+        if (!strcmp(arg, "-w") || !strcmp(arg, "--web")) {
             m_runWasmTests = true;
-    }
-
-    for (; i < argc; ++i)
-        m_arguments.append(argv[i]);
-
+            continue;
+        }
+
+        fprintf(stderr, "Unknown option %s\n", arg);
+        printUsageStatement(false);
+    }
 }