Changeset 208801 in webkit


Ignore:
Timestamp:
Nov 16, 2016 12:18:45 PM (7 years ago)
Author:
jiewen_tan@apple.com
Message:

Add more tests for SubtleCrypto::importKey and SubtleCrypto::exportKey
https://bugs.webkit.org/show_bug.cgi?id=164815
<rdar://problem/29281660>

Reviewed by Brent Fulgham.

Source/WebCore:

Tests: crypto/subtle/aes-import-jwk-key-export-jwk-key.html

crypto/subtle/aes-import-jwk-key-export-raw-key.html
crypto/subtle/aes-import-raw-key-export-jwk-key.html
crypto/subtle/aes-import-raw-key-export-raw-key.html
crypto/subtle/hmac-import-jwk-key-export-jwk-key.html
crypto/subtle/hmac-import-jwk-key-export-raw-key.html
crypto/subtle/hmac-import-raw-key-export-jwk-key.html
crypto/subtle/hmac-import-raw-key-export-raw-key.html
crypto/subtle/rsa-import-jwk-key-export-jwk-key-private.html
crypto/subtle/rsa-import-jwk-key-export-jwk-key-public.html

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::create):
Add a comment.

LayoutTests:

  • crypto/subtle/aes-import-jwk-key-export-jwk-key.html: Added.
  • crypto/subtle/aes-import-jwk-key-export-raw-key.html: Added.
  • crypto/subtle/aes-import-raw-key-export-jwk-key.html: Added.
  • crypto/subtle/aes-import-raw-key-export-raw-key.html: Added.
  • crypto/subtle/hmac-import-jwk-key-export-jwk-key.html: Added.
  • crypto/subtle/hmac-import-jwk-key-export-raw-key.html: Added.
  • crypto/subtle/hmac-import-raw-key-export-jwk-key.html: Added.
  • crypto/subtle/hmac-import-raw-key-export-raw-key.html: Added.
  • crypto/subtle/rsa-import-jwk-key-export-jwk-key-private.html: Added.
  • crypto/subtle/rsa-import-jwk-key-export-jwk-key-public.html: Added.
Location:
trunk
Files:
20 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r208798 r208801  
     12016-11-16  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Add more tests for SubtleCrypto::importKey and SubtleCrypto::exportKey
     4        https://bugs.webkit.org/show_bug.cgi?id=164815
     5        <rdar://problem/29281660>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        * crypto/subtle/aes-import-jwk-key-export-jwk-key.html: Added.
     10        * crypto/subtle/aes-import-jwk-key-export-raw-key.html: Added.
     11        * crypto/subtle/aes-import-raw-key-export-jwk-key.html: Added.
     12        * crypto/subtle/aes-import-raw-key-export-raw-key.html: Added.
     13        * crypto/subtle/hmac-import-jwk-key-export-jwk-key.html: Added.
     14        * crypto/subtle/hmac-import-jwk-key-export-raw-key.html: Added.
     15        * crypto/subtle/hmac-import-raw-key-export-jwk-key.html: Added.
     16        * crypto/subtle/hmac-import-raw-key-export-raw-key.html: Added.
     17        * crypto/subtle/rsa-import-jwk-key-export-jwk-key-private.html: Added.
     18        * crypto/subtle/rsa-import-jwk-key-export-jwk-key-public.html: Added.
     19
    1202016-11-16  Ryan Haddad  <ryanhaddad@apple.com>
    221
  • trunk/Source/WebCore/ChangeLog

    r208797 r208801  
     12016-11-16  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Add more tests for SubtleCrypto::importKey and SubtleCrypto::exportKey
     4        https://bugs.webkit.org/show_bug.cgi?id=164815
     5        <rdar://problem/29281660>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        Tests: crypto/subtle/aes-import-jwk-key-export-jwk-key.html
     10               crypto/subtle/aes-import-jwk-key-export-raw-key.html
     11               crypto/subtle/aes-import-raw-key-export-jwk-key.html
     12               crypto/subtle/aes-import-raw-key-export-raw-key.html
     13               crypto/subtle/hmac-import-jwk-key-export-jwk-key.html
     14               crypto/subtle/hmac-import-jwk-key-export-raw-key.html
     15               crypto/subtle/hmac-import-raw-key-export-jwk-key.html
     16               crypto/subtle/hmac-import-raw-key-export-raw-key.html
     17               crypto/subtle/rsa-import-jwk-key-export-jwk-key-private.html
     18               crypto/subtle/rsa-import-jwk-key-export-jwk-key-public.html
     19
     20        * crypto/mac/CryptoKeyRSAMac.cpp:
     21        (WebCore::CryptoKeyRSA::create):
     22        Add a comment.
     23
    1242016-11-16  Antti Koivisto  <antti@apple.com>
    225
  • trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp

    r208669 r208801  
    118118    }
    119119    CCRSACryptorRef cryptor;
     120    // FIXME: It is so weired that we recaculate the private exponent from first prime factor and second prime factor,
     121    // given the fact that we have already had it. Also, the re-caculated private exponent may not match the given one.
     122    // See <rdar://problem/15452324>.
    120123    CCCryptorStatus status = CCRSACryptorCreateFromData(
    121124        keyData.type() == CryptoKeyDataRSAComponents::Type::Public ? ccRSAKeyPublic : ccRSAKeyPrivate,
Note: See TracChangeset for help on using the changeset viewer.