Changeset 208858 in webkit
- Timestamp:
- Nov 17, 2016 1:20:20 PM (7 years ago)
- Location:
- trunk
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r208857 r208858 1 2016-11-17 Brent Fulgham <bfulgham@apple.com> 2 3 keygen element should not support < 2048 RSA key lengths 4 https://bugs.webkit.org/show_bug.cgi?id=164874 5 <rdar://problem/22618141> 6 7 Reviewed by Dean Jackson. 8 9 * platform/mac/fast/html/keygen-expected.txt: 10 * platform/mac-elcapitan/fast/html/keygen-expected.txt: 11 1 12 2016-11-17 Devin Rousso <dcrousso+webkit@gmail.com> 2 13 -
trunk/LayoutTests/platform/mac-elcapitan/fast/html/keygen-expected.txt
r202826 r208858 4 4 RenderBlock {HTML} at (0,0) size 800x600 5 5 RenderBody {BODY} at (8,8) size 784x584 6 RenderBlock {KEYGEN} at (2,2) size 1 46x187 RenderMenuList {SELECT} at (0,0) size 1 46x18 [bgcolor=#FFFFFF]8 RenderBlock (anonymous) at (0,0) size 1 46x186 RenderBlock {KEYGEN} at (2,2) size 128x18 7 RenderMenuList {SELECT} at (0,0) size 128x18 [bgcolor=#FFFFFF] 8 RenderBlock (anonymous) at (0,0) size 128x18 9 9 RenderText at (8,2) size 97x13 10 10 text run at (8,2) width 97: "2048 (High Grade)" -
trunk/LayoutTests/platform/mac/fast/html/keygen-expected.txt
r202826 r208858 4 4 RenderBlock {HTML} at (0,0) size 800x600 5 5 RenderBody {BODY} at (8,8) size 784x584 6 RenderBlock {KEYGEN} at (2,2) size 1 45x187 RenderMenuList {SELECT} at (0,0) size 1 45x18 [bgcolor=#FFFFFF]8 RenderBlock (anonymous) at (0,0) size 1 45x186 RenderBlock {KEYGEN} at (2,2) size 128x18 7 RenderMenuList {SELECT} at (0,0) size 128x18 [bgcolor=#FFFFFF] 8 RenderBlock (anonymous) at (0,0) size 128x18 9 9 RenderText at (8,2) size 99x13 10 10 text run at (8,2) width 99: "2048 (High Grade)" -
trunk/Source/WebCore/ChangeLog
r208851 r208858 1 2016-11-17 Brent Fulgham <bfulgham@apple.com> 2 3 keygen element should not support < 2048 RSA key lengths 4 https://bugs.webkit.org/show_bug.cgi?id=164874 5 <rdar://problem/22618141> 6 7 Reviewed by Dean Jackson. 8 9 Remove the two insecure RSA choices (512-bit and 1024-bit) so that users 10 do not accidentally select a bad key length. 11 12 Tested by fast/html/keygen.html 13 14 * platform/LocalizedStrings.cpp: 15 (WebCore::keygenMenuItem512): Deleted. 16 (WebCore::keygenMenuItem1024): Deleted. 17 * platform/LocalizedStrings.h: 18 * platform/mac/SSLKeyGeneratorMac.mm: 19 (WebCore::signedPublicKeyAndChallengeString): ASSERT on bad key size. 20 (WebCore::getSupportedKeySizes): Remove bad key sizes. 21 (WebCore::signedPublicKeyAndChallengeString): Ditto. 22 * platform/win/SSLKeyGeneratorWin.cpp: 23 (WebCore::WebCore::getSupportedKeySizes): Ditto. 24 1 25 2016-11-17 Eric Carlson <eric.carlson@apple.com> 2 26 -
trunk/Source/WebCore/platform/LocalizedStrings.cpp
r207860 r208858 868 868 } 869 869 870 String keygenMenuItem512()871 {872 return WEB_UI_STRING("512 (Low Grade)", "Menu item title for KEYGEN pop-up menu");873 }874 875 String keygenMenuItem1024()876 {877 return WEB_UI_STRING("1024 (Medium Grade)", "Menu item title for KEYGEN pop-up menu");878 }879 880 870 String keygenMenuItem2048() 881 871 { -
trunk/Source/WebCore/platform/LocalizedStrings.h
r207583 r208858 225 225 WEBCORE_EXPORT String pdfDocumentTypeDescription(); 226 226 WEBCORE_EXPORT String postScriptDocumentTypeDescription(); 227 String keygenMenuItem512();228 String keygenMenuItem1024();229 227 String keygenMenuItem2048(); 230 228 String keygenKeychainItemName(const String& host); -
trunk/Source/WebCore/platform/mac/SSLKeyGeneratorMac.mm
r204567 r208858 125 125 static String signedPublicKeyAndChallengeString(unsigned keySize, const CString& challenge, const String& keyDescription) 126 126 { 127 ASSERT(keySize >= 2048); 128 127 129 SignedPublicKeyAndChallenge signedPublicKeyAndChallenge { }; 128 130 … … 216 218 ASSERT(supportedKeySizes.isEmpty()); 217 219 supportedKeySizes.append(keygenMenuItem2048()); 218 supportedKeySizes.append(keygenMenuItem1024());219 supportedKeySizes.append(keygenMenuItem512());220 220 } 221 221 … … 228 228 keySize = 2048; 229 229 break; 230 case 1:231 keySize = 1024;232 break;233 case 2:234 keySize = 512;235 break;236 230 default: 237 231 ASSERT_NOT_REACHED(); -
trunk/Source/WebCore/platform/win/SSLKeyGeneratorWin.cpp
r156550 r208858 33 33 // FIXME: Strings should be localizable. 34 34 v.append("High Grade"); 35 v.append("Medium Grade");36 35 } 37 36
Note: See TracChangeset
for help on using the changeset viewer.